Title: [217556] trunk/Tools
- Revision
- 217556
- Author
- [email protected]
- Date
- 2017-05-30 08:33:02 -0700 (Tue, 30 May 2017)
Log Message
ASSERTION FAILED: !needsLayout() in com.apple.WebCore: WebCore::FrameView::paintContents in fast/events/tabindex-focus-blur-all.html on WK1
https://bugs.webkit.org/show_bug.cgi?id=172713
Reviewed by Zalan Bujtas.
* DumpRenderTree/mac/ResourceLoadDelegate.mm:
(-[ResourceLoadDelegate webView:plugInFailedWithError:dataSource:]):
Remove forced display from plugin resource load delegate. It is testing some long-obsolete
Safari WK1 behavior. Forcing display from this resource load delegate will hit the assertion
because on Mac WK1 it may get invoked from middle of a layout.
Painting code skips out after the assert so it doesn't indicate unsafe access of any sort.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (217555 => 217556)
--- trunk/Tools/ChangeLog 2017-05-30 14:43:43 UTC (rev 217555)
+++ trunk/Tools/ChangeLog 2017-05-30 15:33:02 UTC (rev 217556)
@@ -1,3 +1,19 @@
+2017-05-30 Antti Koivisto <[email protected]>
+
+ ASSERTION FAILED: !needsLayout() in com.apple.WebCore: WebCore::FrameView::paintContents in fast/events/tabindex-focus-blur-all.html on WK1
+ https://bugs.webkit.org/show_bug.cgi?id=172713
+
+ Reviewed by Zalan Bujtas.
+
+ * DumpRenderTree/mac/ResourceLoadDelegate.mm:
+ (-[ResourceLoadDelegate webView:plugInFailedWithError:dataSource:]):
+
+ Remove forced display from plugin resource load delegate. It is testing some long-obsolete
+ Safari WK1 behavior. Forcing display from this resource load delegate will hit the assertion
+ because on Mac WK1 it may get invoked from middle of a layout.
+
+ Painting code skips out after the assert so it doesn't indicate unsafe access of any sort.
+
2017-05-30 Carlos Alberto Lopez Perez <[email protected]>
Add a WPE EWS queue
Modified: trunk/Tools/DumpRenderTree/mac/ResourceLoadDelegate.mm (217555 => 217556)
--- trunk/Tools/DumpRenderTree/mac/ResourceLoadDelegate.mm 2017-05-30 14:43:43 UTC (rev 217555)
+++ trunk/Tools/DumpRenderTree/mac/ResourceLoadDelegate.mm 2017-05-30 15:33:02 UTC (rev 217556)
@@ -255,11 +255,6 @@
- (void)webView: (WebView *)wv plugInFailedWithError:(NSError *)error dataSource:(WebDataSource *)dataSource
{
-#if !PLATFORM(IOS)
- // The call to -display here simulates the "Plug-in not found" sheet that Safari shows.
- // It is used for platform/mac/plugins/update-widget-from-style-recalc.html
- [wv display];
-#endif
}
-(NSCachedURLResponse *) webView: (WebView *)wv resource:(id)identifier willCacheResponse:(NSCachedURLResponse *)response fromDataSource:(WebDataSource *)dataSource
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
