Title: [217752] trunk/LayoutTests
- Revision
- 217752
- Author
- [email protected]
- Date
- 2017-06-03 01:07:39 -0700 (Sat, 03 Jun 2017)
Log Message
http/tests/cache/disk-cache/shattered-deduplication.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=172868
<rdar://problem/31249379>
Reviewed by Antti Koivisto.
http/tests/cache/disk-cache/shattered-deduplication.html was flaky due to PDF banner
fade-in / fade-out animation.
<rdar://problem/31249379> is fixed for me with the proposed changes.
* http/tests/cache/disk-cache/shattered-deduplication-expected.html:
- Wait 1 second before calling notifyDone() to give the PDF as much time to render as
the test page.
- Reduce frame height to 30 to not have to worry about the PDF tool banner being visible
or not (as it fades in and out). 30 is still enough to see the color and confirm the
test is passing.
* http/tests/cache/disk-cache/shattered-deduplication.html:
- Reduce frame height to 30 to not have to worry about the PDF tool banner being visible
or not (as it fades in and out). 30 is still enough to see the color and confirm the
test is passing.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (217751 => 217752)
--- trunk/LayoutTests/ChangeLog 2017-06-03 04:40:38 UTC (rev 217751)
+++ trunk/LayoutTests/ChangeLog 2017-06-03 08:07:39 UTC (rev 217752)
@@ -1,3 +1,28 @@
+2017-06-03 Chris Dumez <[email protected]>
+
+ http/tests/cache/disk-cache/shattered-deduplication.html is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=172868
+ <rdar://problem/31249379>
+
+ Reviewed by Antti Koivisto.
+
+ http/tests/cache/disk-cache/shattered-deduplication.html was flaky due to PDF banner
+ fade-in / fade-out animation.
+
+ <rdar://problem/31249379> is fixed for me with the proposed changes.
+
+ * http/tests/cache/disk-cache/shattered-deduplication-expected.html:
+ - Wait 1 second before calling notifyDone() to give the PDF as much time to render as
+ the test page.
+ - Reduce frame height to 30 to not have to worry about the PDF tool banner being visible
+ or not (as it fades in and out). 30 is still enough to see the color and confirm the
+ test is passing.
+
+ * http/tests/cache/disk-cache/shattered-deduplication.html:
+ - Reduce frame height to 30 to not have to worry about the PDF tool banner being visible
+ or not (as it fades in and out). 30 is still enough to see the color and confirm the
+ test is passing.
+
2017-06-02 Myles C. Maxfield <[email protected]>
REGRESSION(r213464): [iOS] Fonts get too bold when the "Bold Text" accessibility setting is enabled
Modified: trunk/LayoutTests/http/tests/cache/disk-cache/shattered-deduplication-expected.html (217751 => 217752)
--- trunk/LayoutTests/http/tests/cache/disk-cache/shattered-deduplication-expected.html 2017-06-03 04:40:38 UTC (rev 217751)
+++ trunk/LayoutTests/http/tests/cache/disk-cache/shattered-deduplication-expected.html 2017-06-03 08:07:39 UTC (rev 217752)
@@ -1,4 +1,15 @@
-<iframe src="" width=100 height=100></iframe>
-<iframe src="" width=100 height=100></iframe>
-<iframe src="" width=100 height=100></iframe>
-<iframe src="" width=100 height=100></iframe>
+<iframe src="" width=100 height=30></iframe>
+<iframe src="" width=100 height=30></iframe>
+<iframe src="" width=100 height=30></iframe>
+<iframe src="" width=100 height=30></iframe>
+<script>
+if (window.testRunner)
+ testRunner.waitUntilDone();
+
+_onload_ = function() {
+ setTimeout(function() {
+ if (window.testRunner)
+ testRunner.notifyDone();
+ }, 1000);
+}
+</script>
Modified: trunk/LayoutTests/http/tests/cache/disk-cache/shattered-deduplication.html (217751 => 217752)
--- trunk/LayoutTests/http/tests/cache/disk-cache/shattered-deduplication.html 2017-06-03 04:40:38 UTC (rev 217751)
+++ trunk/LayoutTests/http/tests/cache/disk-cache/shattered-deduplication.html 2017-06-03 08:07:39 UTC (rev 217752)
@@ -15,7 +15,7 @@
const frame = document.createElement("iframe");
frame.width = 100;
- frame.height = 100;
+ frame.height = 30;
frame.src = ""
document.body.appendChild(frame);
document.body.appendChild(document.createTextNode("\n"));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
