Title: [217781] trunk/Tools
- Revision
- 217781
- Author
- [email protected]
- Date
- 2017-06-05 08:42:13 -0700 (Mon, 05 Jun 2017)
Log Message
ASSERTION FAILED: m_currentScriptCallbackID in UIScriptContext::requestUIScriptCompletion(JSStringRef) running fast/events/ios/autocorrect-with-range-selection.html
https://bugs.webkit.org/show_bug.cgi?id=172887
<rdar://problem/32546061>
Reviewed by Sam Weinig.
* WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptController::applyAutocorrection):
applyAutocorrection can call its completion handler synchronously,
which makes UIScriptController unhappy (see bug 172884).
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (217780 => 217781)
--- trunk/Tools/ChangeLog 2017-06-05 12:33:31 UTC (rev 217780)
+++ trunk/Tools/ChangeLog 2017-06-05 15:42:13 UTC (rev 217781)
@@ -1,3 +1,16 @@
+2017-06-05 Tim Horton <[email protected]>
+
+ ASSERTION FAILED: m_currentScriptCallbackID in UIScriptContext::requestUIScriptCompletion(JSStringRef) running fast/events/ios/autocorrect-with-range-selection.html
+ https://bugs.webkit.org/show_bug.cgi?id=172887
+ <rdar://problem/32546061>
+
+ Reviewed by Sam Weinig.
+
+ * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
+ (WTR::UIScriptController::applyAutocorrection):
+ applyAutocorrection can call its completion handler synchronously,
+ which makes UIScriptController unhappy (see bug 172884).
+
2017-06-03 Jonathan Bedard <[email protected]>
webkitpy: Add contextmanager to disable logging for a block
Modified: trunk/Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm (217780 => 217781)
--- trunk/Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm 2017-06-05 12:33:31 UTC (rev 217780)
+++ trunk/Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm 2017-06-05 15:42:13 UTC (rev 217781)
@@ -483,9 +483,13 @@
TestRunnerWKWebView *webView = TestController::singleton().mainWebView()->platformView();
[webView applyAutocorrection:toWTFString(toWK(newString)) toString:toWTFString(toWK(oldString)) withCompletionHandler:^ {
- if (!m_context)
- return;
- m_context->asyncTaskComplete(callbackID);
+ // applyAutocorrection can call its completion handler synchronously,
+ // which makes UIScriptController unhappy (see bug 172884).
+ dispatch_async(dispatch_get_main_queue(), ^ {
+ if (!m_context)
+ return;
+ m_context->asyncTaskComplete(callbackID);
+ });
}];
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
