[webkit-changes] [217808] trunk/Source/JavaScriptCore

Mon, 05 Jun 2017 17:04:54 -0700

Title: [217808] trunk/Source/_javascript_Core
Revision
217808
Author
[email protected]
Date
2017-06-05 17:03:53 -0700 (Mon, 05 Jun 2017)

Log Message

Remove unused VM members
https://bugs.webkit.org/show_bug.cgi?id=172941

Reviewed by Mark Lam.

* runtime/HashMapImpl.h:
(JSC::HashMapImpl::selectStructure): Deleted.
* runtime/VM.cpp:
(JSC::VM::VM):
* runtime/VM.h:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (217807 => 217808)


--- trunk/Source/_javascript_Core/ChangeLog	2017-06-05 23:52:25 UTC (rev 217807)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-06-06 00:03:53 UTC (rev 217808)
@@ -1,5 +1,18 @@
 2017-06-05  Joseph Pecoraro  <[email protected]>
 
+        Remove unused VM members
+        https://bugs.webkit.org/show_bug.cgi?id=172941
+
+        Reviewed by Mark Lam.
+
+        * runtime/HashMapImpl.h:
+        (JSC::HashMapImpl::selectStructure): Deleted.
+        * runtime/VM.cpp:
+        (JSC::VM::VM):
+        * runtime/VM.h:
+
+2017-06-05  Joseph Pecoraro  <[email protected]>
+
         Web Inspector: Improve ES6 Class instances in Heap Snapshot instances view
         https://bugs.webkit.org/show_bug.cgi?id=172848
         <rdar://problem/25709212>

Modified: trunk/Source/_javascript_Core/runtime/HashMapImpl.h (217807 => 217808)


--- trunk/Source/_javascript_Core/runtime/HashMapImpl.h	2017-06-05 23:52:25 UTC (rev 217807)
+++ trunk/Source/_javascript_Core/runtime/HashMapImpl.h	2017-06-06 00:03:53 UTC (rev 217808)
@@ -285,18 +285,6 @@
     using Base = JSNonFinalObject;
     using HashMapBufferType = HashMapBuffer<HashMapBucketType>;
 
-    template <typename T = HashMapBucketType>
-    static typename std::enable_if<std::is_same<T, HashMapBucket<HashMapBucketDataKey>>::value, Structure*>::type selectStructure(VM& vm)
-    {
-        return vm.hashMapImplSetStructure.get();
-    }
-
-    template <typename T = HashMapBucketType>
-    static typename std::enable_if<std::is_same<T, HashMapBucket<HashMapBucketDataKeyValue>>::value, Structure*>::type selectStructure(VM& vm)
-    {
-        return vm.hashMapImplMapStructure.get();
-    }
-
 public:
     using BucketType = HashMapBucketType;

Modified: trunk/Source/_javascript_Core/runtime/VM.cpp (217807 => 217808)


--- trunk/Source/_javascript_Core/runtime/VM.cpp	2017-06-05 23:52:25 UTC (rev 217807)
+++ trunk/Source/_javascript_Core/runtime/VM.cpp	2017-06-06 00:03:53 UTC (rev 217808)
@@ -180,8 +180,6 @@
     , symbolImplToSymbolMap(*this)
     , prototypeMap(*this)
     , interpreter(0)
-    , jsArrayClassInfo(JSArray::info())
-    , jsFinalObjectClassInfo(JSFinalObject::info())
     , sizeOfLastScratchBuffer(0)
     , entryScope(0)
     , m_regExpCache(new RegExpCache(this))
@@ -224,8 +222,6 @@
     customGetterSetterStructure.set(*this, CustomGetterSetter::createStructure(*this, 0, jsNull()));
     scopedArgumentsTableStructure.set(*this, ScopedArgumentsTable::createStructure(*this, 0, jsNull()));
     apiWrapperStructure.set(*this, JSAPIValueWrapper::createStructure(*this, 0, jsNull()));
-    JSScopeStructure.set(*this, JSScope::createStructure(*this, 0, jsNull()));
-    executableStructure.set(*this, ExecutableBase::createStructure(*this, 0, jsNull()));
     nativeExecutableStructure.set(*this, NativeExecutable::createStructure(*this, 0, jsNull()));
     evalExecutableStructure.set(*this, EvalExecutable::createStructure(*this, 0, jsNull()));
     programExecutableStructure.set(*this, ProgramExecutable::createStructure(*this, 0, jsNull()));
@@ -265,7 +261,6 @@
     hashMapBucketSetStructure.set(*this, HashMapBucket<HashMapBucketDataKey>::createStructure(*this, 0, jsNull()));
     hashMapBucketMapStructure.set(*this, HashMapBucket<HashMapBucketDataKeyValue>::createStructure(*this, 0, jsNull()));
 
-    iterationTerminator.set(*this, JSFinalObject::create(*this, JSFinalObject::createStructure(*this, 0, jsNull(), 1)));
     nativeStdFunctionCellStructure.set(*this, NativeStdFunctionCell::createStructure(*this, 0, jsNull()));
     smallStrings.initializeCommonStrings(*this);

Modified: trunk/Source/_javascript_Core/runtime/VM.h (217807 => 217808)


--- trunk/Source/_javascript_Core/runtime/VM.h	2017-06-05 23:52:25 UTC (rev 217807)
+++ trunk/Source/_javascript_Core/runtime/VM.h	2017-06-06 00:03:53 UTC (rev 217808)
@@ -314,8 +314,6 @@
     Strong<Structure> customGetterSetterStructure;
     Strong<Structure> scopedArgumentsTableStructure;
     Strong<Structure> apiWrapperStructure;
-    Strong<Structure> JSScopeStructure;
-    Strong<Structure> executableStructure;
     Strong<Structure> nativeExecutableStructure;
     Strong<Structure> evalExecutableStructure;
     Strong<Structure> programExecutableStructure;
@@ -355,10 +353,7 @@
     Strong<Structure> functionCodeBlockStructure;
     Strong<Structure> hashMapBucketSetStructure;
     Strong<Structure> hashMapBucketMapStructure;
-    Strong<Structure> hashMapImplSetStructure;
-    Strong<Structure> hashMapImplMapStructure;
 
-    Strong<JSCell> iterationTerminator;
     Strong<JSCell> emptyPropertyNameEnumerator;
 
     std::unique_ptr<PromiseDeferredTimer> promiseDeferredTimer;
@@ -525,9 +520,6 @@
     void* lastStackTop() { return m_lastStackTop; }
     void setLastStackTop(void*);
 
-    const ClassInfo* const jsArrayClassInfo;
-    const ClassInfo* const jsFinalObjectClassInfo;
-
     JSValue hostCallReturnValue;
     unsigned varargsLength;
     ExecState* newCallFrameReturnValue;

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to