Title: [217814] trunk/Source/_javascript_Core
- Revision
- 217814
- Author
- [email protected]
- Date
- 2017-06-05 19:59:54 -0700 (Mon, 05 Jun 2017)
Log Message
We don't properly parse init_expr when the opcode is an unexpected opcode
https://bugs.webkit.org/show_bug.cgi?id=172945
Reviewed by JF Bastien.
The bug is a simple typo. It should use the constant
`true` instead of `false` when invoking the WASM_PARSER_FAIL_IF
macro. This failure is already caught by spec tests that fail
on arm64 devices.
* wasm/WasmModuleParser.cpp:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (217813 => 217814)
--- trunk/Source/_javascript_Core/ChangeLog 2017-06-06 02:59:05 UTC (rev 217813)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-06-06 02:59:54 UTC (rev 217814)
@@ -1,3 +1,17 @@
+2017-06-05 Saam Barati <[email protected]>
+
+ We don't properly parse init_expr when the opcode is an unexpected opcode
+ https://bugs.webkit.org/show_bug.cgi?id=172945
+
+ Reviewed by JF Bastien.
+
+ The bug is a simple typo. It should use the constant
+ `true` instead of `false` when invoking the WASM_PARSER_FAIL_IF
+ macro. This failure is already caught by spec tests that fail
+ on arm64 devices.
+
+ * wasm/WasmModuleParser.cpp:
+
2017-06-05 Keith Miller <[email protected]>
OMG tier up checks should be a patchpoint
Modified: trunk/Source/_javascript_Core/wasm/WasmModuleParser.cpp (217813 => 217814)
--- trunk/Source/_javascript_Core/wasm/WasmModuleParser.cpp 2017-06-06 02:59:05 UTC (rev 217813)
+++ trunk/Source/_javascript_Core/wasm/WasmModuleParser.cpp 2017-06-06 02:59:54 UTC (rev 217814)
@@ -534,7 +534,7 @@
}
default:
- WASM_PARSER_FAIL_IF(false, "unknown init_expr opcode ", opcode);
+ WASM_PARSER_FAIL_IF(true, "unknown init_expr opcode ", opcode);
}
uint8_t endOpcode;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
