Title: [217836] trunk
- Revision
- 217836
- Author
- [email protected]
- Date
- 2017-06-06 09:29:20 -0700 (Tue, 06 Jun 2017)
Log Message
Rebaseline and enable media/modern-media-controls/airplay-support
https://bugs.webkit.org/show_bug.cgi?id=172980
Source/WebCore:
Reviewed by Eric Carlson.
Fixing a small issue in the modern media controls code which would yield
an error when manually creating a MediaController without a MediaControlsHost.
* Modules/modern-media-controls/media/media-controller.js:
(MediaController.prototype.get isAudio):
LayoutTests:
<rdar://problem/32589074>
Reviewed by Eric Carlson.
The test passes as-is on macOS, but needs to be skipped on iOS since we can't test AirPlay.
* platform/ios-simulator/TestExpectations:
* platform/mac/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (217835 => 217836)
--- trunk/LayoutTests/ChangeLog 2017-06-06 16:27:38 UTC (rev 217835)
+++ trunk/LayoutTests/ChangeLog 2017-06-06 16:29:20 UTC (rev 217836)
@@ -1,5 +1,18 @@
2017-06-06 Antoine Quint <[email protected]>
+ Rebaseline and enable media/modern-media-controls/airplay-support
+ https://bugs.webkit.org/show_bug.cgi?id=172980
+ <rdar://problem/32589074>
+
+ Reviewed by Eric Carlson.
+
+ The test passes as-is on macOS, but needs to be skipped on iOS since we can't test AirPlay.
+
+ * platform/ios-simulator/TestExpectations:
+ * platform/mac/TestExpectations:
+
+2017-06-06 Antoine Quint <[email protected]>
+
Rebaseline and enable media/modern-media-controls/airplay-placard
https://bugs.webkit.org/show_bug.cgi?id=172977
<rdar://problem/32588681>
Modified: trunk/LayoutTests/platform/ios-simulator/TestExpectations (217835 => 217836)
--- trunk/LayoutTests/platform/ios-simulator/TestExpectations 2017-06-06 16:27:38 UTC (rev 217835)
+++ trunk/LayoutTests/platform/ios-simulator/TestExpectations 2017-06-06 16:29:20 UTC (rev 217836)
@@ -60,4 +60,7 @@
media/modern-media-controls/audio/audio-controls-styles.html [ Pass ]
media/modern-media-controls/audio/audio-controls-metrics.html [ Pass ]
+# AirPlay cannot be tested on iOS
+webkit.org/b/166062 media/modern-media-controls/airplay-support [ Skip ]
+
webkit.org/b/172965 media/track/track-cue-overlap-snap-to-lines-not-set.html [ Failure ]
Modified: trunk/LayoutTests/platform/mac/TestExpectations (217835 => 217836)
--- trunk/LayoutTests/platform/mac/TestExpectations 2017-06-06 16:27:38 UTC (rev 217835)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2017-06-06 16:29:20 UTC (rev 217836)
@@ -1551,6 +1551,7 @@
# As a result, a host of tests need to be updated and being turned on selectively here.
media/modern-media-controls/airplay-button [ Pass ]
media/modern-media-controls/airplay-placard [ Pass ]
+media/modern-media-controls/airplay-support [ Pass ]
media/modern-media-controls/audio/audio-controls-metrics.html [ Pass ]
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag-is-prevented-over-button.html [ Pass ]
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag.html [ Pass ]
Modified: trunk/Source/WebCore/ChangeLog (217835 => 217836)
--- trunk/Source/WebCore/ChangeLog 2017-06-06 16:27:38 UTC (rev 217835)
+++ trunk/Source/WebCore/ChangeLog 2017-06-06 16:29:20 UTC (rev 217836)
@@ -1,5 +1,18 @@
2017-06-06 Antoine Quint <[email protected]>
+ Rebaseline and enable media/modern-media-controls/airplay-support
+ https://bugs.webkit.org/show_bug.cgi?id=172980
+
+ Reviewed by Eric Carlson.
+
+ Fixing a small issue in the modern media controls code which would yield
+ an error when manually creating a MediaController without a MediaControlsHost.
+
+ * Modules/modern-media-controls/media/media-controller.js:
+ (MediaController.prototype.get isAudio):
+
+2017-06-06 Antoine Quint <[email protected]>
+
Update modern media controls testing utilities
https://bugs.webkit.org/show_bug.cgi?id=172976
<rdar://problem/32588432>
Modified: trunk/Source/WebCore/Modules/modern-media-controls/media/media-controller.js (217835 => 217836)
--- trunk/Source/WebCore/Modules/modern-media-controls/media/media-controller.js 2017-06-06 16:27:38 UTC (rev 217835)
+++ trunk/Source/WebCore/Modules/modern-media-controls/media/media-controller.js 2017-06-06 16:29:20 UTC (rev 217836)
@@ -65,7 +65,7 @@
if (this.media instanceof HTMLAudioElement)
return true;
- if (!this.host.isInMediaDocument && this.media instanceof HTMLVideoElement)
+ if (this.host && !this.host.isInMediaDocument && this.media instanceof HTMLVideoElement)
return false;
if (this.media.readyState < HTMLMediaElement.HAVE_METADATA)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
