Title: [217897] trunk
- Revision
- 217897
- Author
- [email protected]
- Date
- 2017-06-07 12:13:46 -0700 (Wed, 07 Jun 2017)
Log Message
ARES-6 incorrectly measures Worst 4 Iterations
https://bugs.webkit.org/show_bug.cgi?id=172960
Reviewed by Mark Lam.
Version 1.0 of ARES-6 was accidentally measuring the first
4 iterations, instead of the worst 4. This patch fixes the
bug and bumps the version to 1.0.1.
* ARES-6/glue.js:
(driver.reportResult):
* ARES-6/results.js:
(Results.prototype.reportResult):
Modified Paths
Diff
Modified: trunk/PerformanceTests/ARES-6/glue.js (217896 => 217897)
--- trunk/PerformanceTests/ARES-6/glue.js 2017-06-07 19:12:47 UTC (rev 217896)
+++ trunk/PerformanceTests/ARES-6/glue.js 2017-06-07 19:13:46 UTC (rev 217897)
@@ -39,7 +39,7 @@
}
{
- const title = "ARES-6 1.0";
+ const title = "ARES-6 1.0.1";
if (isInBrowser) {
document.title = title;
} else {
Modified: trunk/PerformanceTests/ARES-6/results.js (217896 => 217897)
--- trunk/PerformanceTests/ARES-6/results.js 2017-06-07 19:12:47 UTC (rev 217896)
+++ trunk/PerformanceTests/ARES-6/results.js 2017-06-07 19:13:46 UTC (rev 217897)
@@ -59,7 +59,7 @@
this.firstIteration.add(times[0]);
let steadyTimes = times.slice(1).sort((a, b) => b - a); // Sort in reverse order.
- this.averageWorstCase.add((times[0] + times[1] + times[2] + times[3]) / 4);
+ this.averageWorstCase.add((steadyTimes[0] + steadyTimes[1] + steadyTimes[2] + steadyTimes[3]) / 4);
this.steadyState.add(steadyTimes.reduce((previous, current) => previous + current) / steadyTimes.length);
this.reportDone();
}
Modified: trunk/PerformanceTests/ChangeLog (217896 => 217897)
--- trunk/PerformanceTests/ChangeLog 2017-06-07 19:12:47 UTC (rev 217896)
+++ trunk/PerformanceTests/ChangeLog 2017-06-07 19:13:46 UTC (rev 217897)
@@ -1,3 +1,19 @@
+2017-06-07 Saam Barati <[email protected]>
+
+ ARES-6 incorrectly measures Worst 4 Iterations
+ https://bugs.webkit.org/show_bug.cgi?id=172960
+
+ Reviewed by Mark Lam.
+
+ Version 1.0 of ARES-6 was accidentally measuring the first
+ 4 iterations, instead of the worst 4. This patch fixes the
+ bug and bumps the version to 1.0.1.
+
+ * ARES-6/glue.js:
+ (driver.reportResult):
+ * ARES-6/results.js:
+ (Results.prototype.reportResult):
+
2017-06-06 Saam Barati <[email protected]>
Add a version number to ARES-6
Modified: trunk/Websites/browserbench.org/ARES-6/glue.js (217896 => 217897)
--- trunk/Websites/browserbench.org/ARES-6/glue.js 2017-06-07 19:12:47 UTC (rev 217896)
+++ trunk/Websites/browserbench.org/ARES-6/glue.js 2017-06-07 19:13:46 UTC (rev 217897)
@@ -39,7 +39,7 @@
}
{
- const title = "ARES-6 1.0";
+ const title = "ARES-6 1.0.1";
if (isInBrowser) {
document.title = title;
} else {
Modified: trunk/Websites/browserbench.org/ARES-6/results.js (217896 => 217897)
--- trunk/Websites/browserbench.org/ARES-6/results.js 2017-06-07 19:12:47 UTC (rev 217896)
+++ trunk/Websites/browserbench.org/ARES-6/results.js 2017-06-07 19:13:46 UTC (rev 217897)
@@ -59,7 +59,7 @@
this.firstIteration.add(times[0]);
let steadyTimes = times.slice(1).sort((a, b) => b - a); // Sort in reverse order.
- this.averageWorstCase.add((times[0] + times[1] + times[2] + times[3]) / 4);
+ this.averageWorstCase.add((steadyTimes[0] + steadyTimes[1] + steadyTimes[2] + steadyTimes[3]) / 4);
this.steadyState.add(steadyTimes.reduce((previous, current) => previous + current) / steadyTimes.length);
this.reportDone();
}
Modified: trunk/Websites/browserbench.org/ChangeLog (217896 => 217897)
--- trunk/Websites/browserbench.org/ChangeLog 2017-06-07 19:12:47 UTC (rev 217896)
+++ trunk/Websites/browserbench.org/ChangeLog 2017-06-07 19:13:46 UTC (rev 217897)
@@ -1,3 +1,19 @@
+2017-06-07 Saam Barati <[email protected]>
+
+ ARES-6 incorrectly measures Worst 4 Iterations
+ https://bugs.webkit.org/show_bug.cgi?id=172960
+
+ Reviewed by Mark Lam.
+
+ Version 1.0 of ARES-6 was accidentally measuring the first
+ 4 iterations, instead of the worst 4. This patch fixes the
+ bug and bumps the version to 1.0.1.
+
+ * ARES-6/glue.js:
+ (driver.reportResult):
+ * ARES-6/results.js:
+ (Results.prototype.reportResult):
+
2017-06-06 Saam Barati <[email protected]>
Add a version number to ARES-6
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
