Title: [217904] trunk/Source/WebCore
- Revision
- 217904
- Author
- [email protected]
- Date
- 2017-06-07 15:07:10 -0700 (Wed, 07 Jun 2017)
Log Message
Use a dedicated node flag to identify a Document node
https://bugs.webkit.org/show_bug.cgi?id=173037
Reviewed by Chris Dumez.
Address Antti's review comment. We don't need a new Node flg.
* dom/Node.h:
(WebCore::Node::isDocumentNode):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (217903 => 217904)
--- trunk/Source/WebCore/ChangeLog 2017-06-07 21:35:23 UTC (rev 217903)
+++ trunk/Source/WebCore/ChangeLog 2017-06-07 22:07:10 UTC (rev 217904)
@@ -1,3 +1,15 @@
+2017-06-07 Ryosuke Niwa <[email protected]>
+
+ Use a dedicated node flag to identify a Document node
+ https://bugs.webkit.org/show_bug.cgi?id=173037
+
+ Reviewed by Chris Dumez.
+
+ Address Antti's review comment. We don't need a new Node flg.
+
+ * dom/Node.h:
+ (WebCore::Node::isDocumentNode):
+
2017-06-07 Jon Davis <[email protected]>
Update feature status for features Supported In Preview
Modified: trunk/Source/WebCore/dom/Node.h (217903 => 217904)
--- trunk/Source/WebCore/dom/Node.h 2017-06-07 21:35:23 UTC (rev 217903)
+++ trunk/Source/WebCore/dom/Node.h 2017-06-07 22:07:10 UTC (rev 217904)
@@ -222,7 +222,7 @@
virtual bool isImageControlsButtonElement() const { return false; }
#endif
- bool isDocumentNode() const { return getFlag(IsDocumentNodeFlag); }
+ bool isDocumentNode() const { return getFlag(IsContainerFlag) && !getFlag(IsElementFlag) && !getFlag(IsDocumentFragmentFlag); }
bool isTreeScope() const;
bool isDocumentFragment() const { return getFlag(IsDocumentFragmentFlag); }
bool isShadowRoot() const { return isDocumentFragment() && isTreeScope(); }
@@ -573,7 +573,7 @@
IsStyledElementFlag = 1 << 3,
IsHTMLFlag = 1 << 4,
IsSVGFlag = 1 << 5,
- IsDocumentNodeFlag = 1 << 6,
+ // One free bit left.
ChildNeedsStyleRecalcFlag = 1 << 7,
IsConnectedFlag = 1 << 8,
IsLinkFlag = 1 << 9,
@@ -625,7 +625,7 @@
CreateStyledElement = CreateElement | IsStyledElementFlag,
CreateHTMLElement = CreateStyledElement | IsHTMLFlag,
CreateSVGElement = CreateStyledElement | IsSVGFlag | HasCustomStyleResolveCallbacksFlag,
- CreateDocument = CreateContainer | IsDocumentNodeFlag | IsConnectedFlag,
+ CreateDocument = CreateContainer | IsConnectedFlag,
CreateEditingText = CreateText | IsEditingTextOrUndefinedCustomElementFlag,
CreateMathMLElement = CreateStyledElement | IsMathMLFlag
};
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
