Title: [217909] trunk/JSTests
Revision
217909
Author
[email protected]
Date
2017-06-07 15:39:06 -0700 (Wed, 07 Jun 2017)

Log Message

Restrict the regress-173035.js test to only run on Darwin x86-64.
https://bugs.webkit.org/show_bug.cgi?id=173075

Reviewed by Saam Barati.

This is because the 32-bit x86 build will fail to mmap the 0x3f900000 bytes that
this test will require to succeed.  Here's an example of this failure:
https://build.webkit.org/builders/Apple%20Sierra%2032-bit%20JSC%20%28BuildAndTest%29/builds/866/steps/webkit-32bit-jsc-test/logs/stdio

Since the issue is due to allocation of a very large amount of memory, the test
will probably fail on iOS and other platforms as well.  Hence, we should just
skip this test for any platforms that is not Darwin x86-64.

* stress/regress-173035.js:

Modified Paths

Diff

Modified: trunk/JSTests/ChangeLog (217908 => 217909)


--- trunk/JSTests/ChangeLog	2017-06-07 22:26:48 UTC (rev 217908)
+++ trunk/JSTests/ChangeLog	2017-06-07 22:39:06 UTC (rev 217909)
@@ -1,5 +1,22 @@
 2017-06-07  Mark Lam  <[email protected]>
 
+        Restrict the regress-173035.js test to only run on Darwin x86-64.
+        https://bugs.webkit.org/show_bug.cgi?id=173075
+
+        Reviewed by Saam Barati.
+
+        This is because the 32-bit x86 build will fail to mmap the 0x3f900000 bytes that
+        this test will require to succeed.  Here's an example of this failure:
+        https://build.webkit.org/builders/Apple%20Sierra%2032-bit%20JSC%20%28BuildAndTest%29/builds/866/steps/webkit-32bit-jsc-test/logs/stdio
+
+        Since the issue is due to allocation of a very large amount of memory, the test
+        will probably fail on iOS and other platforms as well.  Hence, we should just
+        skip this test for any platforms that is not Darwin x86-64.
+
+        * stress/regress-173035.js:
+
+2017-06-07  Mark Lam  <[email protected]>
+
         ASSERTION failure: !masqueradesAsUndefinedWatchpointIsStillValid() || !isKnownCell(operand.node())
         https://bugs.webkit.org/show_bug.cgi?id=168587
 

Modified: trunk/JSTests/stress/regress-173035.js (217908 => 217909)


--- trunk/JSTests/stress/regress-173035.js	2017-06-07 22:26:48 UTC (rev 217908)
+++ trunk/JSTests/stress/regress-173035.js	2017-06-07 22:39:06 UTC (rev 217909)
@@ -1,3 +1,5 @@
+//@ skip if ($hostOS != "" || $architecture != "x86-64")
+
 var a = [];
 for (var i=0; i<0x04001000; i++) a.push(i+0.1);
 a.length = 0x20000000;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to