Title: [217934] trunk/Source/WebKit2
- Revision
- 217934
- Author
- [email protected]
- Date
- 2017-06-08 10:26:27 -0700 (Thu, 08 Jun 2017)
Log Message
[WK2] mediaContentTypesRequiringHardwareSupport setting not being propogated
https://bugs.webkit.org/show_bug.cgi?id=173090
Reviewed by Eric Carlson.
Passing a NSString* into the WebPreferencesStore::Value constructor would rather cast the NSString*
into a bool than a const String&. So explicitly cast the NSString* into a String before passing.
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (217933 => 217934)
--- trunk/Source/WebKit2/ChangeLog 2017-06-08 17:23:53 UTC (rev 217933)
+++ trunk/Source/WebKit2/ChangeLog 2017-06-08 17:26:27 UTC (rev 217934)
@@ -1,3 +1,16 @@
+2017-06-08 Jer Noble <[email protected]>
+
+ [WK2] mediaContentTypesRequiringHardwareSupport setting not being propogated
+ https://bugs.webkit.org/show_bug.cgi?id=173090
+
+ Reviewed by Eric Carlson.
+
+ Passing a NSString* into the WebPreferencesStore::Value constructor would rather cast the NSString*
+ into a bool than a const String&. So explicitly cast the NSString* into a String before passing.
+
+ * UIProcess/API/Cocoa/WKWebView.mm:
+ (-[WKWebView _initializeWithConfiguration:]):
+
2017-06-08 Youenn Fablet <[email protected]>
getUserMedia request should not be allowed for background tabs unless the tab is already capturing
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm (217933 => 217934)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2017-06-08 17:23:53 UTC (rev 217933)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2017-06-08 17:26:27 UTC (rev 217934)
@@ -503,9 +503,8 @@
#endif
pageConfiguration->preferenceValues().set(WebKit::WebPreferencesKey::needsStorageAccessFromFileURLsQuirkKey(), WebKit::WebPreferencesStore::Value(!![_configuration _needsStorageAccessFromFileURLsQuirk]));
+ pageConfiguration->preferenceValues().set(WebKit::WebPreferencesKey::mediaContentTypesRequiringHardwareSupportKey(), WebKit::WebPreferencesStore::Value(String([_configuration _mediaContentTypesRequiringHardwareSupport])));
- pageConfiguration->preferenceValues().set(WebKit::WebPreferencesKey::mediaContentTypesRequiringHardwareSupportKey(), WebKit::WebPreferencesStore::Value([_configuration _mediaContentTypesRequiringHardwareSupport]));
-
#if PLATFORM(IOS)
CGRect bounds = self.bounds;
_scrollView = adoptNS([[WKScrollView alloc] initWithFrame:bounds]);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
