Title: [217988] trunk/Source/WebKit
- Revision
- 217988
- Author
- [email protected]
- Date
- 2017-06-09 09:19:06 -0700 (Fri, 09 Jun 2017)
Log Message
[Win64] Build error when compiling PaintHooks.asm.
https://bugs.webkit.org/show_bug.cgi?id=173132
Reviewed by Brent Fulgham.
There seems to be too many include paths on the command line for ml64. According to the documentation,
a maximum of 10 /I options is allowed. Create a separate static library for asm files, in order to
avoid all the include paths.
* PlatformWin.cmake:
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (217987 => 217988)
--- trunk/Source/WebKit/ChangeLog 2017-06-09 16:18:59 UTC (rev 217987)
+++ trunk/Source/WebKit/ChangeLog 2017-06-09 16:19:06 UTC (rev 217988)
@@ -1,3 +1,16 @@
+2017-06-09 Per Arne Vollan <[email protected]>
+
+ [Win64] Build error when compiling PaintHooks.asm.
+ https://bugs.webkit.org/show_bug.cgi?id=173132
+
+ Reviewed by Brent Fulgham.
+
+ There seems to be too many include paths on the command line for ml64. According to the documentation,
+ a maximum of 10 /I options is allowed. Create a separate static library for asm files, in order to
+ avoid all the include paths.
+
+ * PlatformWin.cmake:
+
2017-06-06 Yoav Weiss <[email protected]>
[preload] Conditional support for media preloading and align media `as` values.
Modified: trunk/Source/WebKit/PlatformWin.cmake (217987 => 217988)
--- trunk/Source/WebKit/PlatformWin.cmake 2017-06-09 16:18:59 UTC (rev 217987)
+++ trunk/Source/WebKit/PlatformWin.cmake 2017-06-09 16:19:06 UTC (rev 217988)
@@ -255,9 +255,12 @@
if (CMAKE_SIZEOF_VOID_P EQUAL 8)
enable_language(ASM_MASM)
- list(APPEND WebKit_SOURCES
- win/plugins/PaintHooks.asm
+ add_library(Asm STATIC
+ "win/plugins/PaintHooks.asm"
)
+ list(APPEND WebKit_LIBRARIES
+ PRIVATE Asm
+ )
endif ()
list(APPEND WebKit_SOURCES ${WebKit_INCLUDES} ${WebKit_SOURCES_Classes} ${WebKit_SOURCES_WebCoreSupport})
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
