Title: [99711] trunk/Source/WebCore
- Revision
- 99711
- Author
- [email protected]
- Date
- 2011-11-09 07:10:09 -0800 (Wed, 09 Nov 2011)
Log Message
CSSPrimitiveValue: Fix up bitfield member types.
<http://webkit.org/b/71751>
Reviewed by Antti Koivisto.
The primitive unit type doesn't need to be a signed value,
and by making it unsigned, we can shave one bit off of it.
Furthermore, m_hasCachedCSSText and m_isQuirkValue should be
bool, not unsigned.
* css/CSSValue.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (99710 => 99711)
--- trunk/Source/WebCore/ChangeLog 2011-11-09 15:09:05 UTC (rev 99710)
+++ trunk/Source/WebCore/ChangeLog 2011-11-09 15:10:09 UTC (rev 99711)
@@ -1,3 +1,17 @@
+2011-11-09 Andreas Kling <[email protected]>
+
+ CSSPrimitiveValue: Fix up bitfield member types.
+ <http://webkit.org/b/71751>
+
+ Reviewed by Antti Koivisto.
+
+ The primitive unit type doesn't need to be a signed value,
+ and by making it unsigned, we can shave one bit off of it.
+ Furthermore, m_hasCachedCSSText and m_isQuirkValue should be
+ bool, not unsigned.
+
+ * css/CSSValue.h:
+
2011-11-09 Pavel Feldman <[email protected]>
Web Inspector: discard injected scripts upon front-end disconnect.
Modified: trunk/Source/WebCore/css/CSSValue.h (99710 => 99711)
--- trunk/Source/WebCore/css/CSSValue.h 2011-11-09 15:09:05 UTC (rev 99710)
+++ trunk/Source/WebCore/css/CSSValue.h 2011-11-09 15:10:09 UTC (rev 99711)
@@ -201,9 +201,9 @@
protected:
// These bits are only used by CSSPrimitiveValue but kept here
// to maximize struct packing.
- signed m_primitiveUnitType : 8; // CSSPrimitiveValue::UnitTypes
- mutable unsigned m_hasCachedCSSText : 1;
- unsigned m_isQuirkValue : 1;
+ unsigned m_primitiveUnitType : 7; // CSSPrimitiveValue::UnitTypes
+ mutable bool m_hasCachedCSSText : 1;
+ bool m_isQuirkValue : 1;
private:
unsigned m_classType : 5; // ClassType
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
