Title: [218023] trunk/Source/WebKit2
- Revision
- 218023
- Author
- [email protected]
- Date
- 2017-06-09 15:35:01 -0700 (Fri, 09 Jun 2017)
Log Message
REGRESSION (r213584): WeChat app can not switch to next text field
https://bugs.webkit.org/show_bug.cgi?id=173183
<rdar://problem/32323478>
Reviewed by Wenson Hsieh.
* Platform/spi/ios/UIKitSPI.h:
* UIProcess/ios/InputViewUpdateDeferrer.mm:
(WebKit::InputViewUpdateDeferrer::~InputViewUpdateDeferrer):
It turns out that _endIgnoringReloadInputViews doesn't actually perform
the update if there was one ignored. It does, however, return whether
there was a change ignored, and we can force an update.
This remains untestable without sizable additional API test infrastructure
for the same reasons as the original patch.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (218022 => 218023)
--- trunk/Source/WebKit2/ChangeLog 2017-06-09 22:16:55 UTC (rev 218022)
+++ trunk/Source/WebKit2/ChangeLog 2017-06-09 22:35:01 UTC (rev 218023)
@@ -1,3 +1,21 @@
+2017-06-09 Tim Horton <[email protected]>
+
+ REGRESSION (r213584): WeChat app can not switch to next text field
+ https://bugs.webkit.org/show_bug.cgi?id=173183
+ <rdar://problem/32323478>
+
+ Reviewed by Wenson Hsieh.
+
+ * Platform/spi/ios/UIKitSPI.h:
+ * UIProcess/ios/InputViewUpdateDeferrer.mm:
+ (WebKit::InputViewUpdateDeferrer::~InputViewUpdateDeferrer):
+ It turns out that _endIgnoringReloadInputViews doesn't actually perform
+ the update if there was one ignored. It does, however, return whether
+ there was a change ignored, and we can force an update.
+
+ This remains untestable without sizable additional API test infrastructure
+ for the same reasons as the original patch.
+
2017-06-09 Chris Dumez <[email protected]>
Make sure we protect |this| in lambdas in WebResourceLoadStatisticsStore::registerSharedResourceLoadObserver()
Modified: trunk/Source/WebKit2/Platform/spi/ios/UIKitSPI.h (218022 => 218023)
--- trunk/Source/WebKit2/Platform/spi/ios/UIKitSPI.h 2017-06-09 22:16:55 UTC (rev 218022)
+++ trunk/Source/WebKit2/Platform/spi/ios/UIKitSPI.h 2017-06-09 22:35:01 UTC (rev 218023)
@@ -885,7 +885,8 @@
@interface UIPeripheralHost (IPI)
- (void)_beginIgnoringReloadInputViews;
-- (void)_endIgnoringReloadInputViews;
+- (int)_endIgnoringReloadInputViews;
+- (void)forceReloadInputViews;
@end
@interface UIResponder ()
Modified: trunk/Source/WebKit2/UIProcess/ios/InputViewUpdateDeferrer.mm (218022 => 218023)
--- trunk/Source/WebKit2/UIProcess/ios/InputViewUpdateDeferrer.mm 2017-06-09 22:16:55 UTC (rev 218022)
+++ trunk/Source/WebKit2/UIProcess/ios/InputViewUpdateDeferrer.mm 2017-06-09 22:35:01 UTC (rev 218023)
@@ -41,7 +41,8 @@
InputViewUpdateDeferrer::~InputViewUpdateDeferrer()
{
- [[UIPeripheralHost sharedInstance] _endIgnoringReloadInputViews];
+ if ([[UIPeripheralHost sharedInstance] _endIgnoringReloadInputViews])
+ [[UIPeripheralHost sharedInstance] forceReloadInputViews];
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
