Title: [218025] trunk/LayoutTests
Revision
218025
Author
[email protected]
Date
2017-06-09 15:45:00 -0700 (Fri, 09 Jun 2017)

Log Message

REGRESSION: LayoutTest js/intl-datetimeformat.html is failing
https://bugs.webkit.org/show_bug.cgi?id=172720

Patch by Andy VanWagoner <[email protected]> on 2017-06-09
Reviewed by Darin Adler.

Reenable DateTimeFormat tests, allowing for some variation in the
formatting of time zone names.

* js/intl-datetimeformat-expected.txt:
* js/script-tests/intl-datetimeformat.js:
* platform/mac/TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (218024 => 218025)


--- trunk/LayoutTests/ChangeLog	2017-06-09 22:38:40 UTC (rev 218024)
+++ trunk/LayoutTests/ChangeLog	2017-06-09 22:45:00 UTC (rev 218025)
@@ -1,3 +1,17 @@
+2017-06-09  Andy VanWagoner  <[email protected]>
+
+        REGRESSION: LayoutTest js/intl-datetimeformat.html is failing
+        https://bugs.webkit.org/show_bug.cgi?id=172720
+
+        Reviewed by Darin Adler.
+
+        Reenable DateTimeFormat tests, allowing for some variation in the
+        formatting of time zone names.
+
+        * js/intl-datetimeformat-expected.txt:
+        * js/script-tests/intl-datetimeformat.js:
+        * platform/mac/TestExpectations:
+
 2017-06-09  Joseph Pecoraro  <[email protected]>
 
         Web Inspector: Web inspector does not show non-shadow children of an element with a shadow root (e.g. <video>)

Modified: trunk/LayoutTests/js/intl-datetimeformat-expected.txt (218024 => 218025)


--- trunk/LayoutTests/js/intl-datetimeformat-expected.txt	2017-06-09 22:38:40 UTC (rev 218024)
+++ trunk/LayoutTests/js/intl-datetimeformat-expected.txt	2017-06-09 22:45:00 UTC (rev 218025)
@@ -377,7 +377,7 @@
 PASS Intl.DateTimeFormat('en', { minute:'2-digit', hour:'numeric', timeZoneName:'short' }).resolvedOptions().timeZoneName is 'short'
 PASS Intl.DateTimeFormat('en', { minute:'2-digit', hour:'numeric', timeZoneName:'short', timeZone: 'UTC' }).format(0) is '12:00 AM GMT'
 PASS Intl.DateTimeFormat('pt-BR', { minute:'2-digit', hour:'numeric', timeZoneName:'long' }).resolvedOptions().timeZoneName is 'long'
-PASS Intl.DateTimeFormat('pt-BR', { minute:'2-digit', hour:'numeric', timeZoneName:'long', timeZone: 'UTC' }).format(0) is '00:00 GMT'
+PASS ['00:00 GMT','00:00 HorĂ¡rio do Meridiano de Greenwich'].includes(Intl.DateTimeFormat('pt-BR', { minute:'2-digit', hour:'numeric', timeZoneName:'long', timeZone: 'UTC' }).format(0)) is true
 PASS 
     var options = { weekday: "short", year: "numeric", month: "short", day: "numeric", hour: "numeric", minute: "numeric", second: "numeric" };
     var resolved = Intl.DateTimeFormat("ar", options).resolvedOptions();
@@ -2555,7 +2555,7 @@
   Intl.DateTimeFormat('en-US', {
     hour: "numeric", minute: "numeric", second: "numeric",
     year: "numeric", month: "long", day: "numeric", weekday: "long",
-    timeZoneName: "long", era: "long", timeZone: "UTC"
+    timeZoneName: "short", era: "long", timeZone: "UTC"
   }).formatToParts(0)
 ) is JSON.stringify([
   {"type":"weekday","value":"Thursday"},

Modified: trunk/LayoutTests/js/script-tests/intl-datetimeformat.js (218024 => 218025)


--- trunk/LayoutTests/js/script-tests/intl-datetimeformat.js	2017-06-09 22:38:40 UTC (rev 218024)
+++ trunk/LayoutTests/js/script-tests/intl-datetimeformat.js	2017-06-09 22:45:00 UTC (rev 218025)
@@ -1,4 +1,4 @@
-//@ skip
+//@ skip if $hostOS == "windows"
 description("This test checks the behavior of Intl.DateTimeFormat as described in the ECMAScript Internationalization API Specification (ECMA-402 2.0).");
 
 // 12.1 The Intl.DateTimeFormat Constructor
@@ -461,7 +461,7 @@
 shouldBe("Intl.DateTimeFormat('en', { minute:'2-digit', hour:'numeric', timeZoneName:'short' }).resolvedOptions().timeZoneName", "'short'");
 shouldBe("Intl.DateTimeFormat('en', { minute:'2-digit', hour:'numeric', timeZoneName:'short', timeZone: 'UTC' }).format(0)", "'12:00 AM GMT'");
 shouldBe("Intl.DateTimeFormat('pt-BR', { minute:'2-digit', hour:'numeric', timeZoneName:'long' }).resolvedOptions().timeZoneName", "'long'");
-shouldBe("Intl.DateTimeFormat('pt-BR', { minute:'2-digit', hour:'numeric', timeZoneName:'long', timeZone: 'UTC' }).format(0)", "'00:00 GMT'")
+shouldBeTrue("['00:00 GMT','00:00 HorĂ¡rio do Meridiano de Greenwich'].includes(Intl.DateTimeFormat('pt-BR', { minute:'2-digit', hour:'numeric', timeZoneName:'long', timeZone: 'UTC' }).format(0))");
 
 let localesSample = [
   "ar", "ar-SA", "be", "ca", "cs", "da", "de", "de-CH", "en", "en-AU", "en-GB",
@@ -578,7 +578,7 @@
   Intl.DateTimeFormat('en-US', {
     hour: "numeric", minute: "numeric", second: "numeric",
     year: "numeric", month: "long", day: "numeric", weekday: "long",
-    timeZoneName: "long", era: "long", timeZone: "UTC"
+    timeZoneName: "short", era: "long", timeZone: "UTC"
   }).formatToParts(0)
 )`, `JSON.stringify([
   {"type":"weekday","value":"Thursday"},

Modified: trunk/LayoutTests/platform/mac/TestExpectations (218024 => 218025)


--- trunk/LayoutTests/platform/mac/TestExpectations	2017-06-09 22:38:40 UTC (rev 218024)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2017-06-09 22:45:00 UTC (rev 218025)
@@ -1542,8 +1542,6 @@
 
 webkit.org/b/172469 [ ElCapitan ] imported/w3c/web-platform-tests/WebCryptoAPI/import_export/test_rsa_importKey.https.html [ Timeout ]
 
-webkit.org/b/172720 [ Sierra+ ] js/intl-datetimeformat.html [ Failure ]
-
 # This test tests a feature that only exists on iOS.
 webkit.org/b/172737 fast/text/accessibility-bold-system-font-2.html [ ImageOnlyFailure ]
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to