Title: [99714] trunk/Source/WebKit/chromium
- Revision
- 99714
- Author
- [email protected]
- Date
- 2011-11-09 07:30:38 -0800 (Wed, 09 Nov 2011)
Log Message
Chromium: Add plumbing to enable dragging dev tools via the empty space on the toolbar.
https://bugs.webkit.org/show_bug.cgi?id=71842
These are the only WebKit-side changes needed. The rest will be done on the Chromium side.
Chromium bug: http://crbug.com/44350
Patch by Alexei Svitkine <[email protected]> on 2011-11-09
Reviewed by Pavel Feldman.
* public/WebDevToolsFrontendClient.h:
(WebKit::WebDevToolsFrontendClient::moveWindowBy):
* src/InspectorFrontendClientImpl.cpp:
(WebKit::InspectorFrontendClientImpl::moveWindowBy):
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (99713 => 99714)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-11-09 15:27:33 UTC (rev 99713)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-11-09 15:30:38 UTC (rev 99714)
@@ -1,3 +1,19 @@
+2011-11-09 Alexei Svitkine <[email protected]>
+
+ Chromium: Add plumbing to enable dragging dev tools via the empty space on the toolbar.
+ https://bugs.webkit.org/show_bug.cgi?id=71842
+
+ These are the only WebKit-side changes needed. The rest will be done on the Chromium side.
+
+ Chromium bug: http://crbug.com/44350
+
+ Reviewed by Pavel Feldman.
+
+ * public/WebDevToolsFrontendClient.h:
+ (WebKit::WebDevToolsFrontendClient::moveWindowBy):
+ * src/InspectorFrontendClientImpl.cpp:
+ (WebKit::InspectorFrontendClientImpl::moveWindowBy):
+
2011-11-08 Jay Civelli <[email protected]>
Fixes and reenables the WebPageSerializer tests.
Modified: trunk/Source/WebKit/chromium/public/WebDevToolsFrontendClient.h (99713 => 99714)
--- trunk/Source/WebKit/chromium/public/WebDevToolsFrontendClient.h 2011-11-09 15:27:33 UTC (rev 99713)
+++ trunk/Source/WebKit/chromium/public/WebDevToolsFrontendClient.h 2011-11-09 15:30:38 UTC (rev 99714)
@@ -34,6 +34,7 @@
namespace WebKit {
class WebString;
+struct WebFloatPoint;
struct WebDevToolsMessageData;
class WebDevToolsFrontendClient {
@@ -49,6 +50,7 @@
virtual void closeWindow() { }
virtual void requestDockWindow() { }
virtual void requestUndockWindow() { }
+ virtual void moveWindowBy(const WebFloatPoint&) { }
virtual void saveAs(const WebString& fileName, const WebString& content) { }
virtual bool shouldHideScriptsPanel() { return false; }
Modified: trunk/Source/WebKit/chromium/src/InspectorFrontendClientImpl.cpp (99713 => 99714)
--- trunk/Source/WebKit/chromium/src/InspectorFrontendClientImpl.cpp 2011-11-09 15:27:33 UTC (rev 99713)
+++ trunk/Source/WebKit/chromium/src/InspectorFrontendClientImpl.cpp 2011-11-09 15:30:38 UTC (rev 99714)
@@ -40,6 +40,7 @@
#include "V8Proxy.h"
#include "WebDevToolsFrontendClient.h"
#include "WebDevToolsFrontendImpl.h"
+#include "WebFloatPoint.h"
#include "WebString.h"
using namespace WebCore;
@@ -81,6 +82,7 @@
void InspectorFrontendClientImpl::moveWindowBy(float x, float y)
{
+ m_client->moveWindowBy(WebFloatPoint(x, y));
}
String InspectorFrontendClientImpl::localizedStringsURL()
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
