Title: [218044] trunk/Source/WebCore
- Revision
- 218044
- Author
- [email protected]
- Date
- 2017-06-09 22:08:59 -0700 (Fri, 09 Jun 2017)
Log Message
IsInShadowTreeFlag does not get updated for a non-container node
https://bugs.webkit.org/show_bug.cgi?id=173084
Address Darin's review comment.
* dom/ContainerNodeAlgorithms.cpp:
(WebCore::notifyNodeInsertedIntoDocument):
(WebCore::notifyNodeInsertedIntoTree):
(WebCore::notifyNodeRemovedFromDocument):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (218043 => 218044)
--- trunk/Source/WebCore/ChangeLog 2017-06-10 04:38:54 UTC (rev 218043)
+++ trunk/Source/WebCore/ChangeLog 2017-06-10 05:08:59 UTC (rev 218044)
@@ -1,3 +1,15 @@
+2017-06-09 Ryosuke Niwa <[email protected]>
+
+ IsInShadowTreeFlag does not get updated for a non-container node
+ https://bugs.webkit.org/show_bug.cgi?id=173084
+
+ Address Darin's review comment.
+
+ * dom/ContainerNodeAlgorithms.cpp:
+ (WebCore::notifyNodeInsertedIntoDocument):
+ (WebCore::notifyNodeInsertedIntoTree):
+ (WebCore::notifyNodeRemovedFromDocument):
+
2017-06-09 Dan Bernstein <[email protected]>
Fixed building with the macOS 10.13 Apple Internal SDK when targeting macOS 10.12.
Modified: trunk/Source/WebCore/dom/ContainerNodeAlgorithms.cpp (218043 => 218044)
--- trunk/Source/WebCore/dom/ContainerNodeAlgorithms.cpp 2017-06-10 04:38:54 UTC (rev 218043)
+++ trunk/Source/WebCore/dom/ContainerNodeAlgorithms.cpp 2017-06-10 05:08:59 UTC (rev 218044)
@@ -43,7 +43,7 @@
if (!is<ContainerNode>(node))
return;
- ChildNodesLazySnapshot snapshot(node);
+ ChildNodesLazySnapshot snapshot(downcast<ContainerNode>(node));
while (RefPtr<Node> child = snapshot.nextNode()) {
// If we have been removed from the document during this loop, then
// we don't want to tell the rest of our children that they've been
@@ -72,7 +72,7 @@
if (!is<ContainerNode>(node))
return;
- for (auto* child = node.firstChild(); child; child = child->nextSibling())
+ for (auto* child = downcast<ContainerNode>(node).firstChild(); child; child = child->nextSibling())
notifyNodeInsertedIntoTree(insertionPoint, *child, postInsertionNotificationTargets);
if (!is<Element>(node))
@@ -105,7 +105,7 @@
if (!is<ContainerNode>(node))
return;
- ChildNodesLazySnapshot snapshot(node);
+ ChildNodesLazySnapshot snapshot(downcast<ContainerNode>(node));
while (RefPtr<Node> child = snapshot.nextNode()) {
// If we have been added to the document during this loop, then we
// don't want to tell the rest of our children that they've been
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
