Title: [218174] trunk/Source/WebKit2
- Revision
- 218174
- Author
- carlo...@webkit.org
- Date
- 2017-06-13 05:00:43 -0700 (Tue, 13 Jun 2017)
Log Message
Unreviewed. Fix return value of PageLoaderClient::shouldGoToBackForwardListItem after r218164.
It should return true as InjectedBundlePageLoaderClient does. This caused several timeouts in GTK+ unit tests
after r218171.
* WebProcess/InjectedBundle/API/APIInjectedBundlePageLoaderClient.h:
(API::InjectedBundle::PageLoaderClient::shouldGoToBackForwardListItem):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (218173 => 218174)
--- trunk/Source/WebKit2/ChangeLog 2017-06-13 10:34:55 UTC (rev 218173)
+++ trunk/Source/WebKit2/ChangeLog 2017-06-13 12:00:43 UTC (rev 218174)
@@ -1,5 +1,15 @@
2017-06-13 Carlos Garcia Campos <cgar...@igalia.com>
+ Unreviewed. Fix return value of PageLoaderClient::shouldGoToBackForwardListItem after r218164.
+
+ It should return true as InjectedBundlePageLoaderClient does. This caused several timeouts in GTK+ unit tests
+ after r218171.
+
+ * WebProcess/InjectedBundle/API/APIInjectedBundlePageLoaderClient.h:
+ (API::InjectedBundle::PageLoaderClient::shouldGoToBackForwardListItem):
+
+2017-06-13 Carlos Garcia Campos <cgar...@igalia.com>
+
[GTK] Use API::GeolocationProvider in WebKitGeolocationProvider
https://bugs.webkit.org/show_bug.cgi?id=173151
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/APIInjectedBundlePageLoaderClient.h (218173 => 218174)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/APIInjectedBundlePageLoaderClient.h 2017-06-13 10:34:55 UTC (rev 218173)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/APIInjectedBundlePageLoaderClient.h 2017-06-13 12:00:43 UTC (rev 218174)
@@ -58,7 +58,7 @@
virtual void willLoadURLRequest(WebKit::WebPage&, const WebCore::ResourceRequest&, API::Object*) { }
virtual void willLoadDataRequest(WebKit::WebPage&, const WebCore::ResourceRequest&, WebCore::SharedBuffer*, const WTF::String&, const WTF::String&, const WebCore::URL&, API::Object*) { }
- virtual bool shouldGoToBackForwardListItem(WebKit::WebPage&, WebKit::InjectedBundleBackForwardListItem&, RefPtr<API::Object>&) { return false; }
+ virtual bool shouldGoToBackForwardListItem(WebKit::WebPage&, WebKit::InjectedBundleBackForwardListItem&, RefPtr<API::Object>&) { return true; }
virtual void didStartProvisionalLoadForFrame(WebKit::WebPage&, WebKit::WebFrame&, RefPtr<API::Object>&) { }
virtual void didReceiveServerRedirectForProvisionalLoadForFrame(WebKit::WebPage&, WebKit::WebFrame&, RefPtr<API::Object>&) { }
virtual void didFailProvisionalLoadWithErrorForFrame(WebKit::WebPage&, WebKit::WebFrame&, const WebCore::ResourceError&, RefPtr<API::Object>&) { }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
