Title: [218239] trunk/LayoutTests
Revision
218239
Author
grao...@webkit.org
Date
2017-06-13 18:30:11 -0700 (Tue, 13 Jun 2017)

Log Message

Rebaseline media/modern-media-controls/tracks-button
https://bugs.webkit.org/show_bug.cgi?id=173220

Reviewed by Dean Jackson.

Use SVG assets.

* media/modern-media-controls/tracks-button/tracks-button-expected.txt:
* media/modern-media-controls/tracks-button/tracks-button.html:
* platform/ios-simulator/TestExpectations:
* platform/mac/TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (218238 => 218239)


--- trunk/LayoutTests/ChangeLog	2017-06-14 01:23:55 UTC (rev 218238)
+++ trunk/LayoutTests/ChangeLog	2017-06-14 01:30:11 UTC (rev 218239)
@@ -1,5 +1,19 @@
 2017-06-13  Antoine Quint  <grao...@apple.com>
 
+        Rebaseline media/modern-media-controls/tracks-button
+        https://bugs.webkit.org/show_bug.cgi?id=173220
+
+        Reviewed by Dean Jackson.
+
+        Use SVG assets.
+
+        * media/modern-media-controls/tracks-button/tracks-button-expected.txt:
+        * media/modern-media-controls/tracks-button/tracks-button.html:
+        * platform/ios-simulator/TestExpectations:
+        * platform/mac/TestExpectations:
+
+2017-06-13  Antoine Quint  <grao...@apple.com>
+
         Rebaseline media/modern-media-controls/time-control
         https://bugs.webkit.org/show_bug.cgi?id=173218
 

Modified: trunk/LayoutTests/media/modern-media-controls/tracks-button/tracks-button-expected.txt (218238 => 218239)


--- trunk/LayoutTests/media/modern-media-controls/tracks-button/tracks-button-expected.txt	2017-06-14 01:23:55 UTC (rev 218238)
+++ trunk/LayoutTests/media/modern-media-controls/tracks-button/tracks-button-expected.txt	2017-06-14 01:30:11 UTC (rev 218239)
@@ -4,11 +4,10 @@
 
 
 PASS tracksButton.element.localName is "button"
-PASS tracksButton.element.classList.contains("icon") is true
 PASS tracksButton.element.classList.contains("tracks") is true
 PASS tracksButton.iconName is Icons.Tracks
-PASS tracksButton.element.style.webkitMaskImage.includes("macOS/media-selection@") became true
-PASS fullscreenTracksButton.element.style.webkitMaskImage.includes("macOS/media-selection-fullscreen@") became true
+PASS tracksButton.image.element.style.webkitMaskImage.includes("macOS/MediaSelector.svg") became true
+PASS fullscreenTracksButton.image.element.style.webkitMaskImage.includes("macOS/MediaSelector-fullscreen.svg") became true
 PASS successfullyParsed is true
 
 TEST COMPLETE

Modified: trunk/LayoutTests/media/modern-media-controls/tracks-button/tracks-button.html (218238 => 218239)


--- trunk/LayoutTests/media/modern-media-controls/tracks-button/tracks-button.html	2017-06-14 01:23:55 UTC (rev 218238)
+++ trunk/LayoutTests/media/modern-media-controls/tracks-button/tracks-button.html	2017-06-14 01:30:11 UTC (rev 218239)
@@ -11,14 +11,13 @@
 const tracksButton = new TracksButton({ layoutTraits: LayoutTraits.macOS });
 
 shouldBeEqualToString("tracksButton.element.localName", "button");
-shouldBeTrue('tracksButton.element.classList.contains("icon")');
 shouldBeTrue('tracksButton.element.classList.contains("tracks")');
 shouldBe("tracksButton.iconName", "Icons.Tracks");
 
 const fullscreenTracksButton = new TracksButton({ layoutTraits: LayoutTraits.macOS | LayoutTraits.Fullscreen });
 
-shouldBecomeEqual('tracksButton.element.style.webkitMaskImage.includes("macOS/media-selection@")', "true", () => {
-    shouldBecomeEqual('fullscreenTracksButton.element.style.webkitMaskImage.includes("macOS/media-selection-fullscreen@")', "true", finishJSTest);
+shouldBecomeEqual('tracksButton.image.element.style.webkitMaskImage.includes("macOS/MediaSelector.svg")', "true", () => {
+    shouldBecomeEqual('fullscreenTracksButton.image.element.style.webkitMaskImage.includes("macOS/MediaSelector-fullscreen.svg")', "true", finishJSTest);
 });
 
 </script>

Modified: trunk/LayoutTests/platform/ios-simulator/TestExpectations (218238 => 218239)


--- trunk/LayoutTests/platform/ios-simulator/TestExpectations	2017-06-14 01:23:55 UTC (rev 218238)
+++ trunk/LayoutTests/platform/ios-simulator/TestExpectations	2017-06-14 01:30:11 UTC (rev 218239)
@@ -94,6 +94,7 @@
 media/modern-media-controls/status-label [ Pass ]
 media/modern-media-controls/time-control [ Pass ]
 media/modern-media-controls/time-label [ Pass ]
+media/modern-media-controls/tracks-button [ Pass ]
 
 # AirPlay cannot be tested on iOS
 webkit.org/b/166062 media/modern-media-controls/airplay-support [ Skip ]

Modified: trunk/LayoutTests/platform/mac/TestExpectations (218238 => 218239)


--- trunk/LayoutTests/platform/mac/TestExpectations	2017-06-14 01:23:55 UTC (rev 218238)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2017-06-14 01:30:11 UTC (rev 218239)
@@ -1576,6 +1576,7 @@
 media/modern-media-controls/status-label [ Pass ]
 media/modern-media-controls/time-control [ Pass ]
 media/modern-media-controls/time-label [ Pass ]
+media/modern-media-controls/tracks-button [ Pass ]
 media/modern-media-controls/volume-up-support [ Pass ]
 
 # These tests are iOS-specific
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to