Title: [218255] trunk/Tools
Revision
218255
Author
[email protected]
Date
2017-06-14 07:56:43 -0700 (Wed, 14 Jun 2017)

Log Message

[Win] DRT should not use disk cache.
https://bugs.webkit.org/show_bug.cgi?id=173361

Reviewed by Darin Adler.

Like on macOS/iOS, DRT on Windows should only use memory cache.

* DumpRenderTree/win/DumpRenderTree.cpp:
(setDefaultsToConsistentValuesForTesting):
(prepareConsistentTestingEnvironment):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (218254 => 218255)


--- trunk/Tools/ChangeLog	2017-06-14 12:58:00 UTC (rev 218254)
+++ trunk/Tools/ChangeLog	2017-06-14 14:56:43 UTC (rev 218255)
@@ -1,3 +1,16 @@
+2017-06-14  Per Arne Vollan  <[email protected]>
+
+        [Win] DRT should not use disk cache.
+        https://bugs.webkit.org/show_bug.cgi?id=173361
+
+        Reviewed by Darin Adler.
+
+        Like on macOS/iOS, DRT on Windows should only use memory cache.
+
+        * DumpRenderTree/win/DumpRenderTree.cpp:
+        (setDefaultsToConsistentValuesForTesting):
+        (prepareConsistentTestingEnvironment):
+
 2017-06-14  Nael Ouedraogo  <[email protected]>
 
         MediaSource duration attribute should not be equal to Infinity when set to a value greater than 2^64

Modified: trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp (218254 => 218255)


--- trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp	2017-06-14 12:58:00 UTC (rev 218254)
+++ trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp	2017-06-14 14:56:43 UTC (rev 218255)
@@ -930,9 +930,6 @@
     CFPreferencesSetAppValue(WebDatabaseDirectoryDefaultsKey, WebCore::pathByAppendingComponent(libraryPath, "Databases").createCFString().get(), appId.get());
     CFPreferencesSetAppValue(WebStorageDirectoryDefaultsKey, WebCore::pathByAppendingComponent(libraryPath, "LocalStorage").createCFString().get(), appId.get());
     CFPreferencesSetAppValue(WebKitLocalCacheDefaultsKey, WebCore::pathByAppendingComponent(libraryPath, "LocalCache").createCFString().get(), appId.get());
-
-    // Create separate cache for each DRT instance
-    setCacheFolder();
 #endif
 }
 
@@ -1469,6 +1466,9 @@
     ASSERT(standardPreferencesPrivate);
     standardPreferences->setAutosaves(FALSE);
 
+    auto newCache = adoptCF(CFURLCacheCreate(kCFAllocatorDefault, 1024 * 1024, 0, nullptr));
+    CFURLCacheSetSharedURLCache(newCache.get());
+
     COMPtr<IWebPreferencesPrivate4> prefsPrivate4(Query, standardPreferences);
     prefsPrivate4->switchNetworkLoaderToNewTestingSession();
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to