Title: [218277] trunk/LayoutTests
- Revision
- 218277
- Author
- [email protected]
- Date
- 2017-06-14 11:42:15 -0700 (Wed, 14 Jun 2017)
Log Message
transitions/created-while-suspended.html is slow and flaky
https://bugs.webkit.org/show_bug.cgi?id=173370
Reviewed by Zalan Bujtas.
The test was waiting 8 seconds at the end, unnecessarily.
Instead, end the test as soon as the transition ends, after resuming
the animations.
* TestExpectations:
* platform/gtk/TestExpectations:
* platform/wpe/TestExpectations:
* transitions/created-while-suspended-expected.txt:
* transitions/created-while-suspended.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (218276 => 218277)
--- trunk/LayoutTests/ChangeLog 2017-06-14 18:22:39 UTC (rev 218276)
+++ trunk/LayoutTests/ChangeLog 2017-06-14 18:42:15 UTC (rev 218277)
@@ -1,3 +1,20 @@
+2017-06-14 Chris Dumez <[email protected]>
+
+ transitions/created-while-suspended.html is slow and flaky
+ https://bugs.webkit.org/show_bug.cgi?id=173370
+
+ Reviewed by Zalan Bujtas.
+
+ The test was waiting 8 seconds at the end, unnecessarily.
+ Instead, end the test as soon as the transition ends, after resuming
+ the animations.
+
+ * TestExpectations:
+ * platform/gtk/TestExpectations:
+ * platform/wpe/TestExpectations:
+ * transitions/created-while-suspended-expected.txt:
+ * transitions/created-while-suspended.html:
+
2017-06-14 Antoine Quint <[email protected]>
Layout Test media/modern-media-controls/placard-support/placard-support-pip.html is failing
Modified: trunk/LayoutTests/TestExpectations (218276 => 218277)
--- trunk/LayoutTests/TestExpectations 2017-06-14 18:22:39 UTC (rev 218276)
+++ trunk/LayoutTests/TestExpectations 2017-06-14 18:42:15 UTC (rev 218277)
@@ -403,7 +403,6 @@
webkit.org/b/137883 transitions/color-transition-all.html [ Failure Pass ]
webkit.org/b/137883 transitions/color-transition-premultiplied.html [ Failure Pass ]
webkit.org/b/137883 transitions/color-transition-rounding.html [ Failure Pass ]
-webkit.org/b/137883 transitions/created-while-suspended.html [ Failure Pass ]
webkit.org/b/137883 transitions/cross-fade-background-image.html [ Pass Failure ]
webkit.org/b/137883 transitions/cross-fade-border-image.html [ Pass Failure ]
webkit.org/b/137883 transitions/cubic-bezier-overflow-color.html [ Pass Failure ]
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (218276 => 218277)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2017-06-14 18:22:39 UTC (rev 218276)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2017-06-14 18:42:15 UTC (rev 218277)
@@ -1980,8 +1980,6 @@
webkit.org/b/116958 http/tests/navigation/slowmetaredirect-basic.html [ Pass Slow ]
webkit.org/b/116958 http/tests/navigation/slowtimerredirect-basic.html [ Pass Slow ]
-webkit.org/b/119264 transitions/created-while-suspended.html [ Pass Slow ]
-
webkit.org/b/149916 http/tests/inspector/dom/disconnect-dom-tree-after-main-frame-navigation.html [ Pass Slow ]
webkit.org/b/149916 inspector/codemirror/prettyprinting-css.html [ Pass Slow ]
webkit.org/b/149916 inspector/codemirror/prettyprinting-css-rules.html [ Pass Timeout ]
Modified: trunk/LayoutTests/platform/wpe/TestExpectations (218276 => 218277)
--- trunk/LayoutTests/platform/wpe/TestExpectations 2017-06-14 18:22:39 UTC (rev 218276)
+++ trunk/LayoutTests/platform/wpe/TestExpectations 2017-06-14 18:42:15 UTC (rev 218277)
@@ -383,7 +383,6 @@
Bug(WPE) css3/zoom-coords.xhtml [ Failure ]
webkit.org/b/133151 js/cached-window-properties.html [ Slow ]
-webkit.org/b/119264 transitions/created-while-suspended.html [ Pass Slow ]
webkit.org/b/159754 workers/bomb.html [ Slow ]
# We won't be supporting the deprecated interfaces.
Modified: trunk/LayoutTests/transitions/created-while-suspended-expected.txt (218276 => 218277)
--- trunk/LayoutTests/transitions/created-while-suspended-expected.txt 2017-06-14 18:22:39 UTC (rev 218276)
+++ trunk/LayoutTests/transitions/created-while-suspended-expected.txt 2017-06-14 18:42:15 UTC (rev 218277)
@@ -8,5 +8,5 @@
*** Adding transition property and setting left to 100px. We should NOT see transition events.
*** Resuming Animations/Transitions
Transitions should not be suspended: PASS
-*** Test finished
+PASS: Transition ended on element with id: box
Modified: trunk/LayoutTests/transitions/created-while-suspended.html (218276 => 218277)
--- trunk/LayoutTests/transitions/created-while-suspended.html 2017-06-14 18:22:39 UTC (rev 218276)
+++ trunk/LayoutTests/transitions/created-while-suspended.html 2017-06-14 18:42:15 UTC (rev 218277)
@@ -11,6 +11,8 @@
<script>
var box;
+let transitionAllowedToRun = false;
+
function suspend()
{
if (window.internals)
@@ -25,7 +27,13 @@
function transitionEnded(event)
{
- log("#### Transition ended on element with id: " + event.target.id);
+ if (transitionAllowedToRun)
+ log("PASS: Transition ended on element with id: " + event.target.id);
+ else
+ log("FAIL: Transition ended on element with id: " + event.target.id);
+
+ if (window.testRunner)
+ testRunner.notifyDone();
}
function suspendAndCreate()
@@ -45,22 +53,18 @@
log("*** Adding transition property and setting left to 100px. We should NOT see transition events.")
box.style.webkitTransitionDuration = "100ms";
box.style.left = "100px";
- setTimeout(endTest, 200);
+ setTimeout(resumeAnimations, 200);
}, 100);
}, 100);
}
-function endTest()
+function resumeAnimations()
{
log("*** Resuming Animations/Transitions");
+ transitionAllowedToRun = true;
resume();
if (window.internals)
log("Transitions should not be suspended: " + (window.internals.animationsAreSuspended() ? "FAIL" : "PASS"));
-
- resume(); // Just in case.
- log("*** Test finished");
- if (window.testRunner)
- setTimeout(function () { testRunner.notifyDone();}, 8000);
}
function startTest()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
