Title: [218311] trunk/Source/WebCore
- Revision
- 218311
- Author
- [email protected]
- Date
- 2017-06-14 19:36:36 -0700 (Wed, 14 Jun 2017)
Log Message
animations-paused-in-background-page.html and animated-svg-image-removed-from-document-paused.html fail after r218284
https://bugs.webkit.org/show_bug.cgi?id=173393
Reviewed by Simon Fraser.
Testing cares really about whether the animation has initiated.
* platform/graphics/Image.h:
(WebCore::Image::animationPending):
* testing/Internals.cpp:
(WebCore::Internals::isImageAnimating):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (218310 => 218311)
--- trunk/Source/WebCore/ChangeLog 2017-06-15 02:15:48 UTC (rev 218310)
+++ trunk/Source/WebCore/ChangeLog 2017-06-15 02:36:36 UTC (rev 218311)
@@ -1,3 +1,17 @@
+2017-06-14 Zalan Bujtas <[email protected]>
+
+ animations-paused-in-background-page.html and animated-svg-image-removed-from-document-paused.html fail after r218284
+ https://bugs.webkit.org/show_bug.cgi?id=173393
+
+ Reviewed by Simon Fraser.
+
+ Testing cares really about whether the animation has initiated.
+
+ * platform/graphics/Image.h:
+ (WebCore::Image::animationPending):
+ * testing/Internals.cpp:
+ (WebCore::Internals::isImageAnimating):
+
2017-06-14 Dean Jackson <[email protected]>
Restrict filtered painting across cross-origin boundaries with transforms
Modified: trunk/Source/WebCore/platform/graphics/Image.h (218310 => 218311)
--- trunk/Source/WebCore/platform/graphics/Image.h 2017-06-15 02:15:48 UTC (rev 218310)
+++ trunk/Source/WebCore/platform/graphics/Image.h 2017-06-15 02:36:36 UTC (rev 218311)
@@ -135,6 +135,7 @@
virtual void resetAnimation() {}
virtual void imageFrameAvailableAtIndex(size_t) { }
virtual bool isAnimating() const { return false; }
+ bool animationPending() const { return m_animationStartTimer.isActive(); }
// Typically the CachedImage that owns us.
ImageObserver* imageObserver() const { return m_imageObserver; }
Modified: trunk/Source/WebCore/testing/Internals.cpp (218310 => 218311)
--- trunk/Source/WebCore/testing/Internals.cpp 2017-06-15 02:15:48 UTC (rev 218310)
+++ trunk/Source/WebCore/testing/Internals.cpp 2017-06-15 02:36:36 UTC (rev 218311)
@@ -801,7 +801,7 @@
if (!image)
return false;
- return image->isAnimating();
+ return image->isAnimating() || image->animationPending();
}
void Internals::setClearDecoderAfterAsyncFrameRequestForTesting(HTMLImageElement& element, bool value)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
