Title: [218337] trunk/Tools
- Revision
- 218337
- Author
- [email protected]
- Date
- 2017-06-15 10:01:26 -0700 (Thu, 15 Jun 2017)
Log Message
[Win] Crash in accessibility layout test.
https://bugs.webkit.org/show_bug.cgi?id=173401
Reviewed by Brent Fulgham.
We should not manually release the punkVal IUnknown member in a _variant_t object, since the punkVal
member will be automatically released when the _variant_t object goes out of scope if the vt member
does not equal VT_UNKNOWN | VT_BYREF.
See https://msdn.microsoft.com/en-us/library/windows/desktop/ms221165(v=vs.85).aspx.
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::titleUIElement):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (218336 => 218337)
--- trunk/Tools/ChangeLog 2017-06-15 16:57:17 UTC (rev 218336)
+++ trunk/Tools/ChangeLog 2017-06-15 17:01:26 UTC (rev 218337)
@@ -1,3 +1,18 @@
+2017-06-15 Per Arne Vollan <[email protected]>
+
+ [Win] Crash in accessibility layout test.
+ https://bugs.webkit.org/show_bug.cgi?id=173401
+
+ Reviewed by Brent Fulgham.
+
+ We should not manually release the punkVal IUnknown member in a _variant_t object, since the punkVal
+ member will be automatically released when the _variant_t object goes out of scope if the vt member
+ does not equal VT_UNKNOWN | VT_BYREF.
+ See https://msdn.microsoft.com/en-us/library/windows/desktop/ms221165(v=vs.85).aspx.
+
+ * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
+ (AccessibilityUIElement::titleUIElement):
+
2017-06-15 Carlos Garcia Campos <[email protected]>
[GTK] Add API to allow overriding popup menus
Modified: trunk/Tools/DumpRenderTree/win/AccessibilityUIElementWin.cpp (218336 => 218337)
--- trunk/Tools/DumpRenderTree/win/AccessibilityUIElementWin.cpp 2017-06-15 16:57:17 UTC (rev 218336)
+++ trunk/Tools/DumpRenderTree/win/AccessibilityUIElementWin.cpp 2017-06-15 17:01:26 UTC (rev 218337)
@@ -200,8 +200,6 @@
return nullptr;
COMPtr<IAccessible> titleElement(Query, value.punkVal);
- if (value.punkVal)
- value.punkVal->Release();
return titleElement;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
