Title: [218566] releases/WebKitGTK/webkit-2.16/Source/_javascript_Core
Revision
218566
Author
[email protected]
Date
2017-06-20 01:25:41 -0700 (Tue, 20 Jun 2017)

Log Message

Merge r217650 - RELEASE_ASSERT_NOT_REACHED() in InferredType::kindForFlags() on Big-Endians
https://bugs.webkit.org/show_bug.cgi?id=170945

Patch by Tomas Popela  <[email protected]>, Mark Lam <[email protected]> on 2017-06-01
Reviewed by Mark Lam.

Re-define PutByIdFlags as a int32_t enum explicitly because it is
stored as an int32_t value in UnlinkedInstruction.  This prevents
a bug on 64-bit big endian architectures where the word order is
inverted (when we convert the UnlinkedInstruction into a CodeBlock
Instruction), resulting in the PutByIdFlags value not being stored in
the 32-bit word that the rest of the code expects it to be in.

* bytecode/PutByIdFlags.h:

Modified Paths

Diff

Modified: releases/WebKitGTK/webkit-2.16/Source/_javascript_Core/ChangeLog (218565 => 218566)


--- releases/WebKitGTK/webkit-2.16/Source/_javascript_Core/ChangeLog	2017-06-20 08:08:06 UTC (rev 218565)
+++ releases/WebKitGTK/webkit-2.16/Source/_javascript_Core/ChangeLog	2017-06-20 08:25:41 UTC (rev 218566)
@@ -1,3 +1,19 @@
+2017-06-01  Tomas Popela  <[email protected]>, Mark Lam  <[email protected]>
+
+        RELEASE_ASSERT_NOT_REACHED() in InferredType::kindForFlags() on Big-Endians
+        https://bugs.webkit.org/show_bug.cgi?id=170945
+
+        Reviewed by Mark Lam.
+
+        Re-define PutByIdFlags as a int32_t enum explicitly because it is
+        stored as an int32_t value in UnlinkedInstruction.  This prevents
+        a bug on 64-bit big endian architectures where the word order is
+        inverted (when we convert the UnlinkedInstruction into a CodeBlock
+        Instruction), resulting in the PutByIdFlags value not being stored in
+        the 32-bit word that the rest of the code expects it to be in.
+
+        * bytecode/PutByIdFlags.h:
+
 2017-05-10  Mark Lam  <[email protected]>
 
         Crash in _javascript_Core GC when using JSC on dispatch queues (thread_get_state returns NULL stack pointer).

Modified: releases/WebKitGTK/webkit-2.16/Source/_javascript_Core/bytecode/PutByIdFlags.h (218565 => 218566)


--- releases/WebKitGTK/webkit-2.16/Source/_javascript_Core/bytecode/PutByIdFlags.h	2017-06-20 08:08:06 UTC (rev 218565)
+++ releases/WebKitGTK/webkit-2.16/Source/_javascript_Core/bytecode/PutByIdFlags.h	2017-06-20 08:25:41 UTC (rev 218566)
@@ -29,7 +29,7 @@
 
 namespace JSC {
 
-enum PutByIdFlags : intptr_t {
+enum PutByIdFlags : int32_t {
     PutByIdNone = 0,
 
     // This flag indicates that the put_by_id is direct. That means that we store the property without
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to