Title: [218578] releases/WebKitGTK/webkit-2.16/Source/_javascript_Core
Revision
218578
Author
carlo...@webkit.org
Date
2017-06-20 03:00:09 -0700 (Tue, 20 Jun 2017)

Log Message

Merge r218392 - REGRESSION(r166799): LogsPageMessagesToSystemConsoleEnabled corrupts non-ASCII characters
https://bugs.webkit.org/show_bug.cgi?id=173470

Reviewed by Joseph Pecoraro.

ConsoleClient::printConsoleMessageWithArguments() incorrectly uses
const char* overload of StringBuilder::append() that assummes Latin1
encoding, not UTF8.

* runtime/ConsoleClient.cpp:
(JSC::ConsoleClient::printConsoleMessageWithArguments):

Modified Paths

Diff

Modified: releases/WebKitGTK/webkit-2.16/Source/_javascript_Core/ChangeLog (218577 => 218578)


--- releases/WebKitGTK/webkit-2.16/Source/_javascript_Core/ChangeLog	2017-06-20 09:51:07 UTC (rev 218577)
+++ releases/WebKitGTK/webkit-2.16/Source/_javascript_Core/ChangeLog	2017-06-20 10:00:09 UTC (rev 218578)
@@ -1,3 +1,17 @@
+2017-06-16  Konstantin Tokarev  <annu...@yandex.ru>
+
+        REGRESSION(r166799): LogsPageMessagesToSystemConsoleEnabled corrupts non-ASCII characters
+        https://bugs.webkit.org/show_bug.cgi?id=173470
+
+        Reviewed by Joseph Pecoraro.
+
+        ConsoleClient::printConsoleMessageWithArguments() incorrectly uses
+        const char* overload of StringBuilder::append() that assummes Latin1
+        encoding, not UTF8.
+
+        * runtime/ConsoleClient.cpp:
+        (JSC::ConsoleClient::printConsoleMessageWithArguments):
+
 2017-06-01  Tomas Popela  <tpop...@redhat.com>, Mark Lam  <mark....@apple.com>
 
         RELEASE_ASSERT_NOT_REACHED() in InferredType::kindForFlags() on Big-Endians

Modified: releases/WebKitGTK/webkit-2.16/Source/_javascript_Core/runtime/ConsoleClient.cpp (218577 => 218578)


--- releases/WebKitGTK/webkit-2.16/Source/_javascript_Core/runtime/ConsoleClient.cpp	2017-06-20 09:51:07 UTC (rev 218577)
+++ releases/WebKitGTK/webkit-2.16/Source/_javascript_Core/runtime/ConsoleClient.cpp	2017-06-20 10:00:09 UTC (rev 218578)
@@ -165,7 +165,7 @@
     for (size_t i = 0; i < arguments->argumentCount(); ++i) {
         String argAsString = arguments->argumentAt(i).toString(arguments->globalState());
         builder.append(' ');
-        builder.append(argAsString.utf8().data());
+        builder.append(argAsString);
     }
 
     WTFLogAlways("%s", builder.toString().utf8().data());
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to