Title: [218604] trunk/Source/WebCore
- Revision
- 218604
- Author
- [email protected]
- Date
- 2017-06-20 11:48:00 -0700 (Tue, 20 Jun 2017)
Log Message
Remove no-op calls to purge SQLite caches on memory pressure.
<https://webkit.org/b/173604>
Reviewed by Chris Dumez.
The implementation of _sqlite3_purgeEligiblePagerCacheMemory() is empty
since a few releases ago, so there's no point in calling it.
* page/MemoryRelease.cpp:
(WebCore::registerMemoryReleaseNotifyCallbacks):
(WebCore::registerSQLiteMemoryPressureHandler): Deleted.
* page/MemoryRelease.h:
* page/cocoa/MemoryReleaseCocoa.mm:
(WebCore::platformReleaseMemory):
(WebCore::registerSQLiteMemoryPressureHandler): Deleted.
* platform/sql/SQLiteDatabase.cpp:
(WebCore::initializeSQLiteIfNecessary):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (218603 => 218604)
--- trunk/Source/WebCore/ChangeLog 2017-06-20 18:35:31 UTC (rev 218603)
+++ trunk/Source/WebCore/ChangeLog 2017-06-20 18:48:00 UTC (rev 218604)
@@ -1,3 +1,23 @@
+2017-06-20 Andreas Kling <[email protected]>
+
+ Remove no-op calls to purge SQLite caches on memory pressure.
+ <https://webkit.org/b/173604>
+
+ Reviewed by Chris Dumez.
+
+ The implementation of _sqlite3_purgeEligiblePagerCacheMemory() is empty
+ since a few releases ago, so there's no point in calling it.
+
+ * page/MemoryRelease.cpp:
+ (WebCore::registerMemoryReleaseNotifyCallbacks):
+ (WebCore::registerSQLiteMemoryPressureHandler): Deleted.
+ * page/MemoryRelease.h:
+ * page/cocoa/MemoryReleaseCocoa.mm:
+ (WebCore::platformReleaseMemory):
+ (WebCore::registerSQLiteMemoryPressureHandler): Deleted.
+ * platform/sql/SQLiteDatabase.cpp:
+ (WebCore::initializeSQLiteIfNecessary):
+
2017-06-20 Devin Rousso <[email protected]>
Web Inspector: add console messages for WebGL shader compile and program link errors/warnings
Modified: trunk/Source/WebCore/page/MemoryRelease.cpp (218603 => 218604)
--- trunk/Source/WebCore/page/MemoryRelease.cpp 2017-06-20 18:35:31 UTC (rev 218603)
+++ trunk/Source/WebCore/page/MemoryRelease.cpp 2017-06-20 18:48:00 UTC (rev 218604)
@@ -191,7 +191,6 @@
void platformReleaseMemory(Critical) { }
void jettisonExpensiveObjectsOnTopLevelNavigation() { }
void registerMemoryReleaseNotifyCallbacks() { }
-void registerSQLiteMemoryPressureHandler() { }
#endif
} // namespace WebCore
Modified: trunk/Source/WebCore/page/MemoryRelease.h (218603 => 218604)
--- trunk/Source/WebCore/page/MemoryRelease.h 2017-06-20 18:35:31 UTC (rev 218603)
+++ trunk/Source/WebCore/page/MemoryRelease.h 2017-06-20 18:48:00 UTC (rev 218604)
@@ -34,6 +34,5 @@
void jettisonExpensiveObjectsOnTopLevelNavigation();
WEBCORE_EXPORT void registerMemoryReleaseNotifyCallbacks();
WEBCORE_EXPORT void logMemoryStatisticsAtTimeOfDeath();
-void registerSQLiteMemoryPressureHandler();
} // namespace WebCore
Modified: trunk/Source/WebCore/page/cocoa/MemoryReleaseCocoa.mm (218603 => 218604)
--- trunk/Source/WebCore/page/cocoa/MemoryReleaseCocoa.mm 2017-06-20 18:35:31 UTC (rev 218603)
+++ trunk/Source/WebCore/page/cocoa/MemoryReleaseCocoa.mm 2017-06-20 18:48:00 UTC (rev 218604)
@@ -38,10 +38,6 @@
#endif
-extern "C" void _sqlite3_purgeEligiblePagerCacheMemory(void);
-
-static bool isSQLiteMemoryPressureHandlerRegistered { false };
-
namespace WebCore {
void platformReleaseMemory(Critical)
@@ -50,9 +46,6 @@
GSFontPurgeFontCache();
#endif
- if (isSQLiteMemoryPressureHandlerRegistered)
- _sqlite3_purgeEligiblePagerCacheMemory();
-
for (auto& pool : LayerPool::allLayerPools())
pool->drain();
@@ -103,9 +96,4 @@
});
}
-void registerSQLiteMemoryPressureHandler()
-{
- isSQLiteMemoryPressureHandlerRegistered = true;
-}
-
} // namespace WebCore
Modified: trunk/Source/WebCore/platform/sql/SQLiteDatabase.cpp (218603 => 218604)
--- trunk/Source/WebCore/platform/sql/SQLiteDatabase.cpp 2017-06-20 18:35:31 UTC (rev 218603)
+++ trunk/Source/WebCore/platform/sql/SQLiteDatabase.cpp 2017-06-20 18:48:00 UTC (rev 218604)
@@ -67,7 +67,6 @@
#endif
CRASH();
}
- registerSQLiteMemoryPressureHandler();
});
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
