Title: [218607] trunk/LayoutTests
- Revision
- 218607
- Author
- grao...@webkit.org
- Date
- 2017-06-20 13:37:59 -0700 (Tue, 20 Jun 2017)
Log Message
REGRESSION: media/remote-control-command-seek.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=173615
<rdar://problem/32626498>
Reviewed by Eric Carlson.
This test assumes that we load metadata and video data that can be seeked through
at the same time, but this is incorrect. Using the "canplaythrough" event guarantees
that the video is seekable, so we switch to this event to make the test more robust.
* media/remote-control-command-seek-expected.txt:
* media/remote-control-command-seek.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (218606 => 218607)
--- trunk/LayoutTests/ChangeLog 2017-06-20 19:46:14 UTC (rev 218606)
+++ trunk/LayoutTests/ChangeLog 2017-06-20 20:37:59 UTC (rev 218607)
@@ -1,3 +1,18 @@
+2017-06-20 Antoine Quint <grao...@apple.com>
+
+ REGRESSION: media/remote-control-command-seek.html is timing out
+ https://bugs.webkit.org/show_bug.cgi?id=173615
+ <rdar://problem/32626498>
+
+ Reviewed by Eric Carlson.
+
+ This test assumes that we load metadata and video data that can be seeked through
+ at the same time, but this is incorrect. Using the "canplaythrough" event guarantees
+ that the video is seekable, so we switch to this event to make the test more robust.
+
+ * media/remote-control-command-seek-expected.txt:
+ * media/remote-control-command-seek.html:
+
2017-06-20 Matt Lewis <jlew...@apple.com>
Added additional test expectations for media/video-buffered.html.
Modified: trunk/LayoutTests/media/remote-control-command-seek-expected.txt (218606 => 218607)
--- trunk/LayoutTests/media/remote-control-command-seek-expected.txt 2017-06-20 19:46:14 UTC (rev 218606)
+++ trunk/LayoutTests/media/remote-control-command-seek-expected.txt 2017-06-20 20:37:59 UTC (rev 218607)
@@ -2,7 +2,7 @@
* set video.src
-EVENT(loadedmetadata)
+EVENT(canplaythrough)
* Send a seek command.
RUN(internals.postRemoteControlCommand('seekToPlaybackPosition', 1.6))
Modified: trunk/LayoutTests/media/remote-control-command-seek.html (218606 => 218607)
--- trunk/LayoutTests/media/remote-control-command-seek.html 2017-06-20 19:46:14 UTC (rev 218606)
+++ trunk/LayoutTests/media/remote-control-command-seek.html 2017-06-20 20:37:59 UTC (rev 218607)
@@ -13,7 +13,7 @@
findMediaElement();
- waitForEvent('loadedmetadata', loadedmetadata, false, true, document)
+ waitForEvent('canplaythrough', canplaythrough, false, true, document)
waitForEvent('timeupdate', seeked)
consoleWrite('* set video.src');
@@ -20,7 +20,7 @@
video.src = "" 'content/test');
}
- function loadedmetadata()
+ function canplaythrough()
{
consoleWrite('<br>* Send a seek command.');
run("internals.postRemoteControlCommand('seekToPlaybackPosition', 1.6)");
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
