Diff
Modified: trunk/LayoutTests/ChangeLog (218650 => 218651)
--- trunk/LayoutTests/ChangeLog 2017-06-21 21:20:11 UTC (rev 218650)
+++ trunk/LayoutTests/ChangeLog 2017-06-21 21:29:21 UTC (rev 218651)
@@ -1,3 +1,21 @@
+2017-06-20 Simon Fraser <[email protected]>
+
+ Remove WILL_REVEAL_EDGE_EVENTS code
+ https://bugs.webkit.org/show_bug.cgi?id=173632
+
+ Reviewed by Sam Weinig, Beth Dakin.
+
+ Remove will-reveal-edge events, which never took off.
+
+ * fast/events/will-reveal-edge-on-div-expected.txt: Removed.
+ * fast/events/will-reveal-edge-on-div.html: Removed.
+ * fast/events/will-reveal-edges-body-attributes-expected.txt: Removed.
+ * fast/events/will-reveal-edges-body-attributes.html: Removed.
+ * fast/events/will-reveal-edges-event-listeners-expected.txt: Removed.
+ * fast/events/will-reveal-edges-event-listeners.html: Removed.
+ * fast/events/will-reveal-edges-window-attributes-expected.txt: Removed.
+ * fast/events/will-reveal-edges-window-attributes.html: Removed.
+
2017-06-21 Simon Fraser <[email protected]>
svgPath.getTotalLength() freezes webkit
Deleted: trunk/LayoutTests/fast/events/will-reveal-edge-on-div-expected.txt (218650 => 218651)
--- trunk/LayoutTests/fast/events/will-reveal-edge-on-div-expected.txt 2017-06-21 21:20:11 UTC (rev 218650)
+++ trunk/LayoutTests/fast/events/will-reveal-edge-on-div-expected.txt 2017-06-21 21:29:21 UTC (rev 218651)
@@ -1,10 +0,0 @@
-This tests that we can listen for webkitwillrevealbottom, webkitwillrevealtop, webkitwillrevealleft, and webkitwillrevealright
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-All edges were revealed!
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
Deleted: trunk/LayoutTests/fast/events/will-reveal-edge-on-div.html (218650 => 218651)
--- trunk/LayoutTests/fast/events/will-reveal-edge-on-div.html 2017-06-21 21:20:11 UTC (rev 218650)
+++ trunk/LayoutTests/fast/events/will-reveal-edge-on-div.html 2017-06-21 21:29:21 UTC (rev 218651)
@@ -1,83 +0,0 @@
-<html>
-<script src=""
-
-<style>
-#scrolly-div {
- width:200px;
- height:200px;
- border:2px solid black;
- overflow:scroll;
-}
-
-.big {
- background-color:purple;
- width:600px;
- height:600px;
-}
-</style>
-
-<script type="text/_javascript_">
-description('This tests that we can listen for webkitwillrevealbottom, webkitwillrevealtop, webkitwillrevealleft, and webkitwillrevealright');
-
-var triggeredWillRevealBottom = false;
-var triggeredWillRevealTop = false;
-var triggeredWillRevealRight = false;
-var triggeredWillRevealLeft = false;
-
-function bottomRevealed()
-{
- triggeredWillRevealBottom = true;
- var scrolly = document.getElementById("scrolly-div");
- scrolly.scrollTop = 0;
- checkComplete();
-}
-
-function topRevealed()
-{
- triggeredWillRevealTop = true;
- var scrolly = document.getElementById("scrolly-div");
- scrolly.scrollLeft = 600;
- checkComplete();
-}
-
-function rightRevealed()
-{
- triggeredWillRevealRight = true;
- var scrolly = document.getElementById("scrolly-div");
- scrolly.scrollLeft = 0;
- checkComplete();
-}
-
-function leftRevealed()
-{
- triggeredWillRevealLeft = true;
- checkComplete();
-}
-
-function checkComplete()
-{
- if (triggeredWillRevealBottom && triggeredWillRevealTop && triggeredWillRevealRight && triggeredWillRevealLeft) {
- debug('All edges were revealed!');
- finishJSTest();
- }
-}
-
-var jsTestIsAsync = true;
-
-function runTest() {
- var scrolly = document.getElementById("scrolly-div");
- scrolly.addEventListener('webkitwillrevealbottom', bottomRevealed, false);
- scrolly.addEventListener('webkitwillrevealtop', topRevealed, false);
- scrolly.addEventListener('webkitwillrevealright', rightRevealed, false);
- scrolly.addEventListener('webkitwillrevealleft', leftRevealed, false);
- scrolly.scrollTop = 600;
-}
-</script>
-
-<body _onload_="runTest()">
- <div id="scrolly-div">
- <div class="big"></div>
- </div>
- <script src=""
-</body>
-</html>
Deleted: trunk/LayoutTests/fast/events/will-reveal-edges-body-attributes-expected.txt (218650 => 218651)
--- trunk/LayoutTests/fast/events/will-reveal-edges-body-attributes-expected.txt 2017-06-21 21:20:11 UTC (rev 218650)
+++ trunk/LayoutTests/fast/events/will-reveal-edges-body-attributes-expected.txt 2017-06-21 21:29:21 UTC (rev 218651)
@@ -1,10 +0,0 @@
-This tests that onwebkitwillrevealbottom, onwebkitwillrevealtop, onwebkitwillrevealleft, and onwebkitwillrevealright work as body attributes
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-All edges were revealed!
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
Deleted: trunk/LayoutTests/fast/events/will-reveal-edges-body-attributes.html (218650 => 218651)
--- trunk/LayoutTests/fast/events/will-reveal-edges-body-attributes.html 2017-06-21 21:20:11 UTC (rev 218650)
+++ trunk/LayoutTests/fast/events/will-reveal-edges-body-attributes.html 2017-06-21 21:29:21 UTC (rev 218651)
@@ -1,54 +0,0 @@
-<html>
-<script src=""
-
-<script type="text/_javascript_">
-description('This tests that onwebkitwillrevealbottom, onwebkitwillrevealtop, onwebkitwillrevealleft, and onwebkitwillrevealright work as body attributes');
-
-var triggeredWillRevealBottom = false;
-var triggeredWillRevealTop = false;
-var triggeredWillRevealRight = false;
-var triggeredWillRevealLeft = false;
-
-function willRevealBottom() {
- triggeredWillRevealBottom = true;
- window.scrollTo(0,0);
- checkComplete();
-}
-
-function willRevealTop() {
- triggeredWillRevealTop = true;
- window.scrollTo(2000, 0);
- checkComplete();
-}
-
-function willRevealRight() {
- triggeredWillRevealRight = true;
- window.scrollTo(0, 0);
- checkComplete();
-}
-
-function willRevealLeft() {
- triggeredWillRevealLeft = true;
- checkComplete();
-}
-
-function checkComplete()
-{
- if (triggeredWillRevealBottom && triggeredWillRevealTop && triggeredWillRevealRight && triggeredWillRevealLeft) {
- debug('All edges were revealed!');
- finishJSTest();
- }
-}
-
-var jsTestIsAsync = true;
-
-function runTest() {
- window.scrollTo(0, 2000);
-}
-</script>
-
-<body style="height:2000px; width:2000px;" _onload_="runTest()" _onwebkitwillrevealbottom_="willRevealBottom()"
- _onwebkitwillrevealtop_="willRevealTop()" _onwebkitwillrevealright_="willRevealRight()" _onwebkitwillrevealleft_="willRevealLeft()">
- <script src=""
-</body>
-</html>
Deleted: trunk/LayoutTests/fast/events/will-reveal-edges-event-listeners-expected.txt (218650 => 218651)
--- trunk/LayoutTests/fast/events/will-reveal-edges-event-listeners-expected.txt 2017-06-21 21:20:11 UTC (rev 218650)
+++ trunk/LayoutTests/fast/events/will-reveal-edges-event-listeners-expected.txt 2017-06-21 21:29:21 UTC (rev 218651)
@@ -1,10 +0,0 @@
-This tests that we can listen for webkitwillrevealbottom, webkitwillrevealtop, webkitwillrevealleft, and webkitwillrevealright
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-All edges were revealed!
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
Deleted: trunk/LayoutTests/fast/events/will-reveal-edges-event-listeners.html (218650 => 218651)
--- trunk/LayoutTests/fast/events/will-reveal-edges-event-listeners.html 2017-06-21 21:20:11 UTC (rev 218650)
+++ trunk/LayoutTests/fast/events/will-reveal-edges-event-listeners.html 2017-06-21 21:29:21 UTC (rev 218651)
@@ -1,65 +0,0 @@
-<html>
-<script src=""
-
-<script type="text/_javascript_">
-description('This tests that we can listen for webkitwillrevealbottom, webkitwillrevealtop, webkitwillrevealleft, and webkitwillrevealright');
-
-var triggeredWillRevealBottom = false;
-var triggeredWillRevealTop = false;
-var triggeredWillRevealRight = false;
-var triggeredWillRevealLeft = false;
-
-window.addEventListener(
- 'webkitwillrevealbottom',
- function() {
- triggeredWillRevealBottom = true;
- window.scrollTo(0,0);
- checkComplete();
- },
- false);
-
-window.addEventListener(
- 'webkitwillrevealtop',
- function(event) {
- triggeredWillRevealTop = true;
- window.scrollTo(2000, 0);
- checkComplete();
- },
- false);
-
-window.addEventListener(
- 'webkitwillrevealright',
- function(event) {
- triggeredWillRevealRight = true;
- window.scrollTo(0, 0);
- checkComplete();
- },
- false);
-
-window.addEventListener(
- 'webkitwillrevealleft',
- function(event) {
- triggeredWillRevealLeft = true;
- checkComplete();
- },
- false);
-
-function checkComplete()
-{
- if (triggeredWillRevealBottom && triggeredWillRevealTop && triggeredWillRevealRight && triggeredWillRevealLeft) {
- debug('All edges were revealed!');
- finishJSTest();
- }
-}
-
-var jsTestIsAsync = true;
-
-function runTest() {
- window.scrollTo(0, 2000);
-}
-</script>
-
-<body style="height:2000px; width:2000px;" _onload_="runTest()">
- <script src=""
-</body>
-</html>
Deleted: trunk/LayoutTests/fast/events/will-reveal-edges-window-attributes-expected.txt (218650 => 218651)
--- trunk/LayoutTests/fast/events/will-reveal-edges-window-attributes-expected.txt 2017-06-21 21:20:11 UTC (rev 218650)
+++ trunk/LayoutTests/fast/events/will-reveal-edges-window-attributes-expected.txt 2017-06-21 21:29:21 UTC (rev 218651)
@@ -1,10 +0,0 @@
-This tests that onwebkitwillrevealbottom, onwebkitwillrevealtop, onwebkitwillrevealleft, and onwebkitwillrevealright work as window attributes.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-All edges were revealed!
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
Deleted: trunk/LayoutTests/fast/events/will-reveal-edges-window-attributes.html (218650 => 218651)
--- trunk/LayoutTests/fast/events/will-reveal-edges-window-attributes.html 2017-06-21 21:20:11 UTC (rev 218650)
+++ trunk/LayoutTests/fast/events/will-reveal-edges-window-attributes.html 2017-06-21 21:29:21 UTC (rev 218651)
@@ -1,57 +0,0 @@
-<html>
-<script src=""
-
-<script type="text/_javascript_">
-description('This tests that onwebkitwillrevealbottom, onwebkitwillrevealtop, onwebkitwillrevealleft, and onwebkitwillrevealright work as window attributes.');
-
-var triggeredWillRevealBottom = false;
-var triggeredWillRevealTop = false;
-var triggeredWillRevealRight = false;
-var triggeredWillRevealLeft = false;
-
-window._onwebkitwillrevealbottom_ =
- function() {
- triggeredWillRevealBottom = true;
- window.scrollTo(0,0);
- checkComplete();
- }
-
-window._onwebkitwillrevealtop_ =
- function() {
- triggeredWillRevealTop = true;
- window.scrollTo(2000, 0);
- checkComplete();
- }
-
-window._onwebkitwillrevealright_ =
- function() {
- triggeredWillRevealRight = true;
- window.scrollTo(0, 0);
- checkComplete();
- }
-
-window._onwebkitwillrevealleft_ =
- function() {
- triggeredWillRevealLeft = true;
- checkComplete();
- }
-
-function checkComplete()
-{
- if (triggeredWillRevealBottom && triggeredWillRevealTop && triggeredWillRevealRight && triggeredWillRevealLeft) {
- debug('All edges were revealed!');
- finishJSTest();
- }
-}
-
-var jsTestIsAsync = true;
-
-function runTest() {
- window.scrollTo(0, 2000);
-}
-</script>
-
-<body style="height:2000px; width:2000px;" _onload_="runTest()">
- <script src=""
-</body>
-</html>
Modified: trunk/Source/WTF/ChangeLog (218650 => 218651)
--- trunk/Source/WTF/ChangeLog 2017-06-21 21:20:11 UTC (rev 218650)
+++ trunk/Source/WTF/ChangeLog 2017-06-21 21:29:21 UTC (rev 218651)
@@ -1,3 +1,14 @@
+2017-06-20 Simon Fraser <[email protected]>
+
+ Remove WILL_REVEAL_EDGE_EVENTS code
+ https://bugs.webkit.org/show_bug.cgi?id=173632
+
+ Reviewed by Sam Weinig, Beth Dakin.
+
+ Remove will-reveal-edge events, which never took off.
+
+ * wtf/FeatureDefines.h:
+
2017-06-20 Konstantin Tokarev <[email protected]>
Remove excessive include directives from WTF
Modified: trunk/Source/WTF/wtf/FeatureDefines.h (218650 => 218651)
--- trunk/Source/WTF/wtf/FeatureDefines.h 2017-06-21 21:20:11 UTC (rev 218650)
+++ trunk/Source/WTF/wtf/FeatureDefines.h 2017-06-21 21:29:21 UTC (rev 218651)
@@ -732,10 +732,6 @@
#define ENABLE_WEB_TIMING 0
#endif
-#if !defined(ENABLE_WILL_REVEAL_EDGE_EVENTS)
-#define ENABLE_WILL_REVEAL_EDGE_EVENTS 1
-#endif
-
#if !defined(ENABLE_XSLT)
#define ENABLE_XSLT 1
#endif
Modified: trunk/Source/WebCore/ChangeLog (218650 => 218651)
--- trunk/Source/WebCore/ChangeLog 2017-06-21 21:20:11 UTC (rev 218650)
+++ trunk/Source/WebCore/ChangeLog 2017-06-21 21:29:21 UTC (rev 218651)
@@ -1,3 +1,24 @@
+2017-06-20 Simon Fraser <[email protected]>
+
+ Remove WILL_REVEAL_EDGE_EVENTS code
+ https://bugs.webkit.org/show_bug.cgi?id=173632
+
+ Reviewed by Sam Weinig, Beth Dakin.
+
+ Remove will-reveal-edge events, which never took off.
+
+ * dom/Document.cpp:
+ (WebCore::Document::clearScriptedAnimationController):
+ (WebCore::Document::sendWillRevealEdgeEventsIfNeeded): Deleted.
+ * dom/Document.h:
+ * dom/GlobalEventHandlers.idl:
+ * html/HTMLBodyElement.idl:
+ * html/HTMLFrameSetElement.idl:
+ * page/FrameView.cpp:
+ (WebCore::FrameView::scrollPositionChanged):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::scrollTo):
+
2017-06-21 Daniel Bates <[email protected]>
Cleanup FrameLoadRequest
Modified: trunk/Source/WebCore/dom/Document.cpp (218650 => 218651)
--- trunk/Source/WebCore/dom/Document.cpp 2017-06-21 21:20:11 UTC (rev 218650)
+++ trunk/Source/WebCore/dom/Document.cpp 2017-06-21 21:29:21 UTC (rev 218651)
@@ -6270,78 +6270,7 @@
m_scriptedAnimationController->clearDocumentPointer();
m_scriptedAnimationController = nullptr;
}
-
-void Document::sendWillRevealEdgeEventsIfNeeded(const IntPoint& oldPosition, const IntPoint& newPosition, const IntRect& visibleRect, const IntSize& contentsSize, Element* target)
-{
- // For each edge (top, bottom, left and right), send the will reveal edge event for that direction
- // if newPosition is at or beyond the notification point, if the scroll direction is heading in the
- // direction of that edge point, and if oldPosition is before the notification point (which indicates
- // that this is the first moment that we know we crossed the magic line).
-
-#if ENABLE(WILL_REVEAL_EDGE_EVENTS)
- // FIXME: broken in RTL documents.
- int willRevealBottomNotificationPoint = std::max(0, contentsSize.height() - 2 * visibleRect.height());
- int willRevealTopNotificationPoint = visibleRect.height();
- // Bottom edge.
- if (newPosition.y() >= willRevealBottomNotificationPoint && newPosition.y() > oldPosition.y()
- && willRevealBottomNotificationPoint >= oldPosition.y()) {
- Ref<Event> willRevealEvent = Event::create(eventNames().webkitwillrevealbottomEvent, false, false);
- if (!target)
- enqueueWindowEvent(WTFMove(willRevealEvent));
- else {
- willRevealEvent->setTarget(target);
- m_eventQueue.enqueueEvent(WTFMove(willRevealEvent));
- }
- }
-
- // Top edge.
- if (newPosition.y() <= willRevealTopNotificationPoint && newPosition.y() < oldPosition.y()
- && willRevealTopNotificationPoint <= oldPosition.y()) {
- Ref<Event> willRevealEvent = Event::create(eventNames().webkitwillrevealtopEvent, false, false);
- if (!target)
- enqueueWindowEvent(WTFMove(willRevealEvent));
- else {
- willRevealEvent->setTarget(target);
- m_eventQueue.enqueueEvent(WTFMove(willRevealEvent));
- }
- }
-
- int willRevealRightNotificationPoint = std::max(0, contentsSize.width() - 2 * visibleRect.width());
- int willRevealLeftNotificationPoint = visibleRect.width();
-
- // Right edge.
- if (newPosition.x() >= willRevealRightNotificationPoint && newPosition.x() > oldPosition.x()
- && willRevealRightNotificationPoint >= oldPosition.x()) {
- Ref<Event> willRevealEvent = Event::create(eventNames().webkitwillrevealrightEvent, false, false);
- if (!target)
- enqueueWindowEvent(WTFMove(willRevealEvent));
- else {
- willRevealEvent->setTarget(target);
- m_eventQueue.enqueueEvent(WTFMove(willRevealEvent));
- }
- }
-
- // Left edge.
- if (newPosition.x() <= willRevealLeftNotificationPoint && newPosition.x() < oldPosition.x()
- && willRevealLeftNotificationPoint <= oldPosition.x()) {
- Ref<Event> willRevealEvent = Event::create(eventNames().webkitwillrevealleftEvent, false, false);
- if (!target)
- enqueueWindowEvent(WTFMove(willRevealEvent));
- else {
- willRevealEvent->setTarget(target);
- m_eventQueue.enqueueEvent(WTFMove(willRevealEvent));
- }
- }
-#else
- UNUSED_PARAM(oldPosition);
- UNUSED_PARAM(newPosition);
- UNUSED_PARAM(visibleRect);
- UNUSED_PARAM(contentsSize);
- UNUSED_PARAM(target);
-#endif
-}
-
void Document::wheelEventHandlersChanged()
{
Page* page = this->page();
Modified: trunk/Source/WebCore/dom/Document.h (218650 => 218651)
--- trunk/Source/WebCore/dom/Document.h 2017-06-21 21:20:11 UTC (rev 218650)
+++ trunk/Source/WebCore/dom/Document.h 2017-06-21 21:29:21 UTC (rev 218651)
@@ -1164,8 +1164,6 @@
void cancelAnimationFrame(int id);
void serviceScriptedAnimations(double timestamp);
- void sendWillRevealEdgeEventsIfNeeded(const IntPoint& oldPosition, const IntPoint& newPosition, const IntRect& visibleRect, const IntSize& contentsSize, Element* target = nullptr);
-
EventTarget* errorEventTarget() final;
void logExceptionToConsole(const String& errorMessage, const String& sourceURL, int lineNumber, int columnNumber, RefPtr<Inspector::ScriptCallStack>&&) final;
Modified: trunk/Source/WebCore/dom/GlobalEventHandlers.idl (218650 => 218651)
--- trunk/Source/WebCore/dom/GlobalEventHandlers.idl 2017-06-21 21:20:11 UTC (rev 218650)
+++ trunk/Source/WebCore/dom/GlobalEventHandlers.idl 2017-06-21 21:29:21 UTC (rev 218651)
@@ -122,8 +122,4 @@
[NotEnumerable, Conditional=MOUSE_FORCE_EVENTS] attribute EventHandler onwebkitmouseforcedown;
[NotEnumerable, Conditional=MOUSE_FORCE_EVENTS] attribute EventHandler onwebkitmouseforcewillbegin;
[NotEnumerable, Conditional=MOUSE_FORCE_EVENTS] attribute EventHandler onwebkitmouseforceup;
- [NotEnumerable, Conditional=WILL_REVEAL_EDGE_EVENTS] attribute EventHandler onwebkitwillrevealbottom;
- [NotEnumerable, Conditional=WILL_REVEAL_EDGE_EVENTS] attribute EventHandler onwebkitwillrevealleft;
- [NotEnumerable, Conditional=WILL_REVEAL_EDGE_EVENTS] attribute EventHandler onwebkitwillrevealright;
- [NotEnumerable, Conditional=WILL_REVEAL_EDGE_EVENTS] attribute EventHandler onwebkitwillrevealtop;
};
Modified: trunk/Source/WebCore/html/HTMLBodyElement.idl (218650 => 218651)
--- trunk/Source/WebCore/html/HTMLBodyElement.idl 2017-06-21 21:20:11 UTC (rev 218650)
+++ trunk/Source/WebCore/html/HTMLBodyElement.idl 2017-06-21 21:29:21 UTC (rev 218651)
@@ -39,10 +39,6 @@
[NotEnumerable, WindowEventHandler, Conditional=MOUSE_FORCE_EVENTS] attribute EventHandler onwebkitmouseforcedown;
[NotEnumerable, WindowEventHandler, Conditional=MOUSE_FORCE_EVENTS] attribute EventHandler onwebkitmouseforcewillbegin;
[NotEnumerable, WindowEventHandler, Conditional=MOUSE_FORCE_EVENTS] attribute EventHandler onwebkitmouseforceup;
- [NotEnumerable, WindowEventHandler, Conditional=WILL_REVEAL_EDGE_EVENTS] attribute EventHandler onwebkitwillrevealbottom;
- [NotEnumerable, WindowEventHandler, Conditional=WILL_REVEAL_EDGE_EVENTS] attribute EventHandler onwebkitwillrevealleft;
- [NotEnumerable, WindowEventHandler, Conditional=WILL_REVEAL_EDGE_EVENTS] attribute EventHandler onwebkitwillrevealright;
- [NotEnumerable, WindowEventHandler, Conditional=WILL_REVEAL_EDGE_EVENTS] attribute EventHandler onwebkitwillrevealtop;
// Unique to Document and HTMLBodyElement
[NotEnumerable, DocumentEventHandler] attribute EventHandler onselectionchange;
Modified: trunk/Source/WebCore/html/HTMLFrameSetElement.idl (218650 => 218651)
--- trunk/Source/WebCore/html/HTMLFrameSetElement.idl 2017-06-21 21:20:11 UTC (rev 218650)
+++ trunk/Source/WebCore/html/HTMLFrameSetElement.idl 2017-06-21 21:29:21 UTC (rev 218651)
@@ -31,11 +31,6 @@
[NotEnumerable, WindowEventHandler] attribute EventHandler onresize;
[NotEnumerable, WindowEventHandler] attribute EventHandler onscroll;
- [NotEnumerable, WindowEventHandler, Conditional=WILL_REVEAL_EDGE_EVENTS] attribute EventHandler onwebkitwillrevealbottom;
- [NotEnumerable, WindowEventHandler, Conditional=WILL_REVEAL_EDGE_EVENTS] attribute EventHandler onwebkitwillrevealleft;
- [NotEnumerable, WindowEventHandler, Conditional=WILL_REVEAL_EDGE_EVENTS] attribute EventHandler onwebkitwillrevealright;
- [NotEnumerable, WindowEventHandler, Conditional=WILL_REVEAL_EDGE_EVENTS] attribute EventHandler onwebkitwillrevealtop;
-
// Non-standard named getter
// FIXME: This is not in the standard, can we remove this?
getter DOMWindow (DOMString name);
Modified: trunk/Source/WebCore/page/FrameView.cpp (218650 => 218651)
--- trunk/Source/WebCore/page/FrameView.cpp 2017-06-21 21:20:11 UTC (rev 218650)
+++ trunk/Source/WebCore/page/FrameView.cpp 2017-06-21 21:29:21 UTC (rev 218651)
@@ -2540,6 +2540,9 @@
// These scroll positions are affected by zooming.
void FrameView::scrollPositionChanged(const ScrollPosition& oldPosition, const ScrollPosition& newPosition)
{
+ UNUSED_PARAM(oldPosition);
+ UNUSED_PARAM(newPosition);
+
Page* page = frame().page();
Seconds throttlingDelay = page ? page->chrome().client().eventThrottlingDelay() : 0_s;
@@ -2549,9 +2552,6 @@
} else if (!m_delayedScrollEventTimer.isActive())
m_delayedScrollEventTimer.startOneShot(throttlingDelay);
- if (Document* document = frame().document())
- document->sendWillRevealEdgeEventsIfNeeded(oldPosition, newPosition, visibleContentRect(), contentsSize());
-
if (RenderView* renderView = this->renderView()) {
if (renderView->usesCompositing())
renderView->compositor().frameViewDidScroll();
Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (218650 => 218651)
--- trunk/Source/WebCore/rendering/RenderLayer.cpp 2017-06-21 21:20:11 UTC (rev 218650)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2017-06-21 21:29:21 UTC (rev 218651)
@@ -2406,7 +2406,6 @@
return;
}
- ScrollPosition oldPosition = IntPoint(m_scrollPosition);
m_scrollPosition = newPosition;
RenderView& view = renderer().view();
@@ -2457,10 +2456,8 @@
renderer().repaintUsingContainer(repaintContainer, rectForRepaint);
// Schedule the scroll and scroll-related DOM events.
- if (Element* element = renderer().element()) {
+ if (Element* element = renderer().element())
element->document().eventQueue().enqueueOrDispatchScrollEvent(*element);
- element->document().sendWillRevealEdgeEventsIfNeeded(oldPosition, newPosition, visibleContentRect(), contentsSize(), element);
- }
if (scrollsOverflow())
view.frameView().didChangeScrollOffset();
