Title: [218655] trunk
- Revision
- 218655
- Author
- [email protected]
- Date
- 2017-06-21 14:55:27 -0700 (Wed, 21 Jun 2017)
Log Message
CSS text properties affect <video> shadow root
https://bugs.webkit.org/show_bug.cgi?id=173664
<rdar://problem/32904328>
Patch by Antoine Quint <[email protected]> on 2017-06-21
Reviewed by Dean Jackson.
Source/WebCore:
Ensure that we reset all inheritable styles back to their initial value for media shadow roots.
Test: media/modern-media-controls/time-label/time-label-inherited-text-indent.html
* Modules/modern-media-controls/controls/media-controls.css:
(.media-controls-container):
LayoutTests:
Add a test that ensures that setting an inheritable style on the <video> does not affect
time labels within the shadow root.
* media/modern-media-controls/time-label/time-label-inherited-text-indent-expected.txt: Added.
* media/modern-media-controls/time-label/time-label-inherited-text-indent.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (218654 => 218655)
--- trunk/LayoutTests/ChangeLog 2017-06-21 21:50:42 UTC (rev 218654)
+++ trunk/LayoutTests/ChangeLog 2017-06-21 21:55:27 UTC (rev 218655)
@@ -1,3 +1,17 @@
+2017-06-21 Antoine Quint <[email protected]>
+
+ CSS text properties affect <video> shadow root
+ https://bugs.webkit.org/show_bug.cgi?id=173664
+ <rdar://problem/32904328>
+
+ Reviewed by Dean Jackson.
+
+ Add a test that ensures that setting an inheritable style on the <video> does not affect
+ time labels within the shadow root.
+
+ * media/modern-media-controls/time-label/time-label-inherited-text-indent-expected.txt: Added.
+ * media/modern-media-controls/time-label/time-label-inherited-text-indent.html: Added.
+
2017-06-21 Joseph Pecoraro <[email protected]>
Web Inspector: Using "break on all exceptions" when throwing stack overflow hangs inspector
Added: trunk/LayoutTests/media/modern-media-controls/time-label/time-label-inherited-text-indent-expected.txt (0 => 218655)
--- trunk/LayoutTests/media/modern-media-controls/time-label/time-label-inherited-text-indent-expected.txt (rev 0)
+++ trunk/LayoutTests/media/modern-media-controls/time-label/time-label-inherited-text-indent-expected.txt 2017-06-21 21:55:27 UTC (rev 218655)
@@ -0,0 +1,11 @@
+Testing that the text-indent property set on the host does not affect time labels.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS !!shadowRoot.querySelector('.time-label') became true
+PASS getComputedStyle(shadowRoot.querySelector('.time-label')).textIndent is "0px"
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/media/modern-media-controls/time-label/time-label-inherited-text-indent.html (0 => 218655)
--- trunk/LayoutTests/media/modern-media-controls/time-label/time-label-inherited-text-indent.html (rev 0)
+++ trunk/LayoutTests/media/modern-media-controls/time-label/time-label-inherited-text-indent.html 2017-06-21 21:55:27 UTC (rev 218655)
@@ -0,0 +1,22 @@
+<!DOCTYPE html>
+<script src=""
+<script src="" type="text/_javascript_"></script>
+<body>
+<video src="" style="width: 320px; height: 240px; text-indent: 100px;" controls autoplay></video>
+<script type="text/_javascript_">
+
+window.jsTestIsAsync = true;
+
+description("Testing that the text-indent property set on the host does not affect time labels.");
+
+const media = document.querySelector("video");
+const shadowRoot = window.internals.shadowRoot(media);
+
+shouldBecomeEqual("!!shadowRoot.querySelector('.time-label')", "true", () => {
+ shouldBeEqualToString("getComputedStyle(shadowRoot.querySelector('.time-label')).textIndent", "0px");
+ finishJSTest();
+});
+
+</script>
+<script src=""
+</body>
Modified: trunk/Source/WebCore/ChangeLog (218654 => 218655)
--- trunk/Source/WebCore/ChangeLog 2017-06-21 21:50:42 UTC (rev 218654)
+++ trunk/Source/WebCore/ChangeLog 2017-06-21 21:55:27 UTC (rev 218655)
@@ -1,3 +1,18 @@
+2017-06-21 Antoine Quint <[email protected]>
+
+ CSS text properties affect <video> shadow root
+ https://bugs.webkit.org/show_bug.cgi?id=173664
+ <rdar://problem/32904328>
+
+ Reviewed by Dean Jackson.
+
+ Ensure that we reset all inheritable styles back to their initial value for media shadow roots.
+
+ Test: media/modern-media-controls/time-label/time-label-inherited-text-indent.html
+
+ * Modules/modern-media-controls/controls/media-controls.css:
+ (.media-controls-container):
+
2017-06-20 Simon Fraser <[email protected]>
Remove WILL_REVEAL_EDGE_EVENTS code
Modified: trunk/Source/WebCore/Modules/modern-media-controls/controls/media-controls.css (218654 => 218655)
--- trunk/Source/WebCore/Modules/modern-media-controls/controls/media-controls.css 2017-06-21 21:50:42 UTC (rev 218654)
+++ trunk/Source/WebCore/Modules/modern-media-controls/controls/media-controls.css 2017-06-21 21:55:27 UTC (rev 218655)
@@ -51,6 +51,8 @@
/* We need to use relative positioning due to webkit.org/b/163603 */
.media-controls-container {
+ all: initial;
+ display: block;
position: relative;
will-change: z-index;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
