- Revision
- 218665
- Author
- [email protected]
- Date
- 2017-06-21 17:27:51 -0700 (Wed, 21 Jun 2017)
Log Message
Change FrameLoadRequest from a struct to a class
FrameLoadRequest is underutilizing the purpose of a struct - default visibility of
members is public, as FrameLoadRequest explicitly groups its members under public:
or private: sections. Maybe in the future we can make FrameLoadRequest a struct
with only public members. For now, we should consider FrameLoadRequest a class.
* loader/FormSubmission.h:
* loader/FrameLoadRequest.h:
* loader/FrameLoader.h:
* page/Chrome.h:
* page/ChromeClient.h:
* replay/UserInputBridge.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (218664 => 218665)
--- trunk/Source/WebCore/ChangeLog 2017-06-22 00:25:06 UTC (rev 218664)
+++ trunk/Source/WebCore/ChangeLog 2017-06-22 00:27:51 UTC (rev 218665)
@@ -1,3 +1,19 @@
+2017-06-21 Daniel Bates <[email protected]>
+
+ Change FrameLoadRequest from a struct to a class
+
+ FrameLoadRequest is underutilizing the purpose of a struct - default visibility of
+ members is public, as FrameLoadRequest explicitly groups its members under public:
+ or private: sections. Maybe in the future we can make FrameLoadRequest a struct
+ with only public members. For now, we should consider FrameLoadRequest a class.
+
+ * loader/FormSubmission.h:
+ * loader/FrameLoadRequest.h:
+ * loader/FrameLoader.h:
+ * page/Chrome.h:
+ * page/ChromeClient.h:
+ * replay/UserInputBridge.h:
+
2017-06-21 Daewoong Jang <[email protected]>
Compiler error while building with !HAVE(ACCESSIBILITY)
Modified: trunk/Source/WebCore/loader/FormSubmission.h (218664 => 218665)
--- trunk/Source/WebCore/loader/FormSubmission.h 2017-06-22 00:25:06 UTC (rev 218664)
+++ trunk/Source/WebCore/loader/FormSubmission.h 2017-06-22 00:27:51 UTC (rev 218665)
@@ -38,9 +38,8 @@
class Event;
class FormData;
+class FrameLoadRequest;
-struct FrameLoadRequest;
-
class FormSubmission : public RefCounted<FormSubmission> {
public:
enum class Method { Get, Post };
Modified: trunk/Source/WebCore/loader/FrameLoadRequest.h (218664 => 218665)
--- trunk/Source/WebCore/loader/FrameLoadRequest.h 2017-06-22 00:25:06 UTC (rev 218664)
+++ trunk/Source/WebCore/loader/FrameLoadRequest.h 2017-06-22 00:27:51 UTC (rev 218665)
@@ -31,9 +31,10 @@
#include "SubstituteData.h"
namespace WebCore {
+
class Frame;
-struct FrameLoadRequest {
+class FrameLoadRequest {
public:
FrameLoadRequest(SecurityOrigin& requester, const ResourceRequest& resourceRequest, const String& frameName, LockHistory lockHistory, LockBackForwardList lockBackForwardList, ShouldSendReferrer shouldSendReferrer, AllowNavigationToInvalidURL allowNavigationToInvalidURL, NewFrameOpenerPolicy newFrameOpenerPolicy, ShouldOpenExternalURLsPolicy shouldOpenExternalURLsPolicy, ShouldReplaceDocumentIfJavaScriptURL shouldReplaceDocumentIfJavaScriptURL = ReplaceDocumentIfJavaScriptURL, const AtomicString& downloadAttribute = { })
: m_requester { makeRef(requester) }
Modified: trunk/Source/WebCore/loader/FrameLoader.h (218664 => 218665)
--- trunk/Source/WebCore/loader/FrameLoader.h 2017-06-22 00:25:06 UTC (rev 218664)
+++ trunk/Source/WebCore/loader/FrameLoader.h 2017-06-22 00:27:51 UTC (rev 218665)
@@ -61,6 +61,7 @@
class Event;
class FormState;
class FormSubmission;
+class FrameLoadRequest;
class FrameLoaderClient;
class FrameNetworkingContext;
class HistoryController;
@@ -78,7 +79,6 @@
class SubframeLoader;
class SubstituteData;
-struct FrameLoadRequest;
struct WindowFeatures;
WEBCORE_EXPORT bool isBackForwardLoadType(FrameLoadType);
Modified: trunk/Source/WebCore/page/Chrome.h (218664 => 218665)
--- trunk/Source/WebCore/page/Chrome.h 2017-06-22 00:25:06 UTC (rev 218664)
+++ trunk/Source/WebCore/page/Chrome.h 2017-06-22 00:27:51 UTC (rev 218665)
@@ -41,6 +41,7 @@
class FileChooser;
class FileIconLoader;
class FloatRect;
+class FrameLoadRequest;
class Element;
class Frame;
class Geolocation;
@@ -55,7 +56,6 @@
class SearchPopupMenu;
struct DateTimeChooserParameters;
-struct FrameLoadRequest;
struct ViewportArguments;
struct WindowFeatures;
Modified: trunk/Source/WebCore/page/ChromeClient.h (218664 => 218665)
--- trunk/Source/WebCore/page/ChromeClient.h 2017-06-22 00:25:06 UTC (rev 218664)
+++ trunk/Source/WebCore/page/ChromeClient.h 2017-06-22 00:27:51 UTC (rev 218665)
@@ -74,6 +74,7 @@
class FileIconLoader;
class FloatRect;
class Frame;
+class FrameLoadRequest;
class Geolocation;
class GraphicsLayer;
class GraphicsLayerFactory;
@@ -96,7 +97,6 @@
#endif
struct DateTimeChooserParameters;
-struct FrameLoadRequest;
struct GraphicsDeviceAdapter;
struct ViewportArguments;
struct WindowFeatures;
Modified: trunk/Source/WebCore/replay/UserInputBridge.h (218664 => 218665)
--- trunk/Source/WebCore/replay/UserInputBridge.h 2017-06-22 00:25:06 UTC (rev 218664)
+++ trunk/Source/WebCore/replay/UserInputBridge.h 2017-06-22 00:27:51 UTC (rev 218665)
@@ -38,9 +38,8 @@
namespace WebCore {
-struct FrameLoadRequest;
-
class Frame;
+class FrameLoadRequest;
class Page;
class PlatformKeyboardEvent;
class PlatformMouseEvent;
