Title: [218675] trunk/Source/WebCore
- Revision
- 218675
- Author
- [email protected]
- Date
- 2017-06-21 19:24:09 -0700 (Wed, 21 Jun 2017)
Log Message
Add z-index to compositing logging output
https://bugs.webkit.org/show_bug.cgi?id=173684
Reviewed by Zalan Bujtas.
Show z-index, which is often useful to find negative z-index items.
Log "+foreground" rather than "foreground" to indicate that this layer has an
additional foreground/background layer, and fix spacing.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::logLayerInfo):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (218674 => 218675)
--- trunk/Source/WebCore/ChangeLog 2017-06-22 02:22:12 UTC (rev 218674)
+++ trunk/Source/WebCore/ChangeLog 2017-06-22 02:24:09 UTC (rev 218675)
@@ -1,3 +1,18 @@
+2017-06-21 Simon Fraser <[email protected]>
+
+ Add z-index to compositing logging output
+ https://bugs.webkit.org/show_bug.cgi?id=173684
+
+ Reviewed by Zalan Bujtas.
+
+ Show z-index, which is often useful to find negative z-index items.
+
+ Log "+foreground" rather than "foreground" to indicate that this layer has an
+ additional foreground/background layer, and fix spacing.
+
+ * rendering/RenderLayerCompositor.cpp:
+ (WebCore::RenderLayerCompositor::logLayerInfo):
+
2017-06-21 Chris Dumez <[email protected]>
Unreviewed, fix Window Debug build after r218660.
Modified: trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp (218674 => 218675)
--- trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2017-06-22 02:22:12 UTC (rev 218674)
+++ trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2017-06-22 02:24:09 UTC (rev 218675)
@@ -814,6 +814,9 @@
absoluteBounds.x().toFloat(), absoluteBounds.y().toFloat(), absoluteBounds.maxX().toFloat(), absoluteBounds.maxY().toFloat(),
backing->backingStoreMemoryEstimate() / 1024));
+ if (!layer.renderer().style().hasAutoZIndex())
+ logString.append(String::format(" z-index: %d", layer.renderer().style().zIndex()));
+
logString.appendLiteral(" (");
logString.append(logReasonsForCompositing(layer));
logString.appendLiteral(") ");
@@ -836,12 +839,16 @@
if (backing->foregroundLayer() || backing->backgroundLayer()) {
if (prependSpace)
logString.appendLiteral(", ");
- if (backing->foregroundLayer() && backing->backgroundLayer())
- logString.appendLiteral("foreground+background");
- else if (backing->foregroundLayer())
- logString.appendLiteral("foreground");
- else
- logString.appendLiteral("background");
+ if (backing->foregroundLayer() && backing->backgroundLayer()) {
+ logString.appendLiteral("+foreground+background");
+ prependSpace = true;
+ } else if (backing->foregroundLayer()) {
+ logString.appendLiteral("+foreground");
+ prependSpace = true;
+ } else {
+ logString.appendLiteral("+background");
+ prependSpace = true;
+ }
}
if (backing->paintsSubpixelAntialiasedText()) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
