Title: [218688] trunk/Source/WebKit2
- Revision
- 218688
- Author
- [email protected]
- Date
- 2017-06-22 04:16:54 -0700 (Thu, 22 Jun 2017)
Log Message
[WPE] Page should be closed on WebKitWebView dispose
https://bugs.webkit.org/show_bug.cgi?id=173707
Reviewed by Žan Doberšek.
In the GTK+ port it's done in the WebKitWebViewBase dispose implementation. It fixes TestMultiprocess.
* UIProcess/API/glib/WebKitWebView.cpp:
(webkitWebViewDispose): Call WKWPE::View::close().
* UIProcess/API/wpe/WPEView.cpp:
(WKWPE::View::close): Close the WebPageProxy.
* UIProcess/API/wpe/WPEView.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (218687 => 218688)
--- trunk/Source/WebKit2/ChangeLog 2017-06-22 11:15:14 UTC (rev 218687)
+++ trunk/Source/WebKit2/ChangeLog 2017-06-22 11:16:54 UTC (rev 218688)
@@ -1,5 +1,20 @@
2017-06-22 Carlos Garcia Campos <[email protected]>
+ [WPE] Page should be closed on WebKitWebView dispose
+ https://bugs.webkit.org/show_bug.cgi?id=173707
+
+ Reviewed by Žan Doberšek.
+
+ In the GTK+ port it's done in the WebKitWebViewBase dispose implementation. It fixes TestMultiprocess.
+
+ * UIProcess/API/glib/WebKitWebView.cpp:
+ (webkitWebViewDispose): Call WKWPE::View::close().
+ * UIProcess/API/wpe/WPEView.cpp:
+ (WKWPE::View::close): Close the WebPageProxy.
+ * UIProcess/API/wpe/WPEView.h:
+
+2017-06-22 Carlos Garcia Campos <[email protected]>
+
Remove unused coordinated graphics C API
https://bugs.webkit.org/show_bug.cgi?id=173706
Modified: trunk/Source/WebKit2/UIProcess/API/glib/WebKitWebView.cpp (218687 => 218688)
--- trunk/Source/WebKit2/UIProcess/API/glib/WebKitWebView.cpp 2017-06-22 11:15:14 UTC (rev 218687)
+++ trunk/Source/WebKit2/UIProcess/API/glib/WebKitWebView.cpp 2017-06-22 11:16:54 UTC (rev 218688)
@@ -736,6 +736,10 @@
webView->priv->websiteDataManager = nullptr;
}
+#if PLATFORM(WPE)
+ webView->priv->view->close();
+#endif
+
G_OBJECT_CLASS(webkit_web_view_parent_class)->dispose(object);
}
Modified: trunk/Source/WebKit2/UIProcess/API/wpe/WPEView.cpp (218687 => 218688)
--- trunk/Source/WebKit2/UIProcess/API/wpe/WPEView.cpp 2017-06-22 11:15:14 UTC (rev 218687)
+++ trunk/Source/WebKit2/UIProcess/API/wpe/WPEView.cpp 2017-06-22 11:16:54 UTC (rev 218688)
@@ -158,4 +158,9 @@
m_pageProxy->activityStateDidChange(changedFlags);
}
+void View::close()
+{
+ m_pageProxy->close();
+}
+
} // namespace WKWPE
Modified: trunk/Source/WebKit2/UIProcess/API/wpe/WPEView.h (218687 => 218688)
--- trunk/Source/WebKit2/UIProcess/API/wpe/WPEView.h 2017-06-22 11:15:14 UTC (rev 218687)
+++ trunk/Source/WebKit2/UIProcess/API/wpe/WPEView.h 2017-06-22 11:16:54 UTC (rev 218688)
@@ -64,6 +64,8 @@
WebCore::ActivityState::Flags viewState() const { return m_viewStateFlags; }
void setViewState(WebCore::ActivityState::Flags);
+ void close();
+
private:
View(struct wpe_view_backend*, const API::PageConfiguration&);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
