Title: [99780] trunk/Source/WebCore
- Revision
- 99780
- Author
- [email protected]
- Date
- 2011-11-09 16:11:52 -0800 (Wed, 09 Nov 2011)
Log Message
Remove WebGLContextEvent.initEvent method
https://bugs.webkit.org/show_bug.cgi?id=71720
Reviewed by Adam Barth.
The WebGL spec calls this method initWebGLContextEvent, but it may
adopt a constructor instead. Deleting the initEvent method for now
since it is definitely wrong and we don't want people to come to
depend on it.
No new tests--removing untested code.
* html/canvas/WebGLContextEvent.cpp:
* html/canvas/WebGLContextEvent.h:
* html/canvas/WebGLContextEvent.idl:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (99779 => 99780)
--- trunk/Source/WebCore/ChangeLog 2011-11-10 00:04:40 UTC (rev 99779)
+++ trunk/Source/WebCore/ChangeLog 2011-11-10 00:11:52 UTC (rev 99780)
@@ -1,3 +1,21 @@
+2011-11-09 Dominic Cooney <[email protected]>
+
+ Remove WebGLContextEvent.initEvent method
+ https://bugs.webkit.org/show_bug.cgi?id=71720
+
+ Reviewed by Adam Barth.
+
+ The WebGL spec calls this method initWebGLContextEvent, but it may
+ adopt a constructor instead. Deleting the initEvent method for now
+ since it is definitely wrong and we don't want people to come to
+ depend on it.
+
+ No new tests--removing untested code.
+
+ * html/canvas/WebGLContextEvent.cpp:
+ * html/canvas/WebGLContextEvent.h:
+ * html/canvas/WebGLContextEvent.idl:
+
2011-11-09 Anders Carlsson <[email protected]>
Element::boundsInWindowSpace should be Element::boundsInRootViewSpace
Modified: trunk/Source/WebCore/html/canvas/WebGLContextEvent.cpp (99779 => 99780)
--- trunk/Source/WebCore/html/canvas/WebGLContextEvent.cpp 2011-11-10 00:04:40 UTC (rev 99779)
+++ trunk/Source/WebCore/html/canvas/WebGLContextEvent.cpp 2011-11-10 00:11:52 UTC (rev 99780)
@@ -44,15 +44,6 @@
{
}
-void WebGLContextEvent::initEvent(const AtomicString& type, bool canBubble, bool cancelable, const String& statusMessage)
-{
- if (dispatched())
- return;
-
- Event::initEvent(type, canBubble, cancelable);
- m_statusMessage = statusMessage;
-}
-
const AtomicString& WebGLContextEvent::interfaceName() const
{
return eventNames().interfaceForWebGLContextEvent;
Modified: trunk/Source/WebCore/html/canvas/WebGLContextEvent.h (99779 => 99780)
--- trunk/Source/WebCore/html/canvas/WebGLContextEvent.h 2011-11-10 00:04:40 UTC (rev 99779)
+++ trunk/Source/WebCore/html/canvas/WebGLContextEvent.h 2011-11-10 00:11:52 UTC (rev 99780)
@@ -42,8 +42,6 @@
}
virtual ~WebGLContextEvent();
- void initEvent(const AtomicString& type, bool canBubble, bool cancelable, const String& statusMessage);
-
const String& statusMessage() const { return m_statusMessage; }
virtual const AtomicString& interfaceName() const;
Modified: trunk/Source/WebCore/html/canvas/WebGLContextEvent.idl (99779 => 99780)
--- trunk/Source/WebCore/html/canvas/WebGLContextEvent.idl 2011-11-10 00:04:40 UTC (rev 99779)
+++ trunk/Source/WebCore/html/canvas/WebGLContextEvent.idl 2011-11-10 00:11:52 UTC (rev 99780)
@@ -28,9 +28,5 @@
Conditional=WEBGL,
] WebGLContextEvent : Event {
readonly attribute DOMString statusMessage;
- [StrictTypeChecking] void initEvent(in [Optional=CallWithDefaultValue] DOMString eventTypeArg,
- in [Optional=CallWithDefaultValue] boolean canBubbleArg,
- in [Optional=CallWithDefaultValue] boolean cancelableArg,
- in [Optional=CallWithDefaultValue] DOMString statusMessageArg);
};
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
