Title: [218710] trunk/Source/WebCore
- Revision
- 218710
- Author
- [email protected]
- Date
- 2017-06-22 11:56:15 -0700 (Thu, 22 Jun 2017)
Log Message
REGRESSION (r217223): [iOS] Video keeps playing after application is backgrounded
https://bugs.webkit.org/show_bug.cgi?id=173727
Reviewed by Eric Carlson.
Only override media element visibility if it is in picture-in-picture mode (not fullscreen generally).
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::visibilityStateChanged):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (218709 => 218710)
--- trunk/Source/WebCore/ChangeLog 2017-06-22 18:39:53 UTC (rev 218709)
+++ trunk/Source/WebCore/ChangeLog 2017-06-22 18:56:15 UTC (rev 218710)
@@ -1,3 +1,15 @@
+2017-06-22 Jer Noble <[email protected]>
+
+ REGRESSION (r217223): [iOS] Video keeps playing after application is backgrounded
+ https://bugs.webkit.org/show_bug.cgi?id=173727
+
+ Reviewed by Eric Carlson.
+
+ Only override media element visibility if it is in picture-in-picture mode (not fullscreen generally).
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::visibilityStateChanged):
+
2017-06-22 Joseph Pecoraro <[email protected]>
Follow-up to r218662. Only log backtraces for DumpRenderTree.
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (218709 => 218710)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2017-06-22 18:39:53 UTC (rev 218709)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2017-06-22 18:56:15 UTC (rev 218710)
@@ -5339,7 +5339,7 @@
void HTMLMediaElement::visibilityStateChanged()
{
- m_elementIsHidden = document().hidden() && m_videoFullscreenMode == VideoFullscreenModeNone;
+ m_elementIsHidden = document().hidden() && m_videoFullscreenMode != VideoFullscreenModePictureInPicture;
LOG(Media, "HTMLMediaElement::visibilityStateChanged(%p) - visible = %s", this, boolString(!m_elementIsHidden));
updateSleepDisabling();
m_mediaSession->visibilityChanged();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
