Title: [218725] trunk/LayoutTests
- Revision
- 218725
- Author
- [email protected]
- Date
- 2017-06-22 15:47:00 -0700 (Thu, 22 Jun 2017)
Log Message
REGRESSION: LayoutTest media/modern-media-controls/placard-support/placard-support-pip.html is a flaky timeout on Sierra
https://bugs.webkit.org/show_bug.cgi?id=173725
Patch by Antoine Quint <[email protected]> on 2017-06-22
Reviewed by Dean Jackson.
On WK1, this test enters fullscreen rather than PiP (which is unexpected, see webkit.org/b/173729) and thus the button
to exit PiP could not be clicked. But we don't need a button click to exit PiP, so instead we just call a method to
toggle it.
* media/modern-media-controls/placard-support/placard-support-pip.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (218724 => 218725)
--- trunk/LayoutTests/ChangeLog 2017-06-22 22:24:05 UTC (rev 218724)
+++ trunk/LayoutTests/ChangeLog 2017-06-22 22:47:00 UTC (rev 218725)
@@ -1,3 +1,16 @@
+2017-06-22 Antoine Quint <[email protected]>
+
+ REGRESSION: LayoutTest media/modern-media-controls/placard-support/placard-support-pip.html is a flaky timeout on Sierra
+ https://bugs.webkit.org/show_bug.cgi?id=173725
+
+ Reviewed by Dean Jackson.
+
+ On WK1, this test enters fullscreen rather than PiP (which is unexpected, see webkit.org/b/173729) and thus the button
+ to exit PiP could not be clicked. But we don't need a button click to exit PiP, so instead we just call a method to
+ toggle it.
+
+ * media/modern-media-controls/placard-support/placard-support-pip.html:
+
2017-06-22 Ryan Haddad <[email protected]>
Mark perf/object-keys.html as flaky on iOS.
Modified: trunk/LayoutTests/media/modern-media-controls/placard-support/placard-support-pip.html (218724 => 218725)
--- trunk/LayoutTests/media/modern-media-controls/placard-support/placard-support-pip.html 2017-06-22 22:24:05 UTC (rev 218724)
+++ trunk/LayoutTests/media/modern-media-controls/placard-support/placard-support-pip.html 2017-06-22 22:47:00 UTC (rev 218725)
@@ -35,15 +35,13 @@
const button = document.body.appendChild(document.createElement("div"));
button.innerText = "Enter picture-in-picture";
-button.addEventListener("click", () => {
- media.webkitSetPresentationMode(media.webkitPresentationMode == "inline" ? "picture-in-picture" : "inline");
-});
+button.addEventListener("click", togglePiP);
media.addEventListener("webkitpresentationmodechanged", () => {
if (media.webkitPresentationMode == "picture-in-picture") {
shouldBe("mediaController.controls.placard", "mediaController.controls.pipPlacard");
shouldBeTrue("mediaController.controls.children.includes(mediaController.controls.pipPlacard)");
- clickButton();
+ togglePiP();
} else {
shouldBeNull("mediaController.controls.placard");
shouldBeFalse("mediaController.controls.children.includes(mediaController.controls.pipPlacard)");
@@ -60,6 +58,11 @@
pressOnElement(button);
}
+function togglePiP()
+{
+ media.webkitSetPresentationMode(media.webkitPresentationMode == "inline" ? "picture-in-picture" : "inline");
+}
+
</script>
<script src=""
</body>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
