Title: [218738] trunk/Tools
- Revision
- 218738
- Author
- [email protected]
- Date
- 2017-06-23 01:21:52 -0700 (Fri, 23 Jun 2017)
Log Message
Unreviewed. Fix WPE /wpe/WebKitWebView/_javascript_-dialogs and /wpe/WebKitWebView/window-properties
Skip onbeforeunload dialog tests for now in WPE since we don't have a implemention for
simulateUserInteraction(). And do not expect changes in "geometry" property of WebKitWindowProperties that
doesn't exist yet in WPE.
* TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
(testWebViewJavaScriptDialogs):
(testWebViewWindowProperties):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (218737 => 218738)
--- trunk/Tools/ChangeLog 2017-06-23 05:40:47 UTC (rev 218737)
+++ trunk/Tools/ChangeLog 2017-06-23 08:21:52 UTC (rev 218738)
@@ -1,3 +1,15 @@
+2017-06-23 Carlos Garcia Campos <[email protected]>
+
+ Unreviewed. Fix WPE /wpe/WebKitWebView/_javascript_-dialogs and /wpe/WebKitWebView/window-properties
+
+ Skip onbeforeunload dialog tests for now in WPE since we don't have a implemention for
+ simulateUserInteraction(). And do not expect changes in "geometry" property of WebKitWindowProperties that
+ doesn't exist yet in WPE.
+
+ * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
+ (testWebViewJavaScriptDialogs):
+ (testWebViewWindowProperties):
+
2017-06-22 Carlos Garcia Campos <[email protected]>
[GTK] Upgrade pixman and cairo in jhbuild
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp (218737 => 218738)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp 2017-06-23 05:40:47 UTC (rev 218737)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp 2017-06-23 08:21:52 UTC (rev 218738)
@@ -580,6 +580,8 @@
webkit_web_view_stop_loading(test->m_webView);
test->waitUntilLoadFinished();
+ // FIXME: implement simulateUserInteraction in WPE.
+#if PLATFORM(GTK)
test->m_scriptDialogType = WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM;
GUniquePtr<char> beforeUnloadDialogHTML(g_strdup_printf(htmlOnBeforeUnloadFormat, kBeforeUnloadConfirmDialogMessage));
test->loadHtml(beforeUnloadDialogHTML.get(), nullptr);
@@ -621,6 +623,7 @@
test->m_scriptDialogConfirmed = false;
test->tryCloseAndWaitUntilClosed();
g_assert(!test->m_scriptDialogConfirmed);
+#endif // PLATFORM(GTK)
}
static void testWebViewWindowProperties(UIClientTest* test, gconstpointer)
@@ -634,7 +637,10 @@
test->waitUntilMainLoopFinishes();
static const char* propertiesChanged[] = {
- "geometry", "locationbar-visible", "menubar-visible", "statusbar-visible", "toolbar-visible", "scrollbars-visible"
+#if PLATFORM(GTK)
+ "geometry",
+#endif
+ "locationbar-visible", "menubar-visible", "statusbar-visible", "toolbar-visible", "scrollbars-visible"
};
for (size_t i = 0; i < G_N_ELEMENTS(propertiesChanged); ++i)
g_assert(test->m_windowPropertiesChanged.contains(propertiesChanged[i]));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
