Title: [99788] trunk/Source/_javascript_Core
- Revision
- 99788
- Author
- [email protected]
- Date
- 2011-11-09 17:10:40 -0800 (Wed, 09 Nov 2011)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=71873
Reviewed by Geoff Garen.
Incrementally re-landing these changes, trying to determine what went wrong.
(The whole patch failed tests on the build bot but worked locally.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleIntrinsic):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (99787 => 99788)
--- trunk/Source/_javascript_Core/ChangeLog 2011-11-10 01:08:50 UTC (rev 99787)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-11-10 01:10:40 UTC (rev 99788)
@@ -1,3 +1,15 @@
+2011-11-09 Gavin Barraclough <[email protected]>
+
+ https://bugs.webkit.org/show_bug.cgi?id=71873
+
+ Reviewed by Geoff Garen.
+
+ Incrementally re-landing these changes, trying to determine what went wrong.
+ (The whole patch failed tests on the build bot but worked locally.
+
+ * dfg/DFGByteCodeParser.cpp:
+ (JSC::DFG::ByteCodeParser::handleIntrinsic):
+
2011-11-09 Filip Pizlo <[email protected]>
DFG OSR exit code should be lazily generated
Modified: trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp (99787 => 99788)
--- trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp 2011-11-10 01:08:50 UTC (rev 99787)
+++ trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp 2011-11-10 01:10:40 UTC (rev 99788)
@@ -1141,10 +1141,15 @@
// We don't care about the this argument. If we don't have a first
// argument then make this JSConstant(NaN).
int absArg = firstArg + 1;
- if (absArg > lastArg)
+ if (absArg > lastArg) {
set(resultOperand, constantNaN());
- else
- set(resultOperand, addToGraph(ArithAbs, OpInfo(NodeUseBottom), getToNumber(absArg)));
+ return true;
+ }
+
+ if (!MacroAssembler::supportsFloatingPointAbs())
+ return false;
+
+ set(resultOperand, addToGraph(ArithAbs, OpInfo(NodeUseBottom), getToNumber(absArg)));
return true;
}
@@ -1163,6 +1168,9 @@
return true;
}
+ if (!MacroAssembler::supportsFloatingPointSqrt())
+ return false;
+
set(resultOperand, addToGraph(ArithSqrt, getToNumber(firstArg + 1)));
return true;
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
