Title: [218762] trunk/LayoutTests
- Revision
- 218762
- Author
- [email protected]
- Date
- 2017-06-23 13:50:26 -0700 (Fri, 23 Jun 2017)
Log Message
Remove fast/regions/region-leak-js-information-when-disabled-at-runtime.html
https://bugs.webkit.org/show_bug.cgi?id=173784
Patch by Frederic Wang <[email protected]> on 2017-06-23
Reviewed by Simon Fraser.
fast/regions/region-leak-js-information-when-disabled-at-runtime.html is supposed to test
that some JS properties are undefined when CSS regions are disabled at runtime. However, this
part is currently commented out and the test is no longer relevant after r200524. Hence we
just remove it.
* fast/regions/region-leak-js-information-when-disabled-at-runtime-expected.txt: Removed.
* fast/regions/region-leak-js-information-when-disabled-at-runtime.html: Removed.
Modified Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (218761 => 218762)
--- trunk/LayoutTests/ChangeLog 2017-06-23 20:49:34 UTC (rev 218761)
+++ trunk/LayoutTests/ChangeLog 2017-06-23 20:50:26 UTC (rev 218762)
@@ -1,5 +1,20 @@
2017-06-23 Frederic Wang <[email protected]>
+ Remove fast/regions/region-leak-js-information-when-disabled-at-runtime.html
+ https://bugs.webkit.org/show_bug.cgi?id=173784
+
+ Reviewed by Simon Fraser.
+
+ fast/regions/region-leak-js-information-when-disabled-at-runtime.html is supposed to test
+ that some JS properties are undefined when CSS regions are disabled at runtime. However, this
+ part is currently commented out and the test is no longer relevant after r200524. Hence we
+ just remove it.
+
+ * fast/regions/region-leak-js-information-when-disabled-at-runtime-expected.txt: Removed.
+ * fast/regions/region-leak-js-information-when-disabled-at-runtime.html: Removed.
+
+2017-06-23 Frederic Wang <[email protected]>
+
Use window.internals instead of overridePreference to set WebCore settings in tests
https://bugs.webkit.org/show_bug.cgi?id=173714
Deleted: trunk/LayoutTests/fast/regions/region-leak-js-information-when-disabled-at-runtime-expected.txt (218761 => 218762)
--- trunk/LayoutTests/fast/regions/region-leak-js-information-when-disabled-at-runtime-expected.txt 2017-06-23 20:49:34 UTC (rev 218761)
+++ trunk/LayoutTests/fast/regions/region-leak-js-information-when-disabled-at-runtime-expected.txt 2017-06-23 20:50:26 UTC (rev 218762)
@@ -1,13 +0,0 @@
-Test for 94070 [CSSRegions] broken feature detection: syntax parsing succeeds when CSS REGIONS is disabled at runtime
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS typeof(document.webkitGetNamedFlows) is "function"
-PASS typeof(document.body.webkitRegionOverset) is "string"
-PASS typeof(document.body.webkitGetRegionFlowRanges) is "function"
-PASS window.WebKitCSSRegionRule is defined.
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
Deleted: trunk/LayoutTests/fast/regions/region-leak-js-information-when-disabled-at-runtime.html (218761 => 218762)
--- trunk/LayoutTests/fast/regions/region-leak-js-information-when-disabled-at-runtime.html 2017-06-23 20:49:34 UTC (rev 218761)
+++ trunk/LayoutTests/fast/regions/region-leak-js-information-when-disabled-at-runtime.html 2017-06-23 20:50:26 UTC (rev 218762)
@@ -1,41 +0,0 @@
-<!doctype html>
-<html>
- <!--
- The bug is that the CSS Regions feature leaks information at run-time. There are JS properties that exist even
- if the feature is disabled at run-time (document.webkitGetNamedFlows, document.body.webkitRegionOverset,
- document.body.webkitGetRegionFlowRanges and window.WebKitCSSRegionRule).
- The best LayoutTest would test that the properties exist when the feature is enabled and that the properties
- just aren't there when the feature is disabled.
- But, since during running Layout Tests the feature is enabled by default and switching the
- RuntimeEnabledFeatures requires the process to be restarted and that is currently not possible, we can only test
- that the properties exist and have the proper type.
- On success, you should see a series of PASS messages.
- -->
- <head>
- <script src=""
- </head>
- <body>
- <script>
-
- description("<p>Test for <a href="" [CSSRegions] broken feature detection: syntax parsing succeeds when CSS REGIONS is disabled at runtime</a></p>");
-
- shouldBeEqualToString( "typeof(document.webkitGetNamedFlows)", "function" );
- shouldBeEqualToString( "typeof(document.body.webkitRegionOverset)", "string" );
- shouldBeEqualToString( "typeof(document.body.webkitGetRegionFlowRanges)", "function" );
- shouldBeDefined( "window.WebKitCSSRegionRule" );
-
-/*
- // FIXME: uncomment the following code when switching a RuntimeEnabledFeatures flag doesn't require the browser
- // process to be restarted.
- if(window.testRunner)
- window.testRunner.overridePreference("WebKitCSSRegionsEnabled", false);
-
- shouldBeFalse( "'webkitGetNamedFlows' in document" );
- shouldBeFalse( "document.body.hasOwnProperty( 'webkitRegionOverset' )" );
- shouldBeFalse( "'webkitGetRegionFlowRanges' in document.body" );
- shouldBeUndefined( "window.WebKitCSSRegionRule" );
-*/
- </script>
- <script src=""
- </body>
-</html>
\ No newline at end of file
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
