Title: [218787] trunk/Source/WebKit2
- Revision
- 218787
- Author
- [email protected]
- Date
- 2017-06-24 08:14:40 -0700 (Sat, 24 Jun 2017)
Log Message
[GTK] Introspection: webkit_web_view_new_with_related_view needs to be marked as a constructor
https://bugs.webkit.org/show_bug.cgi?id=173765
Reviewed by Carlos Garcia Campos.
Because the first parameter to this WebKitWebView constructor is itself a WebKitWebView,
the gi-scanner's heuristics decide that it's probably an object method rather than a
constructor, resulting in improper introspection generation. Annotate it with (constructor)
to override this behavior.
* UIProcess/API/gtk/WebKitWebViewGtk.cpp:
* UIProcess/API/wpe/WebKitWebViewWPE.cpp:
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (218786 => 218787)
--- trunk/Source/WebKit2/ChangeLog 2017-06-24 10:24:33 UTC (rev 218786)
+++ trunk/Source/WebKit2/ChangeLog 2017-06-24 15:14:40 UTC (rev 218787)
@@ -1,3 +1,18 @@
+2017-06-24 Michael Catanzaro <[email protected]>
+
+ [GTK] Introspection: webkit_web_view_new_with_related_view needs to be marked as a constructor
+ https://bugs.webkit.org/show_bug.cgi?id=173765
+
+ Reviewed by Carlos Garcia Campos.
+
+ Because the first parameter to this WebKitWebView constructor is itself a WebKitWebView,
+ the gi-scanner's heuristics decide that it's probably an object method rather than a
+ constructor, resulting in improper introspection generation. Annotate it with (constructor)
+ to override this behavior.
+
+ * UIProcess/API/gtk/WebKitWebViewGtk.cpp:
+ * UIProcess/API/wpe/WebKitWebViewWPE.cpp:
+
2017-06-24 Commit Queue <[email protected]>
Unreviewed, rolling out r218785.
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewGtk.cpp (218786 => 218787)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewGtk.cpp 2017-06-24 10:24:33 UTC (rev 218786)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewGtk.cpp 2017-06-24 15:14:40 UTC (rev 218787)
@@ -189,7 +189,7 @@
}
/**
- * webkit_web_view_new_with_related_view:
+ * webkit_web_view_new_with_related_view: (constructor)
* @web_view: the related #WebKitWebView
*
* Creates a new #WebKitWebView sharing the same web process with @web_view.
Modified: trunk/Source/WebKit2/UIProcess/API/wpe/WebKitWebViewWPE.cpp (218786 => 218787)
--- trunk/Source/WebKit2/UIProcess/API/wpe/WebKitWebViewWPE.cpp 2017-06-24 10:24:33 UTC (rev 218786)
+++ trunk/Source/WebKit2/UIProcess/API/wpe/WebKitWebViewWPE.cpp 2017-06-24 15:14:40 UTC (rev 218787)
@@ -75,7 +75,7 @@
}
/**
- * webkit_web_view_new_with_related_view:
+ * webkit_web_view_new_with_related_view: (constructor)
* @web_view: the related #WebKitWebView
*
* Creates a new #WebKitWebView sharing the same web process with @web_view.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
