Diff
Modified: trunk/Source/WebCore/ChangeLog (218791 => 218792)
--- trunk/Source/WebCore/ChangeLog 2017-06-25 00:07:17 UTC (rev 218791)
+++ trunk/Source/WebCore/ChangeLog 2017-06-25 09:22:06 UTC (rev 218792)
@@ -1,3 +1,25 @@
+2017-06-25 Antoine Quint <[email protected]>
+
+ Remove rAf suspension logging
+ https://bugs.webkit.org/show_bug.cgi?id=173821
+
+ Reviewed by Tim Horton.
+
+ Now that webkit.org/b/173628 is fixed, we can remove the logging code we added.
+
+ * dom/Document.cpp:
+ (WebCore::Document::requestAnimationFrame):
+ * dom/ScriptedAnimationController.cpp:
+ (WebCore::ScriptedAnimationController::suspend):
+ (WebCore::ScriptedAnimationController::resume):
+ * page/Page.cpp:
+ (WebCore::Page::suspendScriptedAnimations):
+ (WebCore::Page::resumeScriptedAnimations):
+ (WebCore::Page::setIsVisibleInternal):
+ * platform/RuntimeApplicationChecks.h:
+ * platform/cocoa/RuntimeApplicationChecksCocoa.mm:
+ (WebCore::MacApplication::isDumpRenderTree): Deleted.
+
2017-06-24 Sam Weinig <[email protected]>
[WebIDL] Add complete support for stringifier
Modified: trunk/Source/WebCore/dom/Document.cpp (218791 => 218792)
--- trunk/Source/WebCore/dom/Document.cpp 2017-06-25 00:07:17 UTC (rev 218791)
+++ trunk/Source/WebCore/dom/Document.cpp 2017-06-25 09:22:06 UTC (rev 218792)
@@ -145,7 +145,6 @@
#include "RenderView.h"
#include "RenderWidget.h"
#include "RequestAnimationFrameCallback.h"
-#include "RuntimeApplicationChecks.h"
#include "RuntimeEnabledFeatures.h"
#include "SVGDocumentExtensions.h"
#include "SVGElement.h"
@@ -6237,15 +6236,6 @@
// It's possible that the Page may have suspended scripted animations before
// we were created. We need to make sure that we don't start up the animation
// controller on a background tab, for example.
-
-#if PLATFORM(MAC)
- if (MacApplication::isDumpRenderTree()) {
- WTFLogAlways("\nDocument::requestAnimationFrame called on %p, page = %p", this, page());
- if (page())
- WTFLogAlways("page()->scriptedAnimationsSuspended() = %s", page()->scriptedAnimationsSuspended() ? "true" : "false");
- }
-#endif
-
if (!page() || page()->scriptedAnimationsSuspended())
m_scriptedAnimationController->suspend();
Modified: trunk/Source/WebCore/dom/ScriptedAnimationController.cpp (218791 => 218792)
--- trunk/Source/WebCore/dom/ScriptedAnimationController.cpp 2017-06-25 00:07:17 UTC (rev 218791)
+++ trunk/Source/WebCore/dom/ScriptedAnimationController.cpp 2017-06-25 09:22:06 UTC (rev 218792)
@@ -39,7 +39,6 @@
#include "MainFrame.h"
#include "Page.h"
#include "RequestAnimationFrameCallback.h"
-#include "RuntimeApplicationChecks.h"
#include "Settings.h"
#include <algorithm>
#include <wtf/CurrentTime.h>
@@ -76,13 +75,6 @@
void ScriptedAnimationController::suspend()
{
++m_suspendCount;
-
-#if PLATFORM(MAC)
- if (MacApplication::isDumpRenderTree()) {
- WTFLogAlways("\nScriptedAnimationController::suspend() called on %p, m_suspendCount = %d, document = %p", this, m_suspendCount, &m_document);
- WTFReportBacktrace();
- }
-#endif
}
void ScriptedAnimationController::resume()
@@ -92,14 +84,6 @@
if (m_suspendCount > 0)
--m_suspendCount;
-#if PLATFORM(MAC)
- if (MacApplication::isDumpRenderTree()) {
- WTFLogAlways("\nScriptedAnimationController::resume() called on %p, m_suspendCount = %d, document = %p", this, m_suspendCount, &m_document);
- WTFLogAlways("Document = %p", &m_document);
- WTFReportBacktrace();
- }
-#endif
-
if (!m_suspendCount && m_callbacks.size())
scheduleAnimation();
}
Modified: trunk/Source/WebCore/page/Page.cpp (218791 => 218792)
--- trunk/Source/WebCore/page/Page.cpp 2017-06-25 00:07:17 UTC (rev 218791)
+++ trunk/Source/WebCore/page/Page.cpp 2017-06-25 09:22:06 UTC (rev 218792)
@@ -85,7 +85,6 @@
#include "RenderView.h"
#include "RenderWidget.h"
#include "ResourceUsageOverlay.h"
-#include "RuntimeApplicationChecks.h"
#include "RuntimeEnabledFeatures.h"
#include "SVGDocumentExtensions.h"
#include "SchemeRegistry.h"
@@ -1150,13 +1149,6 @@
void Page::suspendScriptedAnimations()
{
-#if PLATFORM(MAC)
- if (MacApplication::isDumpRenderTree()) {
- WTFLogAlways("\nPage::suspendScriptedAnimations() %p", this);
- WTFReportBacktrace();
- }
-#endif
-
m_scriptedAnimationsSuspended = true;
for (Frame* frame = &mainFrame(); frame; frame = frame->tree().traverseNext()) {
if (frame->document())
@@ -1166,13 +1158,6 @@
void Page::resumeScriptedAnimations()
{
-#if PLATFORM(MAC)
- if (MacApplication::isDumpRenderTree()) {
- WTFLogAlways("\nPage::resumeScriptedAnimations() %p", this);
- WTFReportBacktrace();
- }
-#endif
-
m_scriptedAnimationsSuspended = false;
for (Frame* frame = &mainFrame(); frame; frame = frame->tree().traverseNext()) {
if (frame->document())
@@ -1689,10 +1674,6 @@
if (isVisible) {
m_isPrerender = false;
-#if PLATFORM(MAC)
- if (MacApplication::isDumpRenderTree())
- WTFLogAlways("\nPage::setIsVisibleInternal(%s), %p", isVisible ? "true" : "false", this);
-#endif
resumeScriptedAnimations();
#if PLATFORM(IOS)
resumeDeviceMotionAndOrientationUpdates();
@@ -1724,10 +1705,6 @@
suspendDeviceMotionAndOrientationUpdates();
#endif
-#if PLATFORM(MAC)
- if (MacApplication::isDumpRenderTree())
- WTFLogAlways("\nPage::setIsVisibleInternal(%s), %p", isVisible ? "true" : "false", this);
-#endif
suspendScriptedAnimations();
if (FrameView* view = mainFrame().view())
Modified: trunk/Source/WebCore/platform/RuntimeApplicationChecks.h (218791 => 218792)
--- trunk/Source/WebCore/platform/RuntimeApplicationChecks.h 2017-06-25 00:07:17 UTC (rev 218791)
+++ trunk/Source/WebCore/platform/RuntimeApplicationChecks.h 2017-06-25 09:22:06 UTC (rev 218792)
@@ -45,7 +45,6 @@
WEBCORE_EXPORT bool isAdobeInstaller();
WEBCORE_EXPORT bool isAperture();
WEBCORE_EXPORT bool isAppleMail();
-bool isDumpRenderTree();
WEBCORE_EXPORT bool isIBooks();
WEBCORE_EXPORT bool isITunes();
WEBCORE_EXPORT bool isMicrosoftMessenger();
Modified: trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm (218791 => 218792)
--- trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm 2017-06-25 00:07:17 UTC (rev 218791)
+++ trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm 2017-06-25 09:22:06 UTC (rev 218792)
@@ -162,11 +162,6 @@
return isSolidStateNetworksDownloader;
}
-bool MacApplication::isDumpRenderTree()
-{
- return [[[NSProcessInfo processInfo] processName] isEqualToString:@"DumpRenderTree"];
-}
-
#endif // PLATFORM(MAC)
#if PLATFORM(IOS)
