Title: [218813] trunk/Source/WebKit2
Revision
218813
Author
[email protected]
Date
2017-06-26 11:00:40 -0700 (Mon, 26 Jun 2017)

Log Message

When Mission Control closes fullscreen window, allow media element to update its state.
https://bugs.webkit.org/show_bug.cgi?id=173671
rdar://problem/32892671

Patch by Jeremy Jones <[email protected]> on 2017-06-26
Reviewed by Eric Carlson.

When Mission Control closes element fullscreen without an animation, we need to notify the
media element that fullscreen has exited.

Without this change, the page still behaves like the element is in fullscreen.

* UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController beganExitFullScreenWithInitialFrame:finalFrame:]):
(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (218812 => 218813)


--- trunk/Source/WebKit2/ChangeLog	2017-06-26 17:54:38 UTC (rev 218812)
+++ trunk/Source/WebKit2/ChangeLog	2017-06-26 18:00:40 UTC (rev 218813)
@@ -1,3 +1,20 @@
+2017-06-26  Jeremy Jones  <[email protected]>
+
+        When Mission Control closes fullscreen window, allow media element to update its state.
+        https://bugs.webkit.org/show_bug.cgi?id=173671
+        rdar://problem/32892671
+
+        Reviewed by Eric Carlson.
+
+        When Mission Control closes element fullscreen without an animation, we need to notify the
+        media element that fullscreen has exited.
+
+        Without this change, the page still behaves like the element is in fullscreen.
+
+        * UIProcess/mac/WKFullScreenWindowController.mm:
+        (-[WKFullScreenWindowController beganExitFullScreenWithInitialFrame:finalFrame:]):
+        (-[WKFullScreenWindowController finishedExitFullScreenAnimation:]):
+
 2017-06-26  Wenson Hsieh  <[email protected]>
 
         [iOS DnD] [WK2] Beginning a drag session should prevent clicking via long press

Modified: trunk/Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm (218812 => 218813)


--- trunk/Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm	2017-06-26 17:54:38 UTC (rev 218812)
+++ trunk/Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm	2017-06-26 18:00:40 UTC (rev 218813)
@@ -383,6 +383,7 @@
         // fullscreen was exited without being initiated by WebKit. Do not return early, but continue to
         // clean up our state by calling those methods which would have been called by -exitFullscreen,
         // and proceed to close the fullscreen window.
+        [self _manager]->requestExitFullScreen();
         [_webViewPlaceholder setTarget:nil];
         [self _manager]->setAnimatingFullScreen(false);
         [self _manager]->willExitFullScreen();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to