Diff
Modified: trunk/LayoutTests/ChangeLog (218816 => 218817)
--- trunk/LayoutTests/ChangeLog 2017-06-26 18:19:36 UTC (rev 218816)
+++ trunk/LayoutTests/ChangeLog 2017-06-26 18:51:21 UTC (rev 218817)
@@ -1,3 +1,17 @@
+2017-06-26 Jonathan Bedard <[email protected]>
+
+ Unreviewed, rolling out r218783.
+
+ Causing accessibility/mac/setting-attributes-is-
+ asynchronous.html to crash consistently on mac-wk2 Debug
+
+ Reverted changeset:
+
+ "AX: Cannot call setValue() on contenteditable or ARIA text
+ controls"
+ https://bugs.webkit.org/show_bug.cgi?id=173520
+ http://trac.webkit.org/changeset/218783
+
2017-06-26 Youenn Fablet <[email protected]>
Make webrtc/video-replace-track-to-null.html more robust
Deleted: trunk/LayoutTests/accessibility/mac/set-value-editable-types-expected.txt (218816 => 218817)
--- trunk/LayoutTests/accessibility/mac/set-value-editable-types-expected.txt 2017-06-26 18:19:36 UTC (rev 218816)
+++ trunk/LayoutTests/accessibility/mac/set-value-editable-types-expected.txt 2017-06-26 18:51:21 UTC (rev 218817)
@@ -1,16 +0,0 @@
-This tests that you can set the value of a contenteditable element.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-
-Contenteditable
-Role: AXRole: AXTextArea
-Value: AXValue: current1
-Writable: true
-Value change notification received
-Updated Value: AXValue: new value
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
Deleted: trunk/LayoutTests/accessibility/mac/set-value-editable-types.html (218816 => 218817)
--- trunk/LayoutTests/accessibility/mac/set-value-editable-types.html 2017-06-26 18:19:36 UTC (rev 218816)
+++ trunk/LayoutTests/accessibility/mac/set-value-editable-types.html 2017-06-26 18:51:21 UTC (rev 218817)
@@ -1,54 +0,0 @@
-<!DOCTYPE html>
-<html>
-<body id="body">
-<script src=""
-<div id="content">
-
-<div contenteditable="true" id="contenteditable">current1</div>
-
-</div>
-
-<p id="description"></p>
-<div id="console"></div>
-
-<script>
-
- description("This tests that you can set the value of a contenteditable element.");
-
- if (window.accessibilityController) {
- jsTestIsAsync = true;
-
- accessibilityController.addNotificationListener(function(element, notification) {
- if (notification == "AXValueChanged") {
- debug("Value change notification received");
- var axElement = accessibilityController.accessibleElementById("contenteditable");
- debug("Updated Value: " + axElement.stringValue);
- document.getElementById("content").style.visibility = "hidden";
- finishJSTest();
- accessibilityController.removeNotificationListener();
- }
- });
-
- function testElement(idValue) {
- var axElement = accessibilityController.accessibleElementById(idValue);
- debug("Role: " + axElement.role);
- debug("Value: " + axElement.stringValue);
-
- var writable = axElement.isAttributeSettable("AXValue");
- debug("Writable: " + writable);
-
- axElement.setValue("new value");
- }
-
- debug("\nContenteditable");
- testElement("contenteditable");
-
- } else {
- testFailed("Could not load accessibility controller");
- }
-
-</script>
-
-<script src=""
-</body>
-</html>
Modified: trunk/Source/WebCore/ChangeLog (218816 => 218817)
--- trunk/Source/WebCore/ChangeLog 2017-06-26 18:19:36 UTC (rev 218816)
+++ trunk/Source/WebCore/ChangeLog 2017-06-26 18:51:21 UTC (rev 218817)
@@ -1,3 +1,17 @@
+2017-06-26 Jonathan Bedard <[email protected]>
+
+ Unreviewed, rolling out r218783.
+
+ Causing accessibility/mac/setting-attributes-is-
+ asynchronous.html to crash consistently on mac-wk2 Debug
+
+ Reverted changeset:
+
+ "AX: Cannot call setValue() on contenteditable or ARIA text
+ controls"
+ https://bugs.webkit.org/show_bug.cgi?id=173520
+ http://trac.webkit.org/changeset/218783
+
2017-06-26 Yusuke Suzuki <[email protected]>
[WTF] Drop Thread::create(obsolete things) API since we can use lambda
Modified: trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp (218816 => 218817)
--- trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2017-06-26 18:19:36 UTC (rev 218816)
+++ trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2017-06-26 18:51:21 UTC (rev 218817)
@@ -1743,15 +1743,16 @@
if (!m_renderer || !is<Element>(m_renderer->node()))
return;
Element& element = downcast<Element>(*m_renderer->node());
- RenderObject& renderer = *m_renderer;
-
+
+ if (!is<RenderBoxModelObject>(*m_renderer))
+ return;
+ RenderBoxModelObject& renderer = downcast<RenderBoxModelObject>(*m_renderer);
+
// FIXME: Do we want to do anything here for ARIA textboxes?
if (renderer.isTextField() && is<HTMLInputElement>(element))
downcast<HTMLInputElement>(element).setValue(string);
else if (renderer.isTextArea() && is<HTMLTextAreaElement>(element))
downcast<HTMLTextAreaElement>(element).setValue(string);
- else if (is<HTMLElement>(element) && contentEditableAttributeIsEnabled(&element))
- downcast<HTMLElement>(element).setInnerText(string);
}
bool AccessibilityRenderObject::supportsARIAOwns() const
Modified: trunk/Tools/ChangeLog (218816 => 218817)
--- trunk/Tools/ChangeLog 2017-06-26 18:19:36 UTC (rev 218816)
+++ trunk/Tools/ChangeLog 2017-06-26 18:51:21 UTC (rev 218817)
@@ -1,3 +1,17 @@
+2017-06-26 Jonathan Bedard <[email protected]>
+
+ Unreviewed, rolling out r218783.
+
+ Causing accessibility/mac/setting-attributes-is-
+ asynchronous.html to crash consistently on mac-wk2 Debug
+
+ Reverted changeset:
+
+ "AX: Cannot call setValue() on contenteditable or ARIA text
+ controls"
+ https://bugs.webkit.org/show_bug.cgi?id=173520
+ http://trac.webkit.org/changeset/218783
+
2017-06-26 Yusuke Suzuki <[email protected]>
[WTF] Drop Thread::create(obsolete things) API since we can use lambda
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp (218816 => 218817)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp 2017-06-26 18:19:36 UTC (rev 218816)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp 2017-06-26 18:51:21 UTC (rev 218817)
@@ -89,7 +89,6 @@
RefPtr<AccessibilityTextMarkerRange> AccessibilityUIElement::selectedTextMarkerRange() { return nullptr; }
void AccessibilityUIElement::resetSelectedTextMarkerRange() { }
void AccessibilityUIElement::setBoolAttributeValue(JSStringRef, bool) { }
-void AccessibilityUIElement::setValue(JSStringRef) { }
#endif
#if !PLATFORM(COCOA) || !HAVE(ACCESSIBILITY)
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h (218816 => 218817)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h 2017-06-26 18:19:36 UTC (rev 218816)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h 2017-06-26 18:51:21 UTC (rev 218817)
@@ -110,7 +110,6 @@
bool isPressActionSupported();
bool isIncrementActionSupported();
bool isDecrementActionSupported();
- void setValue(JSStringRef);
JSRetainPtr<JSStringRef> role();
JSRetainPtr<JSStringRef> subrole();
JSRetainPtr<JSStringRef> roleDescription();
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl (218816 => 218817)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl 2017-06-26 18:19:36 UTC (rev 218816)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl 2017-06-26 18:51:21 UTC (rev 218817)
@@ -69,7 +69,6 @@
boolean isPressActionSupported();
boolean isIncrementActionSupported();
boolean isDecrementActionSupported();
- void setValue(DOMString value);
readonly attribute DOMString stringValue;
readonly attribute long intValue;
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm (218816 => 218817)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm 2017-06-26 18:19:36 UTC (rev 218816)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm 2017-06-26 18:51:21 UTC (rev 218817)
@@ -589,14 +589,7 @@
[m_element _accessibilitySetTestValue:@(value) forAttribute:[NSString stringWithJSStringRef:attribute]];
END_AX_OBJC_EXCEPTIONS
}
-
-void AccessibilityUIElement::setValue(JSStringRef value)
-{
- BEGIN_AX_OBJC_EXCEPTIONS
- [m_element accessibilitySetValue:[NSString stringWithJSStringRef:value] forAttribute:NSAccessibilityValueAttribute];
- END_AX_OBJC_EXCEPTIONS
-}
-
+
bool AccessibilityUIElement::isAttributeSettable(JSStringRef attribute)
{
BEGIN_AX_OBJC_EXCEPTIONS
