Title: [218832] trunk/Source/WebCore
- Revision
- 218832
- Author
- [email protected]
- Date
- 2017-06-26 23:41:51 -0700 (Mon, 26 Jun 2017)
Log Message
[GTK] Layout Test webrtc/video.html issues "stack smashing detected"
https://bugs.webkit.org/show_bug.cgi?id=173862
Patch by Fujii Hironori <[email protected]> on 2017-06-26
Reviewed by Carlos Garcia Campos.
Tests: webrtc/video.html
Passing a bool variable to g_object_get causes out-of-bound write.
gboolean should be used, which is 4 bytes while bool is one byte.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::muted): Use gboolean instead of bool.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp:
(WebCore::MediaPlayerPrivateGStreamerOwr::trackEnded): Ditto.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (218831 => 218832)
--- trunk/Source/WebCore/ChangeLog 2017-06-27 06:12:31 UTC (rev 218831)
+++ trunk/Source/WebCore/ChangeLog 2017-06-27 06:41:51 UTC (rev 218832)
@@ -1,3 +1,20 @@
+2017-06-26 Fujii Hironori <[email protected]>
+
+ [GTK] Layout Test webrtc/video.html issues "stack smashing detected"
+ https://bugs.webkit.org/show_bug.cgi?id=173862
+
+ Reviewed by Carlos Garcia Campos.
+
+ Tests: webrtc/video.html
+
+ Passing a bool variable to g_object_get causes out-of-bound write.
+ gboolean should be used, which is 4 bytes while bool is one byte.
+
+ * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
+ (WebCore::MediaPlayerPrivateGStreamerBase::muted): Use gboolean instead of bool.
+ * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp:
+ (WebCore::MediaPlayerPrivateGStreamerOwr::trackEnded): Ditto.
+
2017-06-26 Chris Dumez <[email protected]>
WebsiteDataStore::fetchDataForTopPrivatelyControlledDomains() is inefficient
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp (218831 => 218832)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp 2017-06-27 06:12:31 UTC (rev 218831)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp 2017-06-27 06:41:51 UTC (rev 218832)
@@ -500,7 +500,7 @@
if (!m_volumeElement)
return false;
- bool muted;
+ gboolean muted;
g_object_get(m_volumeElement.get(), "mute", &muted, nullptr);
return muted;
}
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp (218831 => 218832)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp 2017-06-27 06:12:31 UTC (rev 218831)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp 2017-06-27 06:41:51 UTC (rev 218832)
@@ -360,8 +360,8 @@
videoTrack->setSelected(false);
}
- bool audioDisabled;
- bool videoDisabled;
+ gboolean audioDisabled;
+ gboolean videoDisabled;
g_object_get(m_audioRenderer.get(), "disabled", &audioDisabled, nullptr);
g_object_get(m_videoRenderer.get(), "disabled", &videoDisabled, nullptr);
if (audioDisabled && videoDisabled) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
