Diff
Modified: trunk/Source/WebCore/ChangeLog (218843 => 218844)
--- trunk/Source/WebCore/ChangeLog 2017-06-27 21:30:01 UTC (rev 218843)
+++ trunk/Source/WebCore/ChangeLog 2017-06-27 21:35:25 UTC (rev 218844)
@@ -1,3 +1,30 @@
+2017-06-27 Youenn Fablet <[email protected]>
+
+ Using public logging for WebRTC release logging
+ https://bugs.webkit.org/show_bug.cgi?id=173881
+
+ Reviewed by Eric Carlson.
+
+ No change of behavior.
+
+ * Modules/mediastream/PeerConnectionBackend.cpp:
+ (WebCore::PeerConnectionBackend::createOfferSucceeded):
+ (WebCore::PeerConnectionBackend::createOfferFailed):
+ (WebCore::PeerConnectionBackend::createAnswerSucceeded):
+ (WebCore::PeerConnectionBackend::createAnswerFailed):
+ (WebCore::PeerConnectionBackend::setLocalDescriptionFailed):
+ (WebCore::PeerConnectionBackend::setRemoteDescriptionFailed):
+ (WebCore::PeerConnectionBackend::addIceCandidateFailed):
+ (WebCore::PeerConnectionBackend::newICECandidate):
+ * Modules/mediastream/RTCPeerConnection.cpp:
+ (WebCore::RTCPeerConnection::queuedSetLocalDescription):
+ (WebCore::RTCPeerConnection::queuedSetRemoteDescription):
+ (WebCore::RTCPeerConnection::queuedAddIceCandidate):
+ (WebCore::RTCPeerConnection::updateIceGatheringState):
+ (WebCore::RTCPeerConnection::updateIceConnectionState):
+ * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
+ (WebCore::LibWebRTCMediaEndpoint::OnStatsDelivered):
+
2017-06-27 Don Olmstead <[email protected]>
[PAL] Add symbol export macros for PAL
Modified: trunk/Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp (218843 => 218844)
--- trunk/Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp 2017-06-27 21:30:01 UTC (rev 218843)
+++ trunk/Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp 2017-06-27 21:35:25 UTC (rev 218844)
@@ -56,7 +56,7 @@
void PeerConnectionBackend::createOfferSucceeded(String&& sdp)
{
ASSERT(isMainThread());
- RELEASE_LOG(WebRTC, "Creating offer succeeded:\n%s\n", sdp.utf8().data());
+ RELEASE_LOG(WebRTC, "Creating offer succeeded:\n%{public}s\n", sdp.utf8().data());
if (m_peerConnection.isClosed())
return;
@@ -69,7 +69,7 @@
void PeerConnectionBackend::createOfferFailed(Exception&& exception)
{
ASSERT(isMainThread());
- RELEASE_LOG(WebRTC, "Creating offer failed:\n%s\n", exception.message().utf8().data());
+ RELEASE_LOG(WebRTC, "Creating offer failed:\n%{public}s\n", exception.message().utf8().data());
if (m_peerConnection.isClosed())
return;
@@ -91,7 +91,7 @@
void PeerConnectionBackend::createAnswerSucceeded(String&& sdp)
{
ASSERT(isMainThread());
- RELEASE_LOG(WebRTC, "Creating answer succeeded:\n%s\n", sdp.utf8().data());
+ RELEASE_LOG(WebRTC, "Creating answer succeeded:\n%{public}s\n", sdp.utf8().data());
if (m_peerConnection.isClosed())
return;
@@ -104,7 +104,7 @@
void PeerConnectionBackend::createAnswerFailed(Exception&& exception)
{
ASSERT(isMainThread());
- RELEASE_LOG(WebRTC, "Creating answer failed:\n%s\n", exception.message().utf8().data());
+ RELEASE_LOG(WebRTC, "Creating answer failed:\n%{public}s\n", exception.message().utf8().data());
if (m_peerConnection.isClosed())
return;
@@ -163,7 +163,7 @@
void PeerConnectionBackend::setLocalDescriptionFailed(Exception&& exception)
{
ASSERT(isMainThread());
- RELEASE_LOG(WebRTC, "Setting local description failed:\n%s\n", exception.message().utf8().data());
+ RELEASE_LOG(WebRTC, "Setting local description failed:\n%{public}s\n", exception.message().utf8().data());
if (m_peerConnection.isClosed())
return;
@@ -223,7 +223,7 @@
void PeerConnectionBackend::setRemoteDescriptionFailed(Exception&& exception)
{
ASSERT(isMainThread());
- RELEASE_LOG(WebRTC, "Setting remote description failed:\n%s\n", exception.message().utf8().data());
+ RELEASE_LOG(WebRTC, "Setting remote description failed:\n%{public}s\n", exception.message().utf8().data());
if (m_peerConnection.isClosed())
return;
@@ -270,7 +270,7 @@
void PeerConnectionBackend::addIceCandidateFailed(Exception&& exception)
{
ASSERT(isMainThread());
- RELEASE_LOG(WebRTC, "Adding ice candidate failed:\n%s\n", exception.message().utf8().data());
+ RELEASE_LOG(WebRTC, "Adding ice candidate failed:\n%{public}s\n", exception.message().utf8().data());
if (m_peerConnection.isClosed())
return;
@@ -349,7 +349,7 @@
void PeerConnectionBackend::newICECandidate(String&& sdp, String&& mid)
{
- RELEASE_LOG(WebRTC, "Gathered ice candidate:\n%s\n", sdp.utf8().data());
+ RELEASE_LOG(WebRTC, "Gathered ice candidate:\n%{public}s\n", sdp.utf8().data());
if (!m_shouldFilterICECandidates) {
fireICECandidateEvent(RTCIceCandidate::create(WTFMove(sdp), WTFMove(mid), 0));
Modified: trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp (218843 => 218844)
--- trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp 2017-06-27 21:30:01 UTC (rev 218843)
+++ trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp 2017-06-27 21:35:25 UTC (rev 218844)
@@ -236,7 +236,7 @@
void RTCPeerConnection::queuedSetLocalDescription(RTCSessionDescription& description, DOMPromiseDeferred<void>&& promise)
{
- RELEASE_LOG(WebRTC, "Setting local description:\n%s\n", description.sdp().utf8().data());
+ RELEASE_LOG(WebRTC, "Setting local description:\n%{public}s\n", description.sdp().utf8().data());
if (isClosed()) {
promise.reject(INVALID_STATE_ERR);
return;
@@ -262,7 +262,7 @@
void RTCPeerConnection::queuedSetRemoteDescription(RTCSessionDescription& description, DOMPromiseDeferred<void>&& promise)
{
- RELEASE_LOG(WebRTC, "Setting remote description:\n%s\n", description.sdp().utf8().data());
+ RELEASE_LOG(WebRTC, "Setting remote description:\n%{public}s\n", description.sdp().utf8().data());
if (isClosed()) {
promise.reject(INVALID_STATE_ERR);
@@ -288,7 +288,7 @@
void RTCPeerConnection::queuedAddIceCandidate(RTCIceCandidate* rtcCandidate, DOMPromiseDeferred<void>&& promise)
{
- RELEASE_LOG(WebRTC, "Received ice candidate:\n%s\n", rtcCandidate ? rtcCandidate->candidate().utf8().data() : "null");
+ RELEASE_LOG(WebRTC, "Received ice candidate:\n%{public}s\n", rtcCandidate ? rtcCandidate->candidate().utf8().data() : "null");
if (isClosed()) {
promise.reject(INVALID_STATE_ERR);
@@ -464,7 +464,7 @@
void RTCPeerConnection::updateIceGatheringState(RTCIceGatheringState newState)
{
- RELEASE_LOG(WebRTC, "New ICE gathering state: %s\n", rtcIceGatheringStateToString(newState));
+ RELEASE_LOG(WebRTC, "New ICE gathering state: %{public}s\n", rtcIceGatheringStateToString(newState));
scriptExecutionContext()->postTask([protectedThis = makeRef(*this), newState](ScriptExecutionContext&) {
if (protectedThis->isClosed() || protectedThis->m_iceGatheringState == newState)
@@ -500,7 +500,7 @@
void RTCPeerConnection::updateIceConnectionState(RTCIceConnectionState newState)
{
- RELEASE_LOG(WebRTC, "New ICE connection state: %s\n", rtcIceConnectionStateToString(newState));
+ RELEASE_LOG(WebRTC, "New ICE connection state: %{public}s\n", rtcIceConnectionStateToString(newState));
scriptExecutionContext()->postTask([protectedThis = makeRef(*this), newState](ScriptExecutionContext&) {
if (protectedThis->isClosed() || protectedThis->m_iceConnectionState == newState)
Modified: trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp (218843 => 218844)
--- trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp 2017-06-27 21:30:01 UTC (rev 218843)
+++ trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp 2017-06-27 21:35:25 UTC (rev 218844)
@@ -1051,7 +1051,7 @@
for (auto iterator = report->begin(); iterator != report->end(); ++iterator) {
if (iterator->type() == webrtc::RTCCodecStats::kType)
continue;
- RELEASE_LOG(WebRTC, "WebRTC stats for %p: %s", this, iterator->ToString().c_str());
+ RELEASE_LOG(WebRTC, "WebRTC stats for %p: %{public}s", this, iterator->ToString().c_str());
}
#else
UNUSED_PARAM(report);
