Title: [218851] trunk
- Revision
- 218851
- Author
- [email protected]
- Date
- 2017-06-27 16:29:22 -0700 (Tue, 27 Jun 2017)
Log Message
Placard icons act like buttons (can get keyboard focus and shows up in VoiceOver)
https://bugs.webkit.org/show_bug.cgi?id=173891
<rdar://problem/33011855>
Patch by Antoine Quint <[email protected]> on 2017-06-27
Reviewed by Dean Jackson.
Source/WebCore:
Ensure that we disable buttons inside placards as they're only decorative and should
not be interactive.
* Modules/modern-media-controls/controls/placard.js:
(Placard.):
LayoutTests:
Update the Placard test to check that its <button> is disabled.
* media/modern-media-controls/placard/placard-expected.txt:
* media/modern-media-controls/placard/placard.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (218850 => 218851)
--- trunk/LayoutTests/ChangeLog 2017-06-27 23:05:07 UTC (rev 218850)
+++ trunk/LayoutTests/ChangeLog 2017-06-27 23:29:22 UTC (rev 218851)
@@ -1,3 +1,16 @@
+2017-06-27 Antoine Quint <[email protected]>
+
+ Placard icons act like buttons (can get keyboard focus and shows up in VoiceOver)
+ https://bugs.webkit.org/show_bug.cgi?id=173891
+ <rdar://problem/33011855>
+
+ Reviewed by Dean Jackson.
+
+ Update the Placard test to check that its <button> is disabled.
+
+ * media/modern-media-controls/placard/placard-expected.txt:
+ * media/modern-media-controls/placard/placard.html:
+
2017-06-27 Jeremy Jones <[email protected]>
Disable m_temporarilyAllowingInlinePlaybackAfterFullscreen on pause
Modified: trunk/LayoutTests/media/modern-media-controls/placard/placard-expected.txt (218850 => 218851)
--- trunk/LayoutTests/media/modern-media-controls/placard/placard-expected.txt 2017-06-27 23:05:07 UTC (rev 218850)
+++ trunk/LayoutTests/media/modern-media-controls/placard/placard-expected.txt 2017-06-27 23:29:22 UTC (rev 218851)
@@ -12,6 +12,7 @@
PASS placard.children[0].children.length is 3
PASS placard.children[0].children[0] instanceof Button is true
PASS placard.children[0].children[0].iconName is Icons.AirplayPlacard
+PASS placard.children[0].children[0].element.disabled is true
PASS placard.children[0].children[1] instanceof LayoutNode is true
PASS placard.children[0].children[1].element.localName is "div"
PASS placard.children[0].children[1].element.className is "title"
Modified: trunk/LayoutTests/media/modern-media-controls/placard/placard.html (218850 => 218851)
--- trunk/LayoutTests/media/modern-media-controls/placard/placard.html 2017-06-27 23:05:07 UTC (rev 218850)
+++ trunk/LayoutTests/media/modern-media-controls/placard/placard.html 2017-06-27 23:29:22 UTC (rev 218851)
@@ -21,6 +21,7 @@
shouldBe("placard.children[0].children.length", "3");
shouldBeTrue("placard.children[0].children[0] instanceof Button");
shouldBe("placard.children[0].children[0].iconName", "Icons.AirplayPlacard");
+shouldBeTrue("placard.children[0].children[0].element.disabled");
shouldBeTrue("placard.children[0].children[1] instanceof LayoutNode");
shouldBeEqualToString("placard.children[0].children[1].element.localName", "div");
shouldBeEqualToString("placard.children[0].children[1].element.className", "title");
Modified: trunk/Source/WebCore/ChangeLog (218850 => 218851)
--- trunk/Source/WebCore/ChangeLog 2017-06-27 23:05:07 UTC (rev 218850)
+++ trunk/Source/WebCore/ChangeLog 2017-06-27 23:29:22 UTC (rev 218851)
@@ -1,3 +1,17 @@
+2017-06-27 Antoine Quint <[email protected]>
+
+ Placard icons act like buttons (can get keyboard focus and shows up in VoiceOver)
+ https://bugs.webkit.org/show_bug.cgi?id=173891
+ <rdar://problem/33011855>
+
+ Reviewed by Dean Jackson.
+
+ Ensure that we disable buttons inside placards as they're only decorative and should
+ not be interactive.
+
+ * Modules/modern-media-controls/controls/placard.js:
+ (Placard.):
+
2017-06-27 Jeremy Jones <[email protected]>
Disable m_temporarilyAllowingInlinePlaybackAfterFullscreen on pause
Modified: trunk/Source/WebCore/Modules/modern-media-controls/controls/placard.js (218850 => 218851)
--- trunk/Source/WebCore/Modules/modern-media-controls/controls/placard.js 2017-06-27 23:05:07 UTC (rev 218850)
+++ trunk/Source/WebCore/Modules/modern-media-controls/controls/placard.js 2017-06-27 23:29:22 UTC (rev 218851)
@@ -41,6 +41,7 @@
if (iconName) {
this._icon = new Button(this);
this._icon.iconName = iconName;
+ this._icon.element.disabled = true;
}
if (!!title)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
