Title: [218857] trunk/Source/WebCore
- Revision
- 218857
- Author
- [email protected]
- Date
- 2017-06-27 18:04:29 -0700 (Tue, 27 Jun 2017)
Log Message
MediaPlayerPrivate m_private may not yet be created when setPrivateBrowsingMode is called.
https://bugs.webkit.org/show_bug.cgi?id=173893
rdar://problem/32986872
Patch by Jeremy Jones <[email protected]> on 2017-06-27
Reviewed by Ryosuke Niwa.
No new tests because no reproducable case.
setPrivateBrowsingMode can be called on MediaPlayer before the MediaPlayerPrivate is created.
The value should only be pushed down the m_private if it has been created.
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::setPrivateBrowsingMode):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (218856 => 218857)
--- trunk/Source/WebCore/ChangeLog 2017-06-28 00:46:50 UTC (rev 218856)
+++ trunk/Source/WebCore/ChangeLog 2017-06-28 01:04:29 UTC (rev 218857)
@@ -1,3 +1,19 @@
+2017-06-27 Jeremy Jones <[email protected]>
+
+ MediaPlayerPrivate m_private may not yet be created when setPrivateBrowsingMode is called.
+ https://bugs.webkit.org/show_bug.cgi?id=173893
+ rdar://problem/32986872
+
+ Reviewed by Ryosuke Niwa.
+
+ No new tests because no reproducable case.
+
+ setPrivateBrowsingMode can be called on MediaPlayer before the MediaPlayerPrivate is created.
+ The value should only be pushed down the m_private if it has been created.
+
+ * platform/graphics/MediaPlayer.cpp:
+ (WebCore::MediaPlayer::setPrivateBrowsingMode):
+
2017-06-27 Wenson Hsieh <[email protected]>
[iOS DnD] Support dragging out of contenteditable areas without a prior selection
Modified: trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp (218856 => 218857)
--- trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp 2017-06-28 00:46:50 UTC (rev 218856)
+++ trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp 2017-06-28 01:04:29 UTC (rev 218857)
@@ -1126,7 +1126,8 @@
void MediaPlayer::setPrivateBrowsingMode(bool privateBrowsingMode)
{
m_privateBrowsing = privateBrowsingMode;
- m_private->setPrivateBrowsingMode(m_privateBrowsing);
+ if (m_private)
+ m_private->setPrivateBrowsingMode(m_privateBrowsing);
}
// Client callbacks.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
