Title: [218866] trunk/Source/_javascript_Core
- Revision
- 218866
- Author
- [email protected]
- Date
- 2017-06-27 22:45:59 -0700 (Tue, 27 Jun 2017)
Log Message
Fix some stale comments in Wasm code base
https://bugs.webkit.org/show_bug.cgi?id=173814
Reviewed by Mark Lam.
* wasm/WasmBinding.cpp:
(JSC::Wasm::wasmToJs):
* wasm/WasmOMGPlan.cpp:
(JSC::Wasm::runOMGPlanForIndex):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (218865 => 218866)
--- trunk/Source/_javascript_Core/ChangeLog 2017-06-28 05:14:24 UTC (rev 218865)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-06-28 05:45:59 UTC (rev 218866)
@@ -1,3 +1,15 @@
+2017-06-27 Saam Barati <[email protected]>
+
+ Fix some stale comments in Wasm code base
+ https://bugs.webkit.org/show_bug.cgi?id=173814
+
+ Reviewed by Mark Lam.
+
+ * wasm/WasmBinding.cpp:
+ (JSC::Wasm::wasmToJs):
+ * wasm/WasmOMGPlan.cpp:
+ (JSC::Wasm::runOMGPlanForIndex):
+
2017-06-27 Caio Lima <[email protected]>
[ESnext] Implement Object Rest - Implementing Object Rest Destructuring
Modified: trunk/Source/_javascript_Core/wasm/WasmBinding.cpp (218865 => 218866)
--- trunk/Source/_javascript_Core/wasm/WasmBinding.cpp 2017-06-28 05:14:24 UTC (rev 218865)
+++ trunk/Source/_javascript_Core/wasm/WasmBinding.cpp 2017-06-28 05:45:59 UTC (rev 218866)
@@ -310,7 +310,10 @@
return FINALIZE_CODE(linkBuffer, ("WebAssembly->_javascript_ import[%i] %s", importIndex, signature.toString().ascii().data()));
}
- // FIXME perform a stack check before updating SP. https://bugs.webkit.org/show_bug.cgi?id=165546
+ // Note: We don't need to perform a stack check here since WasmB3IRGenerator
+ // will do the stack check for us. Whenever it detects that it might make
+ // a call to this thunk, it'll make sure its stack check includes space
+ // for us here.
const unsigned numberOfParameters = argCount + 1; // There is a "this" argument.
const unsigned numberOfRegsForCall = CallFrame::headerSizeInRegisters + numberOfParameters;
Modified: trunk/Source/_javascript_Core/wasm/WasmOMGPlan.cpp (218865 => 218866)
--- trunk/Source/_javascript_Core/wasm/WasmOMGPlan.cpp 2017-06-28 05:14:24 UTC (rev 218865)
+++ trunk/Source/_javascript_Core/wasm/WasmOMGPlan.cpp 2017-06-28 05:45:59 UTC (rev 218866)
@@ -161,7 +161,6 @@
JSWebAssemblyCodeBlock* codeBlock = context->codeBlock();
ASSERT(context->memoryMode() == codeBlock->m_codeBlock->mode());
- // We use the least significant bit of the tierUpCount to represent whether or not someone has already started the tier up.
if (codeBlock->m_codeBlock->tierUpCount(functionIndex).shouldStartTierUp()) {
Ref<Plan> plan = adoptRef(*new OMGPlan(context->module()->module(), functionIndex, codeBlock->m_codeBlock->mode(), Plan::dontFinalize()));
ensureWorklist().enqueue(plan.copyRef());
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
