Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (218896 => 218897)
--- trunk/Source/_javascript_Core/ChangeLog 2017-06-28 22:40:10 UTC (rev 218896)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-06-28 22:53:18 UTC (rev 218897)
@@ -1,3 +1,12 @@
+2017-06-27 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: Remove unused Inspector domain events
+ https://bugs.webkit.org/show_bug.cgi?id=173905
+
+ Reviewed by Matt Baker.
+
+ * inspector/protocol/Inspector.json:
+
2017-06-28 JF Bastien <[email protected]>
Ensure that computed new stack pointer values do not underflow.
Modified: trunk/Source/_javascript_Core/inspector/protocol/Inspector.json (218896 => 218897)
--- trunk/Source/_javascript_Core/inspector/protocol/Inspector.json 2017-06-28 22:40:10 UTC (rev 218896)
+++ trunk/Source/_javascript_Core/inspector/protocol/Inspector.json 2017-06-28 22:53:18 UTC (rev 218897)
@@ -30,22 +30,11 @@
]
},
{
- "name": "detached",
- "description": "Fired when remote debugging connection is about to be terminated. Contains detach reason.",
- "parameters": [
- { "name": "reason", "type": "string", "description": "The reason why connection has been terminated." }
- ]
- },
- {
"name": "activateExtraDomains",
"description": "Fired when the backend has alternate domains that need to be activated.",
"parameters": [
{ "name": "domains", "type": "array", "items": { "type": "string" }, "description": "Domain names that need activation" }
]
- },
- {
- "name": "targetCrashed",
- "description": "Fired when debugging target has crashed"
}
]
}
Modified: trunk/Source/WebInspectorUI/ChangeLog (218896 => 218897)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-06-28 22:40:10 UTC (rev 218896)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-06-28 22:53:18 UTC (rev 218897)
@@ -1,3 +1,27 @@
+2017-06-27 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: Remove unused Inspector domain events
+ https://bugs.webkit.org/show_bug.cgi?id=173905
+
+ Reviewed by Matt Baker.
+
+ * UserInterface/Protocol/InspectorObserver.js:
+ (WebInspector.InspectorObserver.prototype.detached): Deleted.
+
+ * UserInterface/Protocol/Legacy/10.0/InspectorBackendCommands.js:
+ * UserInterface/Protocol/Legacy/10.3/InspectorBackendCommands.js:
+ * UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js:
+ * UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js:
+ * UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js:
+ * UserInterface/Protocol/Legacy/9.3/InspectorBackendCommands.js:
+ * Versions/Inspector-iOS-10.0.json:
+ * Versions/Inspector-iOS-10.3.json:
+ * Versions/Inspector-iOS-7.0.json:
+ * Versions/Inspector-iOS-8.0.json:
+ * Versions/Inspector-iOS-9.0.json:
+ * Versions/Inspector-iOS-9.3.json:
+ Remove from legacy backends as well since they did not send it.
+
2017-06-27 Matt Baker <[email protected]>
Web Inspector: no discoverable way to dismiss the split console
Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/InspectorObserver.js (218896 => 218897)
--- trunk/Source/WebInspectorUI/UserInterface/Protocol/InspectorObserver.js 2017-06-28 22:40:10 UTC (rev 218896)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/InspectorObserver.js 2017-06-28 22:53:18 UTC (rev 218897)
@@ -53,11 +53,6 @@
remoteObject.release();
}
- detached(reason)
- {
- // FIXME: Not implemented.
- }
-
activateExtraDomains(domains)
{
WebInspector.activateExtraDomains(domains);
Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/10.0/InspectorBackendCommands.js (218896 => 218897)
--- trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/10.0/InspectorBackendCommands.js 2017-06-28 22:40:10 UTC (rev 218896)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/10.0/InspectorBackendCommands.js 2017-06-28 22:53:18 UTC (rev 218897)
@@ -234,9 +234,7 @@
InspectorBackend.registerInspectorDispatcher = InspectorBackend.registerDomainDispatcher.bind(InspectorBackend, "Inspector");
InspectorBackend.registerEvent("Inspector.evaluateForTestInFrontend", ["script"]);
InspectorBackend.registerEvent("Inspector.inspect", ["object", "hints"]);
-InspectorBackend.registerEvent("Inspector.detached", ["reason"]);
InspectorBackend.registerEvent("Inspector.activateExtraDomains", ["domains"]);
-InspectorBackend.registerEvent("Inspector.targetCrashed", []);
InspectorBackend.registerCommand("Inspector.enable", [], []);
InspectorBackend.registerCommand("Inspector.disable", [], []);
InspectorBackend.registerCommand("Inspector.initialized", [], []);
Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/10.3/InspectorBackendCommands.js (218896 => 218897)
--- trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/10.3/InspectorBackendCommands.js 2017-06-28 22:40:10 UTC (rev 218896)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/10.3/InspectorBackendCommands.js 2017-06-28 22:53:18 UTC (rev 218897)
@@ -241,9 +241,7 @@
InspectorBackend.registerInspectorDispatcher = InspectorBackend.registerDomainDispatcher.bind(InspectorBackend, "Inspector");
InspectorBackend.registerEvent("Inspector.evaluateForTestInFrontend", ["script"]);
InspectorBackend.registerEvent("Inspector.inspect", ["object", "hints"]);
-InspectorBackend.registerEvent("Inspector.detached", ["reason"]);
InspectorBackend.registerEvent("Inspector.activateExtraDomains", ["domains"]);
-InspectorBackend.registerEvent("Inspector.targetCrashed", []);
InspectorBackend.registerCommand("Inspector.enable", [], []);
InspectorBackend.registerCommand("Inspector.disable", [], []);
InspectorBackend.registerCommand("Inspector.initialized", [], []);
Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js (218896 => 218897)
--- trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js 2017-06-28 22:40:10 UTC (rev 218896)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js 2017-06-28 22:53:18 UTC (rev 218897)
@@ -32,8 +32,6 @@
InspectorBackend.registerInspectorDispatcher = InspectorBackend.registerDomainDispatcher.bind(InspectorBackend, "Inspector");
InspectorBackend.registerEvent("Inspector.evaluateForTestInFrontend", ["testCallId", "script"]);
InspectorBackend.registerEvent("Inspector.inspect", ["object", "hints"]);
-InspectorBackend.registerEvent("Inspector.detached", ["reason"]);
-InspectorBackend.registerEvent("Inspector.targetCrashed", []);
InspectorBackend.registerCommand("Inspector.enable", [], []);
InspectorBackend.registerCommand("Inspector.disable", [], []);
InspectorBackend.activateDomain("Inspector");
Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js (218896 => 218897)
--- trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js 2017-06-28 22:40:10 UTC (rev 218896)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js 2017-06-28 22:53:18 UTC (rev 218897)
@@ -80,8 +80,6 @@
InspectorBackend.registerInspectorDispatcher = InspectorBackend.registerDomainDispatcher.bind(InspectorBackend, "Inspector");
InspectorBackend.registerEvent("Inspector.evaluateForTestInFrontend", ["script"]);
InspectorBackend.registerEvent("Inspector.inspect", ["object", "hints"]);
-InspectorBackend.registerEvent("Inspector.detached", ["reason"]);
-InspectorBackend.registerEvent("Inspector.targetCrashed", []);
InspectorBackend.registerCommand("Inspector.enable", [], []);
InspectorBackend.registerCommand("Inspector.disable", [], []);
InspectorBackend.activateDomain("Inspector");
Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js (218896 => 218897)
--- trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js 2017-06-28 22:40:10 UTC (rev 218896)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js 2017-06-28 22:53:18 UTC (rev 218897)
@@ -210,7 +210,6 @@
InspectorBackend.registerEvent("Inspector.inspect", ["object", "hints"]);
InspectorBackend.registerEvent("Inspector.detached", ["reason"]);
InspectorBackend.registerEvent("Inspector.activateExtraDomains", ["domains"]);
-InspectorBackend.registerEvent("Inspector.targetCrashed", []);
InspectorBackend.registerCommand("Inspector.enable", [], []);
InspectorBackend.registerCommand("Inspector.disable", [], []);
InspectorBackend.registerCommand("Inspector.initialized", [], []);
Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/9.3/InspectorBackendCommands.js (218896 => 218897)
--- trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/9.3/InspectorBackendCommands.js 2017-06-28 22:40:10 UTC (rev 218896)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/9.3/InspectorBackendCommands.js 2017-06-28 22:53:18 UTC (rev 218897)
@@ -215,9 +215,7 @@
InspectorBackend.registerInspectorDispatcher = InspectorBackend.registerDomainDispatcher.bind(InspectorBackend, "Inspector");
InspectorBackend.registerEvent("Inspector.evaluateForTestInFrontend", ["script"]);
InspectorBackend.registerEvent("Inspector.inspect", ["object", "hints"]);
-InspectorBackend.registerEvent("Inspector.detached", ["reason"]);
InspectorBackend.registerEvent("Inspector.activateExtraDomains", ["domains"]);
-InspectorBackend.registerEvent("Inspector.targetCrashed", []);
InspectorBackend.registerCommand("Inspector.enable", [], []);
InspectorBackend.registerCommand("Inspector.disable", [], []);
InspectorBackend.registerCommand("Inspector.initialized", [], []);
Modified: trunk/Source/WebInspectorUI/Versions/Inspector-iOS-10.0.json (218896 => 218897)
--- trunk/Source/WebInspectorUI/Versions/Inspector-iOS-10.0.json 2017-06-28 22:40:10 UTC (rev 218896)
+++ trunk/Source/WebInspectorUI/Versions/Inspector-iOS-10.0.json 2017-06-28 22:53:18 UTC (rev 218897)
@@ -2005,22 +2005,11 @@
]
},
{
- "name": "detached",
- "description": "Fired when remote debugging connection is about to be terminated. Contains detach reason.",
- "parameters": [
- { "name": "reason", "type": "string", "description": "The reason why connection has been terminated." }
- ]
- },
- {
"name": "activateExtraDomains",
"description": "Fired when the backend has alternate domains that need to be activated.",
"parameters": [
{ "name": "domains", "type": "array", "items": { "type": "string" }, "description": "Domain names that need activation" }
]
- },
- {
- "name": "targetCrashed",
- "description": "Fired when debugging target has crashed"
}
]
}
Modified: trunk/Source/WebInspectorUI/Versions/Inspector-iOS-10.3.json (218896 => 218897)
--- trunk/Source/WebInspectorUI/Versions/Inspector-iOS-10.3.json 2017-06-28 22:40:10 UTC (rev 218896)
+++ trunk/Source/WebInspectorUI/Versions/Inspector-iOS-10.3.json 2017-06-28 22:53:18 UTC (rev 218897)
@@ -2048,22 +2048,11 @@
]
},
{
- "name": "detached",
- "description": "Fired when remote debugging connection is about to be terminated. Contains detach reason.",
- "parameters": [
- { "name": "reason", "type": "string", "description": "The reason why connection has been terminated." }
- ]
- },
- {
"name": "activateExtraDomains",
"description": "Fired when the backend has alternate domains that need to be activated.",
"parameters": [
{ "name": "domains", "type": "array", "items": { "type": "string" }, "description": "Domain names that need activation" }
]
- },
- {
- "name": "targetCrashed",
- "description": "Fired when debugging target has crashed"
}
]
}
Modified: trunk/Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json (218896 => 218897)
--- trunk/Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json 2017-06-28 22:40:10 UTC (rev 218896)
+++ trunk/Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json 2017-06-28 22:53:18 UTC (rev 218897)
@@ -26,17 +26,6 @@
{ "name": "object", "$ref": "Runtime.RemoteObject" },
{ "name": "hints", "type": "object" }
]
- },
- {
- "name": "detached",
- "description": "Fired when remote debugging connection is about to be terminated. Contains detach reason.",
- "parameters": [
- { "name": "reason", "type": "string", "description": "The reason why connection has been terminated." }
- ]
- },
- {
- "name": "targetCrashed",
- "description": "Fired when debugging target has crashed"
}
]
},
Modified: trunk/Source/WebInspectorUI/Versions/Inspector-iOS-8.0.json (218896 => 218897)
--- trunk/Source/WebInspectorUI/Versions/Inspector-iOS-8.0.json 2017-06-28 22:40:10 UTC (rev 218896)
+++ trunk/Source/WebInspectorUI/Versions/Inspector-iOS-8.0.json 2017-06-28 22:53:18 UTC (rev 218897)
@@ -452,17 +452,6 @@
{ "name": "object", "$ref": "Runtime.RemoteObject" },
{ "name": "hints", "type": "object" }
]
- },
- {
- "name": "detached",
- "description": "Fired when remote debugging connection is about to be terminated. Contains detach reason.",
- "parameters": [
- { "name": "reason", "type": "string", "description": "The reason why connection has been terminated." }
- ]
- },
- {
- "name": "targetCrashed",
- "description": "Fired when debugging target has crashed"
}
]
}
Modified: trunk/Source/WebInspectorUI/Versions/Inspector-iOS-9.0.json (218896 => 218897)
--- trunk/Source/WebInspectorUI/Versions/Inspector-iOS-9.0.json 2017-06-28 22:40:10 UTC (rev 218896)
+++ trunk/Source/WebInspectorUI/Versions/Inspector-iOS-9.0.json 2017-06-28 22:53:18 UTC (rev 218897)
@@ -1837,10 +1837,6 @@
"parameters": [
{ "name": "domains", "type": "array", "items": { "type": "string" }, "description": "Domain names that need activation" }
]
- },
- {
- "name": "targetCrashed",
- "description": "Fired when debugging target has crashed"
}
]
}
Modified: trunk/Source/WebInspectorUI/Versions/Inspector-iOS-9.3.json (218896 => 218897)
--- trunk/Source/WebInspectorUI/Versions/Inspector-iOS-9.3.json 2017-06-28 22:40:10 UTC (rev 218896)
+++ trunk/Source/WebInspectorUI/Versions/Inspector-iOS-9.3.json 2017-06-28 22:53:18 UTC (rev 218897)
@@ -1884,22 +1884,11 @@
]
},
{
- "name": "detached",
- "description": "Fired when remote debugging connection is about to be terminated. Contains detach reason.",
- "parameters": [
- { "name": "reason", "type": "string", "description": "The reason why connection has been terminated." }
- ]
- },
- {
"name": "activateExtraDomains",
"description": "Fired when the backend has alternate domains that need to be activated.",
"parameters": [
{ "name": "domains", "type": "array", "items": { "type": "string" }, "description": "Domain names that need activation" }
]
- },
- {
- "name": "targetCrashed",
- "description": "Fired when debugging target has crashed"
}
]
}
