Title: [218943] trunk
- Revision
- 218943
- Author
- [email protected]
- Date
- 2017-06-29 10:54:32 -0700 (Thu, 29 Jun 2017)
Log Message
Full stop shows to the right of the picture-in-picture localised string in Hebrew
https://bugs.webkit.org/show_bug.cgi?id=173966
<rdar://problem/32847376>
Patch by Antoine Quint <[email protected]> on 2017-06-29
Reviewed by Dean Jackson.
Source/WebCore:
We manually set the CSS "direction" property to "rtl" when we're not using an LTR language for a placard.
Test: media/modern-media-controls/placard/placard-ltr.html
* Modules/modern-media-controls/controls/placard.css:
(.media-controls:not(.uses-ltr-user-interface-layout-direction) .placard):
LayoutTests:
* media/modern-media-controls/placard/placard-ltr-expected.txt: Added.
* media/modern-media-controls/placard/placard-ltr.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (218942 => 218943)
--- trunk/LayoutTests/ChangeLog 2017-06-29 17:50:15 UTC (rev 218942)
+++ trunk/LayoutTests/ChangeLog 2017-06-29 17:54:32 UTC (rev 218943)
@@ -1,3 +1,14 @@
+2017-06-29 Antoine Quint <[email protected]>
+
+ Full stop shows to the right of the picture-in-picture localised string in Hebrew
+ https://bugs.webkit.org/show_bug.cgi?id=173966
+ <rdar://problem/32847376>
+
+ Reviewed by Dean Jackson.
+
+ * media/modern-media-controls/placard/placard-ltr-expected.txt: Added.
+ * media/modern-media-controls/placard/placard-ltr.html: Added.
+
2017-06-29 Romain Bellessort <[email protected]>
[Readable Streams API] Fix ReadableStream "strategy" argument handling
Added: trunk/LayoutTests/media/modern-media-controls/placard/placard-ltr-expected.txt (0 => 218943)
--- trunk/LayoutTests/media/modern-media-controls/placard/placard-ltr-expected.txt (rev 0)
+++ trunk/LayoutTests/media/modern-media-controls/placard/placard-ltr-expected.txt 2017-06-29 17:54:32 UTC (rev 218943)
@@ -0,0 +1,17 @@
+Testing placard has 'direction: rtl' set for RTL languages.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+Waiting for placard to appear
+PASS !!shadowRoot.querySelector('.placard') became true
+
+Default layout direction is LTR
+PASS getComputedStyle(shadowRoot.querySelector('.placard')).direction became "ltr"
+
+Setting layout direction to RTL
+PASS getComputedStyle(shadowRoot.querySelector('.placard')).direction became "rtl"
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/media/modern-media-controls/placard/placard-ltr.html (0 => 218943)
--- trunk/LayoutTests/media/modern-media-controls/placard/placard-ltr.html (rev 0)
+++ trunk/LayoutTests/media/modern-media-controls/placard/placard-ltr.html 2017-06-29 17:54:32 UTC (rev 218943)
@@ -0,0 +1,32 @@
+<!DOCTYPE html>
+<script src=""
+<body>
+<video src="" style="width: 320px; height: 240px;" controls></video>
+<script type="text/_javascript_">
+
+window.jsTestIsAsync = true;
+
+description("Testing placard has 'direction: rtl' set for RTL languages.");
+
+const media = document.querySelector("video");
+const shadowRoot = window.internals.shadowRoot(media);
+
+media.addEventListener("error", event => {
+ debug("Waiting for placard to appear");
+ shouldBecomeEqual("!!shadowRoot.querySelector('.placard')", "true", () => {
+ debug("");
+ debug("Default layout direction is LTR");
+ shouldBecomeEqualToString("getComputedStyle(shadowRoot.querySelector('.placard')).direction", "ltr", () => {
+ debug("");
+ debug("Setting layout direction to RTL");
+ window.internals.setUserInterfaceLayoutDirection("RTL");
+ shouldBecomeEqualToString("getComputedStyle(shadowRoot.querySelector('.placard')).direction", "rtl", finishJSTest);
+ });
+ });
+});
+
+media.src = ""
+
+</script>
+<script src=""
+</body>
Modified: trunk/Source/WebCore/ChangeLog (218942 => 218943)
--- trunk/Source/WebCore/ChangeLog 2017-06-29 17:50:15 UTC (rev 218942)
+++ trunk/Source/WebCore/ChangeLog 2017-06-29 17:54:32 UTC (rev 218943)
@@ -1,3 +1,18 @@
+2017-06-29 Antoine Quint <[email protected]>
+
+ Full stop shows to the right of the picture-in-picture localised string in Hebrew
+ https://bugs.webkit.org/show_bug.cgi?id=173966
+ <rdar://problem/32847376>
+
+ Reviewed by Dean Jackson.
+
+ We manually set the CSS "direction" property to "rtl" when we're not using an LTR language for a placard.
+
+ Test: media/modern-media-controls/placard/placard-ltr.html
+
+ * Modules/modern-media-controls/controls/placard.css:
+ (.media-controls:not(.uses-ltr-user-interface-layout-direction) .placard):
+
2017-06-29 Brent Fulgham <[email protected]>
Unreviewed Apple CMake build after r218901
Modified: trunk/Source/WebCore/Modules/modern-media-controls/controls/placard.css (218942 => 218943)
--- trunk/Source/WebCore/Modules/modern-media-controls/controls/placard.css 2017-06-29 17:50:15 UTC (rev 218942)
+++ trunk/Source/WebCore/Modules/modern-media-controls/controls/placard.css 2017-06-29 17:54:32 UTC (rev 218943)
@@ -73,3 +73,7 @@
-webkit-box-orient: vertical;
-webkit-line-clamp: 2;
}
+
+.media-controls:not(.uses-ltr-user-interface-layout-direction) .placard {
+ direction: rtl;
+}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
