[webkit-changes] [218990] trunk/LayoutTests

Fri, 30 Jun 2017 00:34:40 -0700

Title: [218990] trunk/LayoutTests
Revision
218990
Author
[email protected]
Date
2017-06-30 00:34:01 -0700 (Fri, 30 Jun 2017)

Log Message

REGRESSION (High Sierra): Gradient LayoutTests are failing
https://bugs.webkit.org/show_bug.cgi?id=174015
<rdar://problem/32332022>

Reviewed by Tim Horton.

Add the fudge factor to more of the gradient tests.

* canvas/philip/tests.js:
(_assertPixelWithGradientNoise): Bump the factor up a bit.
* canvas/philip/tests/2d.gradient.interpolate.multiple.html:
* canvas/philip/tests/2d.gradient.interpolate.solid.html:
* canvas/philip/tests/2d.gradient.radial.transform.1.html:
* canvas/philip/tests/2d.gradient.radial.transform.2.html:
* canvas/philip/tests/2d.gradient.radial.transform.3.html:
* canvas/philip/tests/initial.reset.gradient.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (218989 => 218990)


--- trunk/LayoutTests/ChangeLog	2017-06-30 06:21:04 UTC (rev 218989)
+++ trunk/LayoutTests/ChangeLog	2017-06-30 07:34:01 UTC (rev 218990)
@@ -1,3 +1,22 @@
+2017-06-30  Dean Jackson  <[email protected]>
+
+        REGRESSION (High Sierra): Gradient LayoutTests are failing
+        https://bugs.webkit.org/show_bug.cgi?id=174015
+        <rdar://problem/32332022>
+
+        Reviewed by Tim Horton.
+
+        Add the fudge factor to more of the gradient tests.
+
+        * canvas/philip/tests.js:
+        (_assertPixelWithGradientNoise): Bump the factor up a bit.
+        * canvas/philip/tests/2d.gradient.interpolate.multiple.html:
+        * canvas/philip/tests/2d.gradient.interpolate.solid.html:
+        * canvas/philip/tests/2d.gradient.radial.transform.1.html:
+        * canvas/philip/tests/2d.gradient.radial.transform.2.html:
+        * canvas/philip/tests/2d.gradient.radial.transform.3.html:
+        * canvas/philip/tests/initial.reset.gradient.html:
+
 2017-06-29  Chris Fleizach  <[email protected]>
 
         AX: Cannot call setValue() on contenteditable or ARIA text controls

Modified: trunk/LayoutTests/canvas/philip/tests/2d.gradient.interpolate.multiple.html (218989 => 218990)


--- trunk/LayoutTests/canvas/philip/tests/2d.gradient.interpolate.multiple.html	2017-06-30 06:21:04 UTC (rev 218989)
+++ trunk/LayoutTests/canvas/philip/tests/2d.gradient.interpolate.multiple.html	2017-06-30 07:34:01 UTC (rev 218990)
@@ -19,9 +19,9 @@
 g.addColorStop(1, '#f0f');
 ctx.fillStyle = g;
 ctx.fillRect(0, 0, 200, 50);
-_assertPixelApprox(canvas, 50,25, 127,255,127,255, "50,25", "127,255,127,255", 3);
-_assertPixelApprox(canvas, 100,25, 0,255,255,255, "100,25", "0,255,255,255", 3);
-_assertPixelApprox(canvas, 150,25, 127,127,255,255, "150,25", "127,127,255,255", 3);
+_assertPixelWithGradientNoise(canvas, 50,25, 127,255,127,255, "50,25", "127,255,127,255");
+_assertPixelWithGradientNoise(canvas, 100,25, 0,255,255,255, "100,25", "0,255,255,255");
+_assertPixelWithGradientNoise(canvas, 150,25, 127,127,255,255, "150,25", "127,127,255,255");
 
 
 });

Modified: trunk/LayoutTests/canvas/philip/tests/2d.gradient.interpolate.solid.html (218989 => 218990)


--- trunk/LayoutTests/canvas/philip/tests/2d.gradient.interpolate.solid.html	2017-06-30 06:21:04 UTC (rev 218989)
+++ trunk/LayoutTests/canvas/philip/tests/2d.gradient.interpolate.solid.html	2017-06-30 07:34:01 UTC (rev 218990)
@@ -17,7 +17,7 @@
 g.addColorStop(1, '#0f0');
 ctx.fillStyle = g;
 ctx.fillRect(0, 0, 100, 50);
-_assertPixel(canvas, 50,25, 0,255,0,255, "50,25", "0,255,0,255");
+_assertPixelWithGradientNoise(canvas, 50,25, 0,255,0,255, "50,25", "0,255,0,255");
 
 
 });

Modified: trunk/LayoutTests/canvas/philip/tests/2d.gradient.radial.transform.1.html (218989 => 218990)


--- trunk/LayoutTests/canvas/philip/tests/2d.gradient.radial.transform.1.html	2017-06-30 06:21:04 UTC (rev 218989)
+++ trunk/LayoutTests/canvas/philip/tests/2d.gradient.radial.transform.1.html	2017-06-30 07:34:01 UTC (rev 218990)
@@ -21,9 +21,9 @@
 ctx.translate(50, 25);
 ctx.scale(10, 10);
 ctx.fillRect(-5, -2.5, 10, 5);
-_assertPixel(canvas, 25,25, 0,255,0,255, "25,25", "0,255,0,255");
-_assertPixel(canvas, 50,25, 0,255,0,255, "50,25", "0,255,0,255");
-_assertPixel(canvas, 75,25, 0,255,0,255, "75,25", "0,255,0,255");
+_assertPixelWithGradientNoise(canvas, 25,25, 0,255,0,255, "25,25", "0,255,0,255");
+_assertPixelWithGradientNoise(canvas, 50,25, 0,255,0,255, "50,25", "0,255,0,255");
+_assertPixelWithGradientNoise(canvas, 75,25, 0,255,0,255, "75,25", "0,255,0,255");
 
 
 });

Modified: trunk/LayoutTests/canvas/philip/tests/2d.gradient.radial.transform.2.html (218989 => 218990)


--- trunk/LayoutTests/canvas/philip/tests/2d.gradient.radial.transform.2.html	2017-06-30 06:21:04 UTC (rev 218989)
+++ trunk/LayoutTests/canvas/philip/tests/2d.gradient.radial.transform.2.html	2017-06-30 07:34:01 UTC (rev 218990)
@@ -22,9 +22,9 @@
 ctx.translate(-50, 25);
 ctx.scale(10, 10);
 ctx.fillRect(-5, -2.5, 10, 5);
-_assertPixel(canvas, 25,25, 0,255,0,255, "25,25", "0,255,0,255");
-_assertPixel(canvas, 50,25, 0,255,0,255, "50,25", "0,255,0,255");
-_assertPixel(canvas, 75,25, 0,255,0,255, "75,25", "0,255,0,255");
+_assertPixelWithGradientNoise(canvas, 25,25, 0,255,0,255, "25,25", "0,255,0,255");
+_assertPixelWithGradientNoise(canvas, 50,25, 0,255,0,255, "50,25", "0,255,0,255");
+_assertPixelWithGradientNoise(canvas, 75,25, 0,255,0,255, "75,25", "0,255,0,255");
 
 
 });

Modified: trunk/LayoutTests/canvas/philip/tests/2d.gradient.radial.transform.3.html (218989 => 218990)


--- trunk/LayoutTests/canvas/philip/tests/2d.gradient.radial.transform.3.html	2017-06-30 06:21:04 UTC (rev 218989)
+++ trunk/LayoutTests/canvas/philip/tests/2d.gradient.radial.transform.3.html	2017-06-30 07:34:01 UTC (rev 218990)
@@ -22,9 +22,9 @@
 ctx.translate(50, 25);
 ctx.scale(10, 10);
 ctx.fillRect(-5, -2.5, 10, 5);
-_assertPixel(canvas, 25,25, 0,255,0,255, "25,25", "0,255,0,255");
-_assertPixel(canvas, 50,25, 0,255,0,255, "50,25", "0,255,0,255");
-_assertPixel(canvas, 75,25, 0,255,0,255, "75,25", "0,255,0,255");
+_assertPixelWithGradientNoise(canvas, 25,25, 0,255,0,255, "25,25", "0,255,0,255");
+_assertPixelWithGradientNoise(canvas, 50,25, 0,255,0,255, "50,25", "0,255,0,255");
+_assertPixelWithGradientNoise(canvas, 75,25, 0,255,0,255, "75,25", "0,255,0,255");
 
 
 });

Modified: trunk/LayoutTests/canvas/philip/tests/initial.reset.gradient.html (218989 => 218990)


--- trunk/LayoutTests/canvas/philip/tests/initial.reset.gradient.html	2017-06-30 06:21:04 UTC (rev 218989)
+++ trunk/LayoutTests/canvas/philip/tests/initial.reset.gradient.html	2017-06-30 07:34:01 UTC (rev 218990)
@@ -21,7 +21,7 @@
 ctx.fillRect(0, 0, 100, 50);
 ctx.fillStyle = g;
 ctx.fillRect(0, 0, 100, 50);
-_assertPixel(canvas, 50,25, 0,255,0,255, "50,25", "0,255,0,255");
+_assertPixelWithGradientNoise(canvas, 50,25, 0,255,0,255, "50,25", "0,255,0,255");
 
 
 });

Modified: trunk/LayoutTests/canvas/philip/tests.js (218989 => 218990)


--- trunk/LayoutTests/canvas/philip/tests.js	2017-06-30 06:21:04 UTC (rev 218989)
+++ trunk/LayoutTests/canvas/philip/tests.js	2017-06-30 07:34:01 UTC (rev 218990)
@@ -98,7 +98,7 @@
 
 function _assertPixelWithGradientNoise(canvas, x,y, r,g,b,a, pos, colour)
 {
-    _assertPixelApprox(canvas, x, y, r, g, b, a, pos, colour, 3);
+    _assertPixelApprox(canvas, x, y, r, g, b, a, pos, colour, 5);
 }
 
 function _assertPixelApprox(canvas, x,y, r,g,b,a, pos, colour, tolerance)

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to