Diff
Modified: trunk/LayoutTests/ChangeLog (99820 => 99821)
--- trunk/LayoutTests/ChangeLog 2011-11-10 08:08:32 UTC (rev 99820)
+++ trunk/LayoutTests/ChangeLog 2011-11-10 08:17:27 UTC (rev 99821)
@@ -1,3 +1,20 @@
+2011-11-10 Sheriff Bot <[email protected]>
+
+ Unreviewed, rolling out r99816.
+ http://trac.webkit.org/changeset/99816
+ https://bugs.webkit.org/show_bug.cgi?id=72003
+
+ compilation failed on mac (Requested by loislo on #webkit).
+
+ * fast/forms/form-dirname-attribute-expected.txt: Removed.
+ * fast/forms/form-dirname-attribute.html: Removed.
+ * fast/forms/submit-form-with-dirname-attribute-expected.txt: Removed.
+ * fast/forms/submit-form-with-dirname-attribute-with-ancestor-dir-attribute-expected.txt: Removed.
+ * fast/forms/submit-form-with-dirname-attribute-with-ancestor-dir-attribute.html: Removed.
+ * fast/forms/submit-form-with-dirname-attribute-with-nonhtml-ancestor-expected.txt: Removed.
+ * fast/forms/submit-form-with-dirname-attribute-with-nonhtml-ancestor.html: Removed.
+ * fast/forms/submit-form-with-dirname-attribute.html: Removed.
+
2011-11-10 Yuta Kitamura <[email protected]>
[Chromium] Unreviewed, rebaseline SVG test results changed after r99539. (part 1)
Deleted: trunk/LayoutTests/fast/forms/form-dirname-attribute-expected.txt (99820 => 99821)
--- trunk/LayoutTests/fast/forms/form-dirname-attribute-expected.txt 2011-11-10 08:08:32 UTC (rev 99820)
+++ trunk/LayoutTests/fast/forms/form-dirname-attribute-expected.txt 2011-11-10 08:17:27 UTC (rev 99821)
@@ -1,8 +0,0 @@
-"dirname" attribute
-
-PASS input.dirName is "Hello"
-PASS textArea.dirName is "Hello"
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
Deleted: trunk/LayoutTests/fast/forms/form-dirname-attribute.html (99820 => 99821)
--- trunk/LayoutTests/fast/forms/form-dirname-attribute.html 2011-11-10 08:08:32 UTC (rev 99820)
+++ trunk/LayoutTests/fast/forms/form-dirname-attribute.html 2011-11-10 08:17:27 UTC (rev 99821)
@@ -1,23 +0,0 @@
-<!DOCTYPE html>
-<html>
-<head>
-<meta charset="utf-8">
-<link rel="stylesheet" href=""
-<script src="" </script>
-</head>
-<body>
-<p>"dirname" attribute</p>
-<pre id="console"></pre>
-<script>
-var input = document.createElement('input');
-input.setAttribute('dirName', "Hello");
-shouldBeEqualToString('input.dirName', "Hello");
-
-var textArea = document.createElement('textarea');
-textArea.setAttribute('dirName', "Hello");
-shouldBeEqualToString('textArea.dirName', "Hello");
-successfullyParsed = true;
-</script>
-<script src=""
-</body>
-</html>
Deleted: trunk/LayoutTests/fast/forms/submit-form-with-dirname-attribute-expected.txt (99820 => 99821)
--- trunk/LayoutTests/fast/forms/submit-form-with-dirname-attribute-expected.txt 2011-11-10 08:08:32 UTC (rev 99820)
+++ trunk/LayoutTests/fast/forms/submit-form-with-dirname-attribute-expected.txt 2011-11-10 08:17:27 UTC (rev 99821)
@@ -1,23 +0,0 @@
-Test that when dirname attribute is specified then it is added in submission body.
-
-Comment:
-
-WithRTLDir:
-
-WithLTRDir:
-
-WithInvalidDir:
-
-WithRTLValue:
-
-Post Comment
-
-PASS document.location.search.indexOf("comment.dir=ltr") != -1 is true
-PASS document.location.search.indexOf("txtareaRTL.dir=rtl") != -1 is true
-PASS document.location.search.indexOf("txtareaLTR.dir=ltr") != -1 is true
-PASS document.location.search.indexOf("txtareaInvalid.dir=ltr") != -1 is true
-PASS document.location.search.indexOf("inputRTLvalue.dir=ltr") != -1 is true
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
Deleted: trunk/LayoutTests/fast/forms/submit-form-with-dirname-attribute-with-ancestor-dir-attribute-expected.txt (99820 => 99821)
--- trunk/LayoutTests/fast/forms/submit-form-with-dirname-attribute-with-ancestor-dir-attribute-expected.txt 2011-11-10 08:08:32 UTC (rev 99820)
+++ trunk/LayoutTests/fast/forms/submit-form-with-dirname-attribute-with-ancestor-dir-attribute-expected.txt 2011-11-10 08:17:27 UTC (rev 99821)
@@ -1,13 +0,0 @@
-Test that when dirname attribute is specified then it is added in submission body.
-
-
-
-Post Comment
-
-Hello
-PASS document.location.search.indexOf("rtlAncestor.dir=rtl") != -1 is true
-PASS document.location.search.indexOf("autoAncestor.dir=ltr") != -1 is true
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
Deleted: trunk/LayoutTests/fast/forms/submit-form-with-dirname-attribute-with-ancestor-dir-attribute.html (99820 => 99821)
--- trunk/LayoutTests/fast/forms/submit-form-with-dirname-attribute-with-ancestor-dir-attribute.html 2011-11-10 08:08:32 UTC (rev 99820)
+++ trunk/LayoutTests/fast/forms/submit-form-with-dirname-attribute-with-ancestor-dir-attribute.html 2011-11-10 08:17:27 UTC (rev 99821)
@@ -1,41 +0,0 @@
-<html>
-<head>
-<meta http-equiv="content-type" content="text/html; charset=UTF-8">
-</head>
-<script src="" </script>
-<script>
-window.jsTestIsAsync = true;
-
-function test() {
- document.forms.f.submit();
-}
-</script>
-<body _onload_="test()">
-<p>Test that when dirname attribute is specified then it is added in submission body.</p>
-
-<div dir="auto">
- <form action="" method="GET" name="f">
- <div dir="rtl">
- <input type=text name="comment" dirname="rtlAncestor.dir" required>
- </div>
- <input type=text name="autoAncestor" dirname="autoAncestor.dir" value="שלום">
- <p><button name="mode" type=submit value="add">Post Comment</button></p>
- </form>
-Hello
-</div>
-
-<div id="console"></div>
-<div id="action">
-<script>
-if (document.location.href.match('\\?')) {
- shouldBeTrue('document.location.search.indexOf("rtlAncestor.dir=rtl") != -1');
- shouldBeTrue('document.location.search.indexOf("autoAncestor.dir=ltr") != -1');
- finishJSTest();
-}
-
-successfullyParsed = true;
-</script>
-</div>
-<script src=""
-</body>
-</html>
Deleted: trunk/LayoutTests/fast/forms/submit-form-with-dirname-attribute-with-nonhtml-ancestor-expected.txt (99820 => 99821)
--- trunk/LayoutTests/fast/forms/submit-form-with-dirname-attribute-with-nonhtml-ancestor-expected.txt 2011-11-10 08:08:32 UTC (rev 99820)
+++ trunk/LayoutTests/fast/forms/submit-form-with-dirname-attribute-with-nonhtml-ancestor-expected.txt 2011-11-10 08:17:27 UTC (rev 99821)
@@ -1,10 +0,0 @@
-Test that when dir attribute is specified for non html element, it is not considered for dirname attribute value in submission body.
-
-
-Post Comment
-
-PASS document.location.search.indexOf("nonHtmlAncestor.dir=ltr") != -1 is true
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
Deleted: trunk/LayoutTests/fast/forms/submit-form-with-dirname-attribute-with-nonhtml-ancestor.html (99820 => 99821)
--- trunk/LayoutTests/fast/forms/submit-form-with-dirname-attribute-with-nonhtml-ancestor.html 2011-11-10 08:08:32 UTC (rev 99820)
+++ trunk/LayoutTests/fast/forms/submit-form-with-dirname-attribute-with-nonhtml-ancestor.html 2011-11-10 08:17:27 UTC (rev 99821)
@@ -1,36 +0,0 @@
-<html>
-<head>
-<meta http-equiv="content-type" content="text/html; charset=UTF-8">
-</head>
-<script src="" </script>
-<script>
-window.jsTestIsAsync = true;
-
-function test() {
- document.forms.f.submit();
-}
-</script>
-<body _onload_="test()">
-<p>Test that when dir attribute is specified for non html element, it is not considered for dirname attribute value in submission body.</p>
-<svg xmlns="http://www.w3.org/2000/svg" width="100%" height="100%" viewBox="0 0 400 400" dir="rtl">
- <div>
- <form action="" method="GET" name="f">
- <input type=text name="nonHtmlAncestor" dirname="nonHtmlAncestor.dir">
- <p><button name="mode" type=submit value="add">Post Comment</button></p>
- </form>
- </div>
-</svg>
-<div id="console"></div>
-<div id="action">
-<script>
-if (document.location.href.match('\\?')) {
- shouldBeTrue('document.location.search.indexOf("nonHtmlAncestor.dir=ltr") != -1');
- finishJSTest();
-}
-
-successfullyParsed = true;
-</script>
-</div>
-<script src=""
-</body>
-</html>
Deleted: trunk/LayoutTests/fast/forms/submit-form-with-dirname-attribute.html (99820 => 99821)
--- trunk/LayoutTests/fast/forms/submit-form-with-dirname-attribute.html 2011-11-10 08:08:32 UTC (rev 99820)
+++ trunk/LayoutTests/fast/forms/submit-form-with-dirname-attribute.html 2011-11-10 08:17:27 UTC (rev 99821)
@@ -1,42 +0,0 @@
-<html>
-<head>
-<meta http-equiv="content-type" content="text/html; charset=UTF-8">
-</head>
-<script src="" </script>
-<script>
-window.jsTestIsAsync = true;
-
-function test() {
- document.forms.f.submit();
-}
-</script>
-<body _onload_="test()">
-<p>Test that when dirname attribute is specified then it is added in submission body.</p>
-
-<form action="" name="f">
- <p><label>Comment: <input type=text name="comment" dirname="comment.dir" required></label></p>
- <p><label>WithRTLDir: <textarea name="txtarea" dir="rtl" dirname="txtareaRTL.dir"></textarea></label></p>
- <p><label>WithLTRDir: <textarea name="txtarea1" dir="ltr" dirname="txtareaLTR.dir"></textarea></label></p>
- <p><label>WithInvalidDir: <textarea name="txtarea2" dir="invalid" dirname="txtareaInvalid.dir"></textarea></label></p>
- <p><label>WithRTLValue: <input name="input" dirname="inputRTLvalue.dir" value="مرحبًا"></label></p>
- <p><button name="mode" type=submit value="add">Post Comment</button></p>
-</form>
-
-<div id="console"></div>
-<div id="action">
-<script>
-if (document.location.href.match('\\?')) {
- shouldBeTrue('document.location.search.indexOf("comment.dir=ltr") != -1');
- shouldBeTrue('document.location.search.indexOf("txtareaRTL.dir=rtl") != -1');
- shouldBeTrue('document.location.search.indexOf("txtareaLTR.dir=ltr") != -1');
- shouldBeTrue('document.location.search.indexOf("txtareaInvalid.dir=ltr") != -1');
- shouldBeTrue('document.location.search.indexOf("inputRTLvalue.dir=ltr") != -1');
- finishJSTest();
-}
-
-successfullyParsed = true;
-</script>
-</div>
-<script src=""
-</body>
-</html>
Modified: trunk/Source/WebCore/ChangeLog (99820 => 99821)
--- trunk/Source/WebCore/ChangeLog 2011-11-10 08:08:32 UTC (rev 99820)
+++ trunk/Source/WebCore/ChangeLog 2011-11-10 08:17:27 UTC (rev 99821)
@@ -1,3 +1,21 @@
+2011-11-10 Sheriff Bot <[email protected]>
+
+ Unreviewed, rolling out r99816.
+ http://trac.webkit.org/changeset/99816
+ https://bugs.webkit.org/show_bug.cgi?id=72003
+
+ compilation failed on mac (Requested by loislo on #webkit).
+
+ * html/HTMLAttributeNames.in:
+ * html/HTMLInputElement.idl:
+ * html/HTMLTextAreaElement.cpp:
+ (WebCore::HTMLTextAreaElement::appendFormData):
+ * html/HTMLTextAreaElement.idl:
+ * html/HTMLTextFormControlElement.cpp:
+ * html/HTMLTextFormControlElement.h:
+ * html/TextFieldInputType.cpp:
+ * html/TextFieldInputType.h:
+
2011-11-09 Pavel Feldman <[email protected]>
Web Inspector: console does not work after switching panel while editing.
Modified: trunk/Source/WebCore/html/HTMLAttributeNames.in (99820 => 99821)
--- trunk/Source/WebCore/html/HTMLAttributeNames.in 2011-11-10 08:08:32 UTC (rev 99820)
+++ trunk/Source/WebCore/html/HTMLAttributeNames.in 2011-11-10 08:17:27 UTC (rev 99821)
@@ -90,7 +90,6 @@
defer
dir
direction
-dirname
disabled
download
draggable
Modified: trunk/Source/WebCore/html/HTMLInputElement.idl (99820 => 99821)
--- trunk/Source/WebCore/html/HTMLInputElement.idl 2011-11-10 08:08:32 UTC (rev 99820)
+++ trunk/Source/WebCore/html/HTMLInputElement.idl 2011-11-10 08:17:27 UTC (rev 99821)
@@ -23,7 +23,6 @@
interface HTMLInputElement : HTMLElement {
attribute [ConvertNullToNullString] DOMString defaultValue;
attribute [Reflect=checked] boolean defaultChecked;
- attribute [Reflect] DOMString dirName;
readonly attribute HTMLFormElement form;
attribute [Reflect, URL] DOMString formAction;
attribute [ConvertNullToNullString] DOMString formEnctype;
Modified: trunk/Source/WebCore/html/HTMLTextAreaElement.cpp (99820 => 99821)
--- trunk/Source/WebCore/html/HTMLTextAreaElement.cpp 2011-11-10 08:08:32 UTC (rev 99820)
+++ trunk/Source/WebCore/html/HTMLTextAreaElement.cpp 2011-11-10 08:17:27 UTC (rev 99821)
@@ -173,11 +173,7 @@
const String& text = (m_wrap == HardWrap) ? valueWithHardLineBreaks() : value();
encoding.appendData(name(), text);
-
- const AtomicString& dirnameAttrValue = fastGetAttribute(dirnameAttr);
- if (!dirnameAttrValue.isNull())
- encoding.appendData(dirnameAttrValue, directionForFormData());
- return true;
+ return true;
}
void HTMLTextAreaElement::reset()
Modified: trunk/Source/WebCore/html/HTMLTextAreaElement.idl (99820 => 99821)
--- trunk/Source/WebCore/html/HTMLTextAreaElement.idl 2011-11-10 08:08:32 UTC (rev 99820)
+++ trunk/Source/WebCore/html/HTMLTextAreaElement.idl 2011-11-10 08:17:27 UTC (rev 99821)
@@ -27,7 +27,6 @@
readonly attribute ValidityState validity;
attribute [Reflect] DOMString accessKey;
attribute long cols;
- attribute [Reflect] DOMString dirName;
attribute [Reflect] boolean disabled;
attribute [Reflect] boolean autofocus;
attribute long maxLength setter raises(DOMException);
Modified: trunk/Source/WebCore/html/HTMLTextFormControlElement.cpp (99820 => 99821)
--- trunk/Source/WebCore/html/HTMLTextFormControlElement.cpp 2011-11-10 08:08:32 UTC (rev 99820)
+++ trunk/Source/WebCore/html/HTMLTextFormControlElement.cpp 2011-11-10 08:17:27 UTC (rev 99821)
@@ -570,34 +570,4 @@
return ancestor != container ? toTextFormControl(ancestor) : 0;
}
-const Element* parentHTMLElement(const Element* element)
-{
- while (element) {
- element = element->parentElement();
- if (element && element->isHTMLElement())
- return element;
- }
- return 0;
-}
-
-String HTMLTextFormControlElement::directionForFormData() const
-{
- for (const Element* element = this; element; element = parentHTMLElement(element)) {
- const AtomicString& dirAttributeValue = element->fastGetAttribute(dirAttr);
- if (dirAttributeValue.isNull())
- continue;
-
- if (equalIgnoringCase(dirAttributeValue, "rtl") || equalIgnoringCase(dirAttributeValue, "ltr"))
- return dirAttributeValue;
-
- if (equalIgnoringCase(dirAttributeValue, "auto")) {
- bool isAuto;
- TextDirection textDirection = static_cast<const HTMLElement*>(element)->directionalityIfhasDirAutoAttribute(isAuto);
- return textDirection == RTL ? "rtl" : "ltr";
- }
- }
-
- return "ltr";
-}
-
} // namespace Webcore
Modified: trunk/Source/WebCore/html/HTMLTextFormControlElement.h (99820 => 99821)
--- trunk/Source/WebCore/html/HTMLTextFormControlElement.h 2011-11-10 08:08:32 UTC (rev 99820)
+++ trunk/Source/WebCore/html/HTMLTextFormControlElement.h 2011-11-10 08:17:27 UTC (rev 99821)
@@ -79,8 +79,6 @@
void setInnerTextValue(const String&);
String innerTextValue() const;
- String directionForFormData() const;
-
protected:
HTMLTextFormControlElement(const QualifiedName&, Document*, HTMLFormElement*);
virtual void updatePlaceholderText() = 0;
Modified: trunk/Source/WebCore/html/TextFieldInputType.cpp (99820 => 99821)
--- trunk/Source/WebCore/html/TextFieldInputType.cpp 2011-11-10 08:08:32 UTC (rev 99820)
+++ trunk/Source/WebCore/html/TextFieldInputType.cpp 2011-11-10 08:17:27 UTC (rev 99821)
@@ -33,10 +33,8 @@
#include "TextFieldInputType.h"
#include "BeforeTextInsertedEvent.h"
-#include "FormDataList.h"
#include "Frame.h"
#include "HTMLInputElement.h"
-#include "HTMLNames.h"
#include "KeyboardEvent.h"
#include "Page.h"
#include "RenderLayer.h"
@@ -51,8 +49,6 @@
namespace WebCore {
-using namespace HTMLNames;
-
TextFieldInputType::TextFieldInputType(HTMLInputElement* element)
: InputType(element)
{
@@ -368,13 +364,4 @@
ASSERT(!ec);
}
-bool TextFieldInputType::appendFormData(FormDataList& list, bool multipart) const
-{
- InputType::appendFormData(list, multipart);
- const AtomicString& dirnameAttrValue = element()->fastGetAttribute(dirnameAttr);
- if (!dirnameAttrValue.isNull())
- list.appendData(dirnameAttrValue, element()->directionForFormData());
- return true;
-}
-
} // namespace WebCore
Modified: trunk/Source/WebCore/html/TextFieldInputType.h (99820 => 99821)
--- trunk/Source/WebCore/html/TextFieldInputType.h 2011-11-10 08:08:32 UTC (rev 99820)
+++ trunk/Source/WebCore/html/TextFieldInputType.h 2011-11-10 08:17:27 UTC (rev 99821)
@@ -35,7 +35,6 @@
namespace WebCore {
-class FormDataList;
class SpinButtonElement;
// The class represents types of which UI contain text fields.
@@ -78,7 +77,6 @@
virtual bool shouldRespectListAttribute();
virtual HTMLElement* placeholderElement() const;
virtual void updatePlaceholderText();
- virtual bool appendFormData(FormDataList&, bool multipart) const;
RefPtr<HTMLElement> m_container;
RefPtr<HTMLElement> m_innerBlock;
